From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 7C6621B6D2 for ; Mon, 23 Oct 2017 22:59:07 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E0A3E2097E; Mon, 23 Oct 2017 16:59:06 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Mon, 23 Oct 2017 16:59:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=d25GHG7XjN1aHoaoOihjua+MSx mT9akscekbCl/82po=; b=AneDbD+xxpuwzrqtnxU9hSNPheuyI/RJqsFWx14xWC EvkNXRGb5i7lhOS4T4tr/ij5R/ifR9e5A5IiRFpwrIfp+MDbl1qZhYAsE8XboH+m CFppBL9BBi1fPn3CKqYBAwT8NhP27o2EmXgeAO+qYDssA24E0byG6aw0Kk14a0RK Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=d25GHG 7XjN1aHoaoOihjua+MSxmT9akscekbCl/82po=; b=gd6gl8gyjqH2GkFsPWQIcg 4Ct1Jfd7bBFml2Ub6lbfwQcD4I5cEtNx79QbD1+syn5Aj7ZAigTaoGPVy/+gc/5+ HSN9qfCBMvbJMcp8J9xPERf1MUG/P8q//egwTeeGwvYnZkxsMLu8goE8bHZ5LlbH 9pvkWof0Lms6ZY6XgCOXDugxFKW3AQV8QmHMd6fAREmO45DHATnJkCbW+O+SIPYR Ct7a64m9mz3yMlCOZ+CppcZWlQhHnyMJ+w0Ptn/voD7t3NqGsIiydlyYLr3c7XOA a5G2tEe4RZtu01USf8RlPAUNdG+nVdnTodq2B2D4vZTysP17VY5gV7URSuzCpbKw == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9C1F12484E; Mon, 23 Oct 2017 16:59:06 -0400 (EDT) From: Thomas Monjalon To: Bernard Iremonger Cc: dev@dpdk.org, ferruh.yigit@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, adrien.mazarguil@6wind.com, jasvinder.singh@intel.com, john.mcnamara@intel.com Date: Mon, 23 Oct 2017 22:59:05 +0200 Message-ID: <2082789.j6r8FRWjAK@xps> In-Reply-To: <1508771778-617-1-git-send-email-bernard.iremonger@intel.com> References: <1508679124-5922-1-git-send-email-bernard.iremonger@intel.com> <1508771778-617-1-git-send-email-bernard.iremonger@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v10 0/4] flow classification library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2017 20:59:07 -0000 23/10/2017 17:16, Bernard Iremonger: > The initial implementation is to provide counting of IPv4 five tuple packets for UDP, TCP and SCTP, > but the library is planned to be as generic as possible. > > The flow information provided by this library is missing to implement full IPFIX features, > but this is planned to be the initial step. > > Flows are defined using rte_flow, also measurements (actions) are provided by rte_flow. > To support more IPFIX measurements, the implementation may require extending rte_flow in addition to > extending this library. > > The library uses both flows and actions defined by rte_flow.h so this library has a dependency on > rte_flow.h > > This patch set also contains a set of unit tests for the Flow Classify library, patch(4) and > a patch(3) containing additional functions added to the packet burst generator code. > > For further steps, this library may be expanded to benefit from hardware filters for better performance. > > It will be more beneficial to shape this library to cover more use cases, > please feel free to comment on possible other use cases and desired functionalities. I had some feedbacks that this library won't be ready for 17.11. So I did not review it. I suppose you are OK to wait one more release and call for more reviewers?