From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0AD18A00C2; Thu, 6 Oct 2022 15:36:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DAD6F42C67; Thu, 6 Oct 2022 15:36:18 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id 843BE42C66 for ; Thu, 6 Oct 2022 15:36:17 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id EA0163200754; Thu, 6 Oct 2022 09:36:15 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 06 Oct 2022 09:36:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1665063375; x= 1665149775; bh=ifjVHhjyr8ymnkDiUmGjTeQRR7B8BL8OauzyhZZet0U=; b=i g3h6c9URJog9mCVySlRuX21FqIjJz6w8JQyTXtUSYokJ8r7iw36B6nCivYXgueZX YtQnk9Mhp46JaNqYRvwJ/YBx4vAWAuowPJoEvJvVz3QnGOYLAkSKLFwY91VgQxz1 KBVpBCqMb5jxcnQ3vWkv0gE1RFqHEAr4E5ohHvQaKI4RVIksnTDAiQ/B1bZnY7IG A9OFhRGwmaGHmsXvsKxSW9xstpLSmG8/ZLKjNV7s2db9pDzH+3U24oookQmJuquu pB3gKRe9rr0MOl27/dXqtTVY1PyoSRjy4tqf8D0IRU/l8ps6fjTRIo9YKCbDT82K Gj9Iv8jqOSUf4pjtB078Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1665063375; x= 1665149775; bh=ifjVHhjyr8ymnkDiUmGjTeQRR7B8BL8OauzyhZZet0U=; b=0 vMsP0oAPdYMuoOZCs0vXGRVOjvi9cLcVQcpcKrEtKY1HGa5sA09a5XWyYQxxUnAG HAU0eitAxSQ0+s7o/RUbRvXQzIbt8xW1iEdX/H9xM8W+GymCcZsRvj4dVglfqI20 /A059O9Hs/3iLljkv8k1/iM99Tm93diL7akcP56NoW8SOUfR8qh1L1MIG0aoZ4u0 XKvi2hIS4/asAx8nd2QyB0jzzqgsRh2Z4yoRXJ1Ul8avlUbCU+MzMt32AFpohCj9 AHCF+U20KDoXo1S6cVMtMgUwTVlFn1KyHYM/AXxg9FfRvXStdNdW8Mg2uF6upg5i Jy3PliICoH4jz7JDQC/4Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeihedgieeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 6 Oct 2022 09:36:14 -0400 (EDT) From: Thomas Monjalon To: Tyler Retzlaff Cc: David Marchand , dmitry.kozliuk@gmail.com, dev@dpdk.org, anatoly.burakov@intel.com Subject: Re: [PATCH v4 0/6] add thread lifetime and attributes API Date: Thu, 06 Oct 2022 15:36:12 +0200 Message-ID: <2082798.OBFZWjSADL@thomas> In-Reply-To: <20221005163439.GC7581@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1654783134-13303-1-git-send-email-roretzla@linux.microsoft.com> <20221005161126.GB7581@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <20221005163439.GC7581@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 05/10/2022 18:34, Tyler Retzlaff: > On Wed, Oct 05, 2022 at 09:11:26AM -0700, Tyler Retzlaff wrote: > > > Newly added code can go to eal_common_thread.c rather than introduce a > > > new common/rte_thread.c file (or is there a rationale for this?). > > > > i will make this change in the next revision. if anyone does object i > > hope they will do so quickly. > > looking at this more closely i'm going to back away from making the > adjustment here. if Thomas and/or Dmitry could comment it would be > appreciated. > > it appears that functions placed in eal_common_xxx files are consumed > internally by the eal where rte_xxx files are functions that are exposed > through public api. It is not so clear. There is already eal_common_thread.c which implements the same kind of functions, so I think you should move your new functions here. > since these additions are public api it seems they should remain in > rte_thread.c Let's not have 2 .c files for the same purpose in the same directory. > i won't change this in the next revision, but please do correct me if > i'm still not on track. Please I would prefer to keep all in one file: eal_common_thread.c Thank you