From: Thomas Monjalon <thomas@monjalon.net>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: Tasnim Bashar <tbashar@mellanox.com>,
dev@dpdk.org, harini.ramakrishnan@microsoft.com,
pallavi.kadam@intel.com, ranjit.menon@intel.com,
ocardona@microsoft.com, navasile@linux.microsoft.com,
talshn@mellanox.com, fady@mellanox.com, ophirmu@mellanox.com
Subject: Re: [dpdk-dev] [PATCH v2] eal/windows: fix invalid thread handle
Date: Mon, 25 May 2020 08:59:44 +0200 [thread overview]
Message-ID: <2082863.3YbMk6PUyX@thomas> (raw)
In-Reply-To: <20200525040212.3f5b262a@sovereign>
25/05/2020 03:02, Dmitry Kozlyuk:
> On Sat, 23 May 2020 00:25:56 -0700
> Tasnim Bashar <tbashar@mellanox.com> wrote:
>
> > Casting thread ID to handle is not accurate way to get thread handle.
> > Need to use OpenThread function to get thread handle from thread ID.
> >
> > pthread_setaffinity_np and pthread_getaffinity_np functions
> > for Windows are affected because of it.
> >
> > Signed-off-by: Tasnim Bashar <tbashar@mellanox.com>
> > ---
>
> Please use --in-reply-to=Message-ID-of-previous-version to send v2, etc.
I should update the doc to ask replying to the first patch.
> If you're using Outlook, you can find message ID as follows:
>
> https://support.office.com/en-us/article/view-internet-message-headers-in-outlook-cd039382-dc6e-4264-ac74-c048563d212c
You can also find the message ID in patchwork or inbox.dpdk.org.
> For example, this is how this patch should have been sent:
>
> git send-email --in-reply-to=20200522001112.48932-1-tbashar@mellanox.com ...
prev parent reply other threads:[~2020-05-25 6:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200522001112>
2020-05-23 7:25 ` Tasnim Bashar
2020-05-25 1:02 ` Dmitry Kozlyuk
2020-05-25 6:59 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2082863.3YbMk6PUyX@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=fady@mellanox.com \
--cc=harini.ramakrishnan@microsoft.com \
--cc=navasile@linux.microsoft.com \
--cc=ocardona@microsoft.com \
--cc=ophirmu@mellanox.com \
--cc=pallavi.kadam@intel.com \
--cc=ranjit.menon@intel.com \
--cc=talshn@mellanox.com \
--cc=tbashar@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).