From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 040B01B2B3 for ; Fri, 5 Apr 2019 01:27:38 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6C7A122B1A; Thu, 4 Apr 2019 19:27:38 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 04 Apr 2019 19:27:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=9K/k8dQ1MFCXeHEsvw9Glc470tf35/JQLAYCzkMZO0U=; b=QOLoo+IopNMm 67nJ15lnVKJZ9xma9L+9xVtNOjZnsTjKobku11g0feOO0I+LqNCSf8lFeTCfVeYW xz8bg6YDUbxGd42XjQsmqS/Zouu6y/9SwNXeQTyfW3eUGzh4izll/C7cxl1QcGqw R+gDPCz7aqsy5dB+TPzJ/GpZoLsLe0Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=9K/k8dQ1MFCXeHEsvw9Glc470tf35/JQLAYCzkMZO 0U=; b=osRvoVS+guphXvIXiMjdyoqh0bEa39IdV/5YsXE3B1SUE3ajgVtN/c89s riFKLBC+2JehIPHjJt+5pluyNL/v3IoN3pZm329X/daVEQvIptbg2Sj4M22+pUM8 JxwJ+3YXM+y4687dY6bY7qS3We+q/6P/aLPvJ4gus0yW1fJRsZLxglS5C+F01u5t TfSc1/bi6+uNWnzwSMRqhIv0A62NYptSCB+eAQMhPpUN/DperSTMsRIMs8/ivP46 0l5hVb/eOYSSapSsRp4b7heobS+biHLQNZPDAXgpAW2oD9P/etQqZm3l9PmDH382 lpmJvm0MRklAH7I5V0/IMab6wy2Tw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtdeigddvtdculddtuddrgedutddrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvden ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhep mhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsth gvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B51B5E40D0; Thu, 4 Apr 2019 19:27:36 -0400 (EDT) From: Thomas Monjalon To: ferruh.yigit@intel.com Cc: dev@dpdk.org, Jie Pan Date: Fri, 05 Apr 2019 01:27:35 +0200 Message-ID: <2083070.Rv04mBFgE6@xps> In-Reply-To: <1548301983-20020-1-git-send-email-panjie5@jd.com> References: <1548301983-20020-1-git-send-email-panjie5@jd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] lib/librte_kni: fix the type for mac address X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Apr 2019 23:27:39 -0000 24/01/2019 04:53, Jie Pan: > The type for mac address in struct rte_kni_conf should be unsigned. > > Signed-off-by: Jie Pan > --- > lib/librte_kni/rte_kni.h | 2 +- > - char mac_addr[ETHER_ADDR_LEN]; /* MAC address assigned to KNI */ > + uint8_t mac_addr[ETHER_ADDR_LEN]; /* MAC address assigned to KNI */ Ferruh, it seems this patch is lacking a review. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id C0FD2A0679 for ; Fri, 5 Apr 2019 01:27:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 67D1B1B399; Fri, 5 Apr 2019 01:27:40 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 040B01B2B3 for ; Fri, 5 Apr 2019 01:27:38 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6C7A122B1A; Thu, 4 Apr 2019 19:27:38 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 04 Apr 2019 19:27:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=9K/k8dQ1MFCXeHEsvw9Glc470tf35/JQLAYCzkMZO0U=; b=QOLoo+IopNMm 67nJ15lnVKJZ9xma9L+9xVtNOjZnsTjKobku11g0feOO0I+LqNCSf8lFeTCfVeYW xz8bg6YDUbxGd42XjQsmqS/Zouu6y/9SwNXeQTyfW3eUGzh4izll/C7cxl1QcGqw R+gDPCz7aqsy5dB+TPzJ/GpZoLsLe0Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=9K/k8dQ1MFCXeHEsvw9Glc470tf35/JQLAYCzkMZO 0U=; b=osRvoVS+guphXvIXiMjdyoqh0bEa39IdV/5YsXE3B1SUE3ajgVtN/c89s riFKLBC+2JehIPHjJt+5pluyNL/v3IoN3pZm329X/daVEQvIptbg2Sj4M22+pUM8 JxwJ+3YXM+y4687dY6bY7qS3We+q/6P/aLPvJ4gus0yW1fJRsZLxglS5C+F01u5t TfSc1/bi6+uNWnzwSMRqhIv0A62NYptSCB+eAQMhPpUN/DperSTMsRIMs8/ivP46 0l5hVb/eOYSSapSsRp4b7heobS+biHLQNZPDAXgpAW2oD9P/etQqZm3l9PmDH382 lpmJvm0MRklAH7I5V0/IMab6wy2Tw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtdeigddvtdculddtuddrgedutddrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvden ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhep mhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsth gvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B51B5E40D0; Thu, 4 Apr 2019 19:27:36 -0400 (EDT) From: Thomas Monjalon To: ferruh.yigit@intel.com Cc: dev@dpdk.org, Jie Pan Date: Fri, 05 Apr 2019 01:27:35 +0200 Message-ID: <2083070.Rv04mBFgE6@xps> In-Reply-To: <1548301983-20020-1-git-send-email-panjie5@jd.com> References: <1548301983-20020-1-git-send-email-panjie5@jd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] lib/librte_kni: fix the type for mac address X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190404232735.763QxORZT-zDURBZQYh7J3ZLmfmkc7ZZO_o5d6j9aYs@z> 24/01/2019 04:53, Jie Pan: > The type for mac address in struct rte_kni_conf should be unsigned. > > Signed-off-by: Jie Pan > --- > lib/librte_kni/rte_kni.h | 2 +- > - char mac_addr[ETHER_ADDR_LEN]; /* MAC address assigned to KNI */ > + uint8_t mac_addr[ETHER_ADDR_LEN]; /* MAC address assigned to KNI */ Ferruh, it seems this patch is lacking a review.