From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 72C4643ACA; Fri, 9 Feb 2024 18:02:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2556242E6F; Fri, 9 Feb 2024 18:02:35 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 12D4E42E64 for ; Fri, 9 Feb 2024 18:02:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707498153; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nlPBCnoe8SWGQ14fQOTWDSCtA8I8RuCU0pHZDa3/vks=; b=dC8HvnCXgfJH0osn42UgtstW3lhuLjbbgfPIlTYb7bZkstM4h72Lq+dJEIV1wRQqwIOSRE MGmJJvw7VsbNrP4qUu62Wf9dSEbYE+7l8uZoq5Kl77RGnUSqLc2S00xQIIP6nTRZiUtbou H+p5GtK/jAST4leYH7tZlpte/Fol7ms= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-620-WaPooyyqNmqRicDYrWkxSA-1; Fri, 09 Feb 2024 12:02:31 -0500 X-MC-Unique: WaPooyyqNmqRicDYrWkxSA-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-68086d6c953so21145826d6.2 for ; Fri, 09 Feb 2024 09:02:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707498150; x=1708102950; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=nlPBCnoe8SWGQ14fQOTWDSCtA8I8RuCU0pHZDa3/vks=; b=RTHwrcJ04vXVT7ojdhpIIhZMyc8cM0sEov8hnxRUcHej2LiPmk+X7uBNyrMUBQJ7fY hc/B4cRNa6LZWIWCaiHb49qqrBv+ShaUHGbUuoiAFu3EqLpEPjHWEg1yggA1ueyhz2lr X6zyUh4x4Ir4W6zsR3FF/umwjc5SLuWJt2kAU/SkqI7J/9Kaw+W/lpXJ20iRZ5/2k7Qu DkkNg9Kcbyuq03R8hJnbdHAWT18Wr0U/tACik/jZDCnJECjzEMcBRcKPNtCYXqocECQF o6DXbfDjL2Vod8HYUlV8+RHFmzNJ45yWPWXnZMAnYdNLs9QrZ/0xc4wMnPODChn2w/2e JvFg== X-Gm-Message-State: AOJu0Yx6ovgC5CcqJsy5TJ5RHArwffwFtr3QN7PVkL6wTFsg9AxPzoBI UxLq1yEqIsI+YkbHCMAjoMrhYNYhg3SMhEwpa4BNthfZ4qurQmQK0YVBRGpoS7a4JNU9IvyPGej 1qnLSe4zo05rYSxIeknTxdd+4RSKYA7qbNEA8c7G0 X-Received: by 2002:a05:6214:3005:b0:68c:890e:3f3a with SMTP id ke5-20020a056214300500b0068c890e3f3amr2662578qvb.35.1707498150553; Fri, 09 Feb 2024 09:02:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IExd/DL29OZneUC+uAGhM1t3Bqxqjpj3WXfJVIJMmJVXV1lzNDtyBlSfs+e89B6DltKTT3TZQ== X-Received: by 2002:a05:6214:3005:b0:68c:890e:3f3a with SMTP id ke5-20020a056214300500b0068c890e3f3amr2662538qvb.35.1707498150208; Fri, 09 Feb 2024 09:02:30 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUNEJazR/gU1MIVbTbWNB+wpUVoTAd8q/LFfue8S4h1U8Br/SgIVwGd3qbkW7ctEIAYwK2JlIABxiC1zxgmI1iMDS7eY/PfbILb+MY1IwoYaEaAqP1C37chXdIsDJWFaMQMNPS+9mLRINlUnK+cM7CiVl+NOUKwOMtdc1umC/BFrQINBVEKM1Re6+GmMQsPS43F15xwkQOHi5V6hUGg5Z1s67S7mtoLDZgf+yy8d8A3/HrCnjAHZfd7dibss4pRhF0yR3+qp1CEcraGJSOEage90y8JIIuxvFz3Ks9RH+tw+J+XAt6lD3gm+YL0TtsCJ7103RDgIk+jrnqryKU7fpnH2Y3/+BePNbtM0WEB Received: from [192.168.0.12] ([78.18.30.42]) by smtp.gmail.com with ESMTPSA id of8-20020a056214434800b0068cb36973bdsm1009875qvb.0.2024.02.09.09.02.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Feb 2024 09:02:29 -0800 (PST) Message-ID: <2084393b-23c8-4e8d-8dc7-d584e7fac71a@redhat.com> Date: Fri, 9 Feb 2024 17:02:27 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [v7 1/1] net/af_xdp: fix multi interface support for K8s To: Ferruh Yigit , stephen@networkplumber.org, lihuisong@huawei.com, fengchengwen@huawei.com, liuyonglong@huawei.com, david.marchand@redhat.com Cc: dev@dpdk.org, Ciara Loftus , Shibin Koikkara Reeny , Kevin Traynor , Luca Boccassi References: <20231222110441.2507650-1-mtahhan@redhat.com> <6cd6ab2d-56ab-4afe-b0cd-05ab6b017469@amd.com> <89fd40d1-cc91-4390-9bc6-c60f24129ebb@redhat.com> <8a667d69-8543-4dd0-bc90-9929b670a261@amd.com> <37ebae5b-cfb0-48f9-bafb-855e59b6bdc9@amd.com> From: Maryam Tahhan In-Reply-To: <37ebae5b-cfb0-48f9-bafb-855e59b6bdc9@amd.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="------------d8WISlXTYZ6n1yh77010yQUw" Content-Language: en-US X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This is a multi-part message in MIME format. --------------d8WISlXTYZ6n1yh77010yQUw Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 07/02/2024 23:24, Ferruh Yigit wrote: > Hi Maryam, > > How do you want to continue with the patch, I think options we considered: > > 1. Fix 'use_cni' documentation (which we can backport to LTS) and > overload the argument for new purpose. This will enable new feature by > keeping backward compatibility. And requires new version of this patch. > > 2. If the 'use_cni' is completely broken in the 23.11 LTS, which means > there is no user or backward compatibility to worry about, we can merge > this patch and backport it to LTS. > > 3. Don't backport this fix to LTS, merge only to current release, which > means your new feature won't be available to some users as long as a few > years. > > > (1.) is most user friendly, but if 'use_cni' already broken in LTS we > can go with option (2.). What do you think? > Hi Ferruh Approach 1 is what I was aiming for. I will respin the patchset shortly (just trying to break things down into logical changes - taking LTS support into account). BR Marym > > btw, @Ciara, @Maryam, if (2.) is true, how we end up having a feature > ('use_cni' dev_args) completely broken in an LTS release? --------------d8WISlXTYZ6n1yh77010yQUw Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit
On 07/02/2024 23:24, Ferruh Yigit wrote:
Hi Maryam,

How do you want to continue with the patch, I think options we considered:

1. Fix 'use_cni' documentation (which we can backport to LTS) and
overload the argument for new purpose. This will enable new feature by
keeping backward compatibility. And requires new version of this patch.

2. If the 'use_cni' is completely broken in the 23.11 LTS, which means
there is no user or backward compatibility to worry about, we can merge
this patch and backport it to LTS.

3. Don't backport this fix to LTS, merge only to current release, which
means your new feature won't be available to some users as long as a few
years.


(1.) is most user friendly, but if 'use_cni' already broken in LTS we
can go with option (2.). What do you think?

Hi Ferruh


Approach 1 is what I was aiming for. I will respin the patchset shortly (just trying to break things down into logical changes - taking LTS support into account).


BR
Marym



btw, @Ciara, @Maryam, if (2.) is true, how we end up having a feature
('use_cni' dev_args) completely broken in an LTS release?



--------------d8WISlXTYZ6n1yh77010yQUw--