From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id ED54B1B05 for ; Sat, 27 Oct 2018 04:33:15 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 83D7021EF6; Fri, 26 Oct 2018 22:33:15 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 26 Oct 2018 22:33:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=1qyU7mLfq+c3OoUxTwYo+ojU+u77sfwmUfruy2pAypc=; b=Jb972B4khcpn 9xd/7opJj/xnHMxRNQaWwxpwudksFRkp4l5vd3iZ5IISbicNqOYZ9wDt3HXq1CLS TM9T9W/lP8b7NtC+aXBIfMfff39H+TvVo3r5nc5e4WQwVwcWXchTHGC09TI+BPCo vxCa0qd7oMBuhX+KAXl139ITRDsiZ/s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=1qyU7mLfq+c3OoUxTwYo+ojU+u77sfwmUfruy2pAy pc=; b=wRp0KxFdnKHIkdrxwSKMrEr1SoNcSE0eZEZjOBBMKs64vnXzzxKTIn0yj l4ia2Tj3QTOD/AJ+w4TtS+idp2sNd/LPr6mxzHmIJLfkQMuTOIKq0DAXmymzA+p0 UsgPsHskpRtO0GX43HqGM063hxG3x8PIMXBI/4wNxsNDA0rmU4VS7+ylwzTCQPXi hLXBqv8d8KtKEZXlrj0fZbuAqm4F4DQvlLJDa7elE77GBOhoyfEViUu6QazJtGdZ UiIMcK40W60fpqeUxF9yFxgLMVMM1Cd8ghGhoT5rVT3Nu4Uuy8Cm3Ea8tgLwDRDn I61ev50yPxvgdTiysBaVCrTAv38pg== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 95D62E4074; Fri, 26 Oct 2018 22:33:13 -0400 (EDT) From: Thomas Monjalon To: "Van Haaren, Harry" Cc: "Richardson, Bruce" , "dev@dpdk.org" , "stephen@networkplumber.org" , "gaetan.rivet@6wind.com" , "shreyansh.jain@nxp.com" , "mattias.ronnblom@ericsson.com" , "Laatz, Kevin" , "Nicolau, Radu" , "Hunt, David" Date: Sat, 27 Oct 2018 04:33:19 +0200 Message-ID: <2084760.x53lBy41Uf@xps> In-Reply-To: References: <20181024160311.85457-1-kevin.laatz@intel.com> <3436860.VK1RJtmnne@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v9 03/12] telemetry: initial telemetry infrastructure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Oct 2018 02:33:16 -0000 27/10/2018 04:19, Van Haaren, Harry: > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > 27/10/2018 01:59, Harry van Haaren: > > > --- a/mk/rte.vars.mk > > > +++ b/mk/rte.vars.mk > > > +JANSSON := $(shell pkg-config --exists jansson; echo $$?) > > > +ifneq ($(JANSSON),0) > > > +$(warning Jansson not found, disabling RTE_LIBRTE_TELEMETRY) > > > +CONFIG_RTE_LIBRTE_TELEMETRY = n > > > +endif > > > > It fails for cross-compilation. > > Example: > > When compiling i686 on x86_64 host, no error with > > pkg-config --exists jansson > > but fails when linking: > > /usr/bin/ld: skipping incompatible /usr/lib/gcc/x86_64-pc-linux- > > gnu/8.2.1/../../../libjansson.so when searching for -ljansson > > /usr/bin/ld: skipping incompatible /usr/lib/gcc/x86_64-pc-linux- > > gnu/8.2.1/../../../libjansson.a when searching for -ljansson > > /usr/bin/ld: skipping incompatible /usr/lib/libjansson.so when searching > > for -ljansson > > /usr/bin/ld: skipping incompatible /usr/lib/libjansson.a when searching > > for -ljansson > > /usr/bin/ld: cannot find -ljansson > > > > Note: there is the same issue with examples/vm_power_manager/Makefile > > > > I start thinking it is not reasonnable to enable an optional dependency > > in our Makefiles. Perhaps the only solution is to use meson... > > Ouch, yes if x86_64 pkg-config finds the available library, and it is not available in its i686 form, or other combinations thereof, things become another-level of complex. On ArchLinux, I have pkg-config-32 for i686 libs. And for true cross-compilation with sysroot, some environment variables are required. See this doc: https://autotools.io/pkgconfig/cross-compiling.html > Indeed Meson is (good | getting better) at detecting these things, Bruce knows more IIRC :) > > @Thomas, for this release I propose to rework to use CONFIG=N as default for Make, and allow packagers to enable if they wish. Is that a good next-step? Yes it looks reasonnable disabling telemetry by default in make case.