From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6DD5CA04DD; Fri, 23 Oct 2020 19:24:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4F8963772; Fri, 23 Oct 2020 19:24:17 +0200 (CEST) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id B88E02C2A for ; Fri, 23 Oct 2020 19:24:15 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 39B4E580128; Fri, 23 Oct 2020 13:24:12 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 23 Oct 2020 13:24:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= XKHnNEhyBm5Gz1B+XRf3L8086K27ekVV5/kebpeSImw=; b=QNUhCmNvwM+hyPcG F11TgXljb0PTEm8+XhajzNMBiDOYPhZmITPB7F49QeZyT273nakTfaaLHFVOzhAy 1uoEXv1VDKxtaauNn5Ujtgtv44+7wlB5H7qIs/DJR+GJkh+skV2CWGDILd9n/3kg Pi0QdhGZNTPaxTgJ29LwmMWn2+iTsW/AXL8tY7nEZbxJC5v8HwPP4NfNNiXcWYK7 wCookDM4xWonQ2KCMa/nhXPY9ae1QkPeD7mvginxB9+BnyHgVNPSENxT270KvJKz qwMOkLi8aAFxsyMDzTZkWsS76d3XDhf15xoHTn+EyE3QMANLkPceNokvS7QSb7Ov 6KUcWw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=XKHnNEhyBm5Gz1B+XRf3L8086K27ekVV5/kebpeSI mw=; b=gqlA/GRdmezPbuDMervJtwaU9LmEebnR+hyfBmbDA0r8ATAN9JBmQQWXP orfagUsCw1APD0Kmm94CC4ZHCu/Mj1+m0p6z5mN4RwS52EzHPCg67fmPiUWkK424 1O96+pXuxTBm1LNV6liFnLqVIiuUxX+DvAnosBACHSpUy884+sDUYqlNaZGmUr2O K45U3qTCgeI/BoFnY3N86/pp//vpMqQZ3LzVnxOYAeDSVw/JkDbYC/SkPmOofqY7 RtvRm9vNBEwVRDAztn5BVobQuJmCejFowL7LuiOFx2axJ3CWJHFTZ4bO8GOIuXea SjZF+YBdDklJIGGYSEfq1VsQaPveg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrkedtgdduudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepffdvffejueetleefieeludduuefgteejleevfeekjeefieegheet ffdvkeefgedunecuffhomhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrd dvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4CC3D3280059; Fri, 23 Oct 2020 13:24:09 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: dev@dpdk.org, "Yigit, Ferruh" , Bruce Richardson , "Burakov, Anatoly" , Olivier Matz , Ciara Power , Akhil Goyal , "Trahe, Fiona" , John Griffin , Deepak Kumar Jain Date: Fri, 23 Oct 2020 19:24:07 +0200 Message-ID: <2086275.x25LNfssgf@thomas> In-Reply-To: References: <20201022220525.1532249-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 0/5] cleanup comments and logs about config options X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 23/10/2020 09:37, David Marchand: > On Fri, Oct 23, 2020 at 12:05 AM Thomas Monjalon wrote: > > > > Below patches are cleaning traces of CONFIG_RTE_ after make removal, > > except one occurence in app/test/test_cryptodev.c (left as exercise). > > PS: In reality I don't know what must be done for this case about QAT. > > It seems a reintroduction with raw datapath API merge. > > I would apply the same as Ciara previous: > https://git.dpdk.org/dpdk/diff/app/test/test_cryptodev.c?id=c2c92c5d88522bb7f149de8ea6305691d1c65505 > > I.e. > @@ -14022,9 +14022,7 @@ test_cryptodev_qat_raw_api(void /*argv > __rte_unused, int argc __rte_unused*/) > RTE_STR(CRYPTODEV_NAME_QAT_SYM_PMD)); > > if (gbl_driver_id == -1) { > - RTE_LOG(ERR, USER1, "QAT PMD must be loaded. Check that both " > - "CONFIG_RTE_LIBRTE_PMD_QAT and CONFIG_RTE_LIBRTE_PMD_QAT_SYM " > - "are enabled in config file to run this testsuite.\n"); > + RTE_LOG(ERR, USER1, "QAT PMD must be loaded.\n"); > return TEST_SKIPPED; > } Yes it seems the right thing to do. > The rest of the series looks good to me. > Acked-by: David Marchand Applied with above change