From: Thomas Monjalon <thomas@monjalon.net>
To: Andrew Rybchenko <arybchenko@solarflare.com>,
Matan Azrad <matan@mellanox.com>
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>,
Tiwei Bie <tiwei.bie@intel.com>,
Zhihong Wang <zhihong.wang@intel.com>,
Xiao Wang <xiao.w.wang@intel.com>,
dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 2/3] doc: add vDPA feature table
Date: Fri, 10 Jan 2020 19:26:26 +0100 [thread overview]
Message-ID: <2086499.3ZeAukHxDK@xps> (raw)
In-Reply-To: <1578567617-3541-3-git-send-email-matan@mellanox.com>
09/01/2020 12:00, Matan Azrad:
> +This section explains the supported features that are listed in the table below.
> +
> + * csum - Device can handle packets with partial checksum.
> + * guest csum - Guest can handle packets with partial checksum.
> + * mac - Device has given MAC address.
> + * gso - Device can handle packets with any GSO type.
> + * guest tso4 - Guest can receive TSOv4.
> + * guest tso6 - Guest can receive TSOv6.
> + * ecn - Device can receive TSO with ECN.
> + * ufo - Device can receive UFO.
> + * host tso4 - Device can receive TSOv4.
> + * host tso6 - Device can receive TSOv6.
> + * mrg rxbuf - Guest can merge receive buffers.
> + * ctrl vq - Control channel is available.
> + * ctrl rx - Control channel RX mode support.
> + * any layout - Device can handle any descriptor layout.
> + * guest announce - Guest can send gratuitous packets.
> + * mq - Device supports Receive Flow Steering.
> + * version 1 - v1.0 compliant.
> + * log all - Device can log all write descriptors (live migration).
> + * indirect desc - Indirect buffer descriptors support.
> + * event idx - Support for avail_idx and used_idx fields.
> + * mtu - Host can advise the guest with its maximum supported MTU.
> + * in_order - Device can use descriptors in ring order.
> + * IOMMU platform - Device support IOMMU addresses.
> + * packed - Device support packed virtio queues.
> + * proto mq - Support the number of queues query.
> + * proto log shmfd - Guest support setting log base.
> + * proto rarp - Host can broadcast a fake RARP after live migration.
> + * proto reply ack - Host support requested operation status ack.
> + * proto host notifier - Host can register memory region based host notifiers.
> + * proto pagefault - Slave expose page-fault FD for migration process.
> + * BSD nic_uio - BSD ``nic_uio`` module supported.
> + * Linux VFIO - Works with ``vfio-pci`` kernel module.
> + * Other kdrv - Kernel module other than above ones supported.
> + * ARMv7 - Support armv7 architecture.
> + * ARMv8 - Support armv8a (64bit) architecture.
> + * Power8 - Support PowerPC architecture.
> + * x86-32 - Support 32bits x86 architecture.
> + * x86-64 - Support 64bits x86 architecture.
> + * Usage doc - Documentation describes usage, In ``doc/guides/vdpadevs/``.
> + * Design doc - Documentation describes design. In ``doc/guides/vdpadevs/``.
> + * Perf doc - Documentation describes performance values, In ``doc/perf/``.
It may be appropriate to use the RST syntax for definitions:
https://docutils.sourceforge.io/docs/user/rst/quickref.html#definition-lists
Andrew proposed to describe each feature with the same properties as for ethdev:
http://code.dpdk.org/dpdk/latest/source/doc/guides/nics/features.rst
You replied that it would be redundant for each feature.
In order to be more specific, the ethdev feature properties are:
- [uses] = input fields and constants
- [implements] = dev_ops functions
- [provides] = output fields
- [related] = API function
The API is very simple:
http://code.dpdk.org/dpdk/latest/source/lib/librte_vhost/rte_vdpa.h
The relevant dev_ops are written in the below note.
> +.. note::
> +
> + Most of the features capabilities should be provided by the drivers via the
> + next vDPA operations: ``get_features`` and ``get_protocol_features``.
I don't see what else can be filled in [uses], [implements] and [provides]
in the case of vDPA, so I suggest to keep it simple as it is.
next prev parent reply other threads:[~2020-01-10 18:26 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-25 15:19 [dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA device drivers Matan Azrad
2019-12-25 15:19 ` [dpdk-dev] [PATCH v1 1/3] drivers: introduce vDPA class Matan Azrad
2020-01-07 17:32 ` Maxime Coquelin
2020-01-08 21:28 ` Thomas Monjalon
2020-01-09 8:00 ` Maxime Coquelin
2019-12-25 15:19 ` [dpdk-dev] [PATCH v1 2/3] doc: add vDPA feature table Matan Azrad
2020-01-07 17:39 ` Maxime Coquelin
2020-01-08 5:28 ` Tiwei Bie
2020-01-08 7:20 ` Andrew Rybchenko
2020-01-08 10:42 ` Matan Azrad
2020-01-08 13:11 ` Andrew Rybchenko
2020-01-08 17:01 ` Matan Azrad
2020-01-09 2:15 ` Tiwei Bie
2020-01-09 8:08 ` Matan Azrad
2019-12-25 15:19 ` [dpdk-dev] [PATCH v1 3/3] drivers: move ifc driver to the vDPA class Matan Azrad
2020-01-07 18:17 ` Maxime Coquelin
2020-01-07 7:57 ` [dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA device drivers Matan Azrad
2020-01-08 5:44 ` Xu, Rosen
2020-01-08 10:45 ` Matan Azrad
2020-01-08 12:39 ` Xu, Rosen
2020-01-08 12:58 ` Thomas Monjalon
2020-01-09 2:27 ` Xu, Rosen
2020-01-09 8:41 ` Thomas Monjalon
2020-01-09 9:23 ` Maxime Coquelin
2020-01-09 9:49 ` Xu, Rosen
2020-01-09 10:42 ` Maxime Coquelin
2020-01-10 2:40 ` Xu, Rosen
2020-01-09 10:42 ` Maxime Coquelin
2020-01-09 10:53 ` Xu, Rosen
2020-01-09 11:34 ` Matan Azrad
2020-01-10 2:38 ` Xu, Rosen
2020-01-10 9:21 ` Thomas Monjalon
2020-01-10 14:18 ` Xu, Rosen
2020-01-10 16:27 ` Thomas Monjalon
2020-01-09 11:00 ` [dpdk-dev] [PATCH v2 " Matan Azrad
2020-01-09 11:00 ` [dpdk-dev] [PATCH v2 1/3] drivers: introduce vDPA class Matan Azrad
2020-01-09 11:00 ` [dpdk-dev] [PATCH v2 2/3] doc: add vDPA feature table Matan Azrad
2020-01-10 18:26 ` Thomas Monjalon [this message]
2020-01-13 22:40 ` Thomas Monjalon
2020-01-09 11:00 ` [dpdk-dev] [PATCH v2 3/3] drivers: move ifc driver to the vDPA class Matan Azrad
2020-01-09 17:25 ` Matan Azrad
2020-01-10 1:55 ` Wang, Haiyue
2020-01-10 9:07 ` Matan Azrad
2020-01-10 9:13 ` Thomas Monjalon
2020-01-10 12:31 ` Wang, Haiyue
2020-01-10 12:34 ` Maxime Coquelin
2020-01-10 12:59 ` Thomas Monjalon
2020-01-10 19:17 ` Kevin Traynor
2020-01-13 22:57 ` Thomas Monjalon
2020-01-13 23:08 ` [dpdk-dev] [PATCH v2 0/3] Introduce new class for vDPA device drivers Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2086499.3ZeAukHxDK@xps \
--to=thomas@monjalon.net \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=matan@mellanox.com \
--cc=maxime.coquelin@redhat.com \
--cc=tiwei.bie@intel.com \
--cc=xiao.w.wang@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).