From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8D590A04F0; Thu, 19 Dec 2019 16:19:16 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D81D91BF7A; Thu, 19 Dec 2019 16:19:15 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 5E3171BF78 for ; Thu, 19 Dec 2019 16:19:14 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 8A5562262F; Thu, 19 Dec 2019 10:19:13 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 19 Dec 2019 10:19:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=GggQGB/2/BY6MmQclzPJYPxrg9l9GWbvnrWnRKIVN90=; b=nFJk9CtsWMMz +Q3UB5Wlm6XkWP5dfvIwvNRJfy+xfeAHjU1T5knCL3RDzScJVejAPukX+Gy60fnu zRr2PeC4TZaSwTfv9Xl9X3pkc+9ppTVfXalBi1ly248xQPDo2dEpAgiZx3v6dZam /a1nO3dE7BLfaBHJUftdtUINja0iSmw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=GggQGB/2/BY6MmQclzPJYPxrg9l9GWbvnrWnRKIVN 90=; b=sxUzRukk0nZ5LxdYIfFLNMMFu5/qQ+3t0ED41CHsle7rc5YbRlRq2+F3X Lw9pnWO2IVE63yqCHGXGH/vC5lS70DA/CZhS4BdP+SWvy5rg/JoXRlIphkc+VOxc ERtgIq/HVc+h72kVYgPH0HzBr6i4P9xthp5dndDQKBQvyyjmkNkXP7tHNJoAnLlp K49ymJigUAZOCfJhXRH+zchgqIA1Vh0OuPUITNjBKgm6V3grQMm5eVn+gxZSv3+z dcHnNBxdG/XJH7tRIzTbTfnWInpb5pztRKA9331p+KajsdJlMEiC3MJHNUESDgKB 4OdM3QaKeqc/iTW2koOb1KeOuYuEA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvdduuddgjeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 565903060A02; Thu, 19 Dec 2019 10:19:12 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, David Marchand , "Kinsella, Ray" , "Yigit, Ferruh" , Luca Boccassi Date: Thu, 19 Dec 2019 16:19:09 +0100 Message-ID: <2089261.vgsDHE6x9C@xps> In-Reply-To: References: <20191211102642.983579-1-bruce.richardson@intel.com> <20191212115826.2167871-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] build: fix soname info for 19.11 compatiblity X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 19/12/2019 13:42, David Marchand: > On Thu, Dec 12, 2019 at 12:59 PM Bruce Richardson > wrote: > > > > The soname for each stable ABI version should be just the ABI version major > > number without the minor number. Unfortunately both major and minor were > > used causing version 20.1 to be incompatible with 20.0. > > > > This patch fixes the issue by switching from 2-part to 3-part ABI version > > numbers so that we can keep 20.0 as soname and using the final digits to > > identify the 20.x releases which are ABI compatible. This requires changes > > to both make and meson builds to handle the three-digit version and shrink > > it to 2-digit for soname. > > > > The final fix needed in this patch is to adjust the library version number > > for the ethtool example library, which needs to be upped to 2-digits, as > > external libraries using the DPDK build system also use the logic in this > > file. > > > > Fixes: cba806e07d6f ("build: change ABI versioning to global") > > > > Signed-off-by: Thomas Monjalon > > Signed-off-by: Bruce Richardson Acked-by: Neil Horman Tested-by: Ray Kinsella Tested-by: Ferruh Yigit Tested-by: Kevin Laatz > Tested-by: David Marchand Applied, thanks