* [dpdk-dev] [PATCH] doc: add profile with vtune section to prog guide
@ 2020-12-02 17:48 eugeny.parshutin
2021-01-13 17:11 ` Bruce Richardson
0 siblings, 1 reply; 3+ messages in thread
From: eugeny.parshutin @ 2020-12-02 17:48 UTC (permalink / raw)
To: bruce.richardson, kevin.laatz; +Cc: dev, ilia.kurakin, ciara.power
From: Eugeny Parshutin <eugeny.parshutin@linux.intel.com>
Return back 'profiling with vtune' section to profiling programmers
guide with updated instruction on how to enable vtune profiling
with meson configuration option.
Signed-off-by: Eugeny Parshutin <eugeny.parshutin@linux.intel.com>
---
doc/guides/prog_guide/profile_app.rst | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/doc/guides/prog_guide/profile_app.rst b/doc/guides/prog_guide/profile_app.rst
index 709368198..c87ca5d9d 100644
--- a/doc/guides/prog_guide/profile_app.rst
+++ b/doc/guides/prog_guide/profile_app.rst
@@ -33,6 +33,20 @@ Refer to the
for details about application profiling.
+Profiling with VTune
+~~~~~~~~~~~~~~~~~~~~
+
+To allow VTune attaching to the DPDK application, reconfigure a DPDK build
+folder by passing ``-Dc_args='-DRTE_ETHDEV_PROFILE_WITH_VTUNE'=1`` meson option
+and recompile the DPDK:
+
+.. code-block:: console
+
+ meson build
+ meson configure build -Dc_args='-DRTE_ETHDEV_PROFILE_WITH_VTUNE'=1
+ ninja -C build
+
+
Profiling on ARM64
------------------
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: add profile with vtune section to prog guide
2020-12-02 17:48 [dpdk-dev] [PATCH] doc: add profile with vtune section to prog guide eugeny.parshutin
@ 2021-01-13 17:11 ` Bruce Richardson
2021-01-13 20:22 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2021-01-13 17:11 UTC (permalink / raw)
To: eugeny.parshutin; +Cc: kevin.laatz, dev, ilia.kurakin, ciara.power
On Wed, Dec 02, 2020 at 08:48:06PM +0300, eugeny.parshutin@linux.intel.com wrote:
> From: Eugeny Parshutin <eugeny.parshutin@linux.intel.com>
>
> Return back 'profiling with vtune' section to profiling programmers
> guide with updated instruction on how to enable vtune profiling
> with meson configuration option.
>
> Signed-off-by: Eugeny Parshutin <eugeny.parshutin@linux.intel.com>
> ---
> doc/guides/prog_guide/profile_app.rst | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/doc/guides/prog_guide/profile_app.rst b/doc/guides/prog_guide/profile_app.rst
> index 709368198..c87ca5d9d 100644
> --- a/doc/guides/prog_guide/profile_app.rst
> +++ b/doc/guides/prog_guide/profile_app.rst
> @@ -33,6 +33,20 @@ Refer to the
> for details about application profiling.
>
>
> +Profiling with VTune
> +~~~~~~~~~~~~~~~~~~~~
> +
> +To allow VTune attaching to the DPDK application, reconfigure a DPDK build
> +folder by passing ``-Dc_args='-DRTE_ETHDEV_PROFILE_WITH_VTUNE'=1`` meson option
> +and recompile the DPDK:
> +
> +.. code-block:: console
> +
> + meson build
> + meson configure build -Dc_args='-DRTE_ETHDEV_PROFILE_WITH_VTUNE'=1
> + ninja -C build
> +
Since the VTUNE parts seem to be protected by just "#ifdef" rather than a
check for a specific value, I think the "=1" can be omitted in the
instructions. That should also make the quoted unnecessary.
With that change to simplify things,
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: add profile with vtune section to prog guide
2021-01-13 17:11 ` Bruce Richardson
@ 2021-01-13 20:22 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2021-01-13 20:22 UTC (permalink / raw)
To: eugeny.parshutin
Cc: dev, kevin.laatz, ilia.kurakin, ciara.power, Bruce Richardson
13/01/2021 18:11, Bruce Richardson:
> On Wed, Dec 02, 2020 at 08:48:06PM +0300, eugeny.parshutin@linux.intel.com wrote:
> > From: Eugeny Parshutin <eugeny.parshutin@linux.intel.com>
> >
> > Return back 'profiling with vtune' section to profiling programmers
> > guide with updated instruction on how to enable vtune profiling
> > with meson configuration option.
> >
> > Signed-off-by: Eugeny Parshutin <eugeny.parshutin@linux.intel.com>
> > ---
> > +Profiling with VTune
> > +~~~~~~~~~~~~~~~~~~~~
> > +
> > +To allow VTune attaching to the DPDK application, reconfigure a DPDK build
> > +folder by passing ``-Dc_args='-DRTE_ETHDEV_PROFILE_WITH_VTUNE'=1`` meson option
> > +and recompile the DPDK:
> > +
> > +.. code-block:: console
> > +
> > + meson build
> > + meson configure build -Dc_args='-DRTE_ETHDEV_PROFILE_WITH_VTUNE'=1
> > + ninja -C build
> > +
> Since the VTUNE parts seem to be protected by just "#ifdef" rather than a
> check for a specific value, I think the "=1" can be omitted in the
> instructions. That should also make the quoted unnecessary.
>
> With that change to simplify things,
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Fixes: 89c67ae2cba7 ("doc: remove references to make from prog guide")
Cc: stable@dpdk.org
Applied with above changes, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-13 20:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-02 17:48 [dpdk-dev] [PATCH] doc: add profile with vtune section to prog guide eugeny.parshutin
2021-01-13 17:11 ` Bruce Richardson
2021-01-13 20:22 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).