From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9A304A0C47; Fri, 29 Oct 2021 18:15:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 64C9D4111F; Fri, 29 Oct 2021 18:15:29 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 8EFCF410E1; Fri, 29 Oct 2021 18:15:28 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 318135C01E7; Fri, 29 Oct 2021 12:15:27 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Fri, 29 Oct 2021 12:15:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= RdpDjnzGFqIN8n/BES6E5TOmCMIui95vFaA8WtLh2mo=; b=p4QoHoZXenc9umx8 N3/FrKKRWfXouyTlR8VeLAmH5dP7YQOEi8NTJ9+rZeT5LQNcaD7YmxiWCcCvmgpi lL1vYBAeF92Txijpb4DQtbRGcqPCdt/kZwY4P/pafmf3Z2wCv87DaybGGPOsRRC5 hf1GR1WSjTI7C+1QmieXysXoH+KDRYd4eJB4t3uAMepecxRtJ00N7BBgZxjmstDm ykNYTRw/a44A2rMK0ybR/6k5jXEo356ol8PGy4jh/vZCcSboqzr95NO75ptLqpmh YfodBAGCqBW+uUkA8XBIyAEeFMDaSkxNJxOPTcdqpF18ru3j8xdCgsNVXgaOKE1i tMgCLA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=RdpDjnzGFqIN8n/BES6E5TOmCMIui95vFaA8WtLh2 mo=; b=Oj5YfT7TBEd4GRyjVwSWdp5f3Xhj23CKxitwiJTDL6jrZ7m6URRKAIlFt X2ZGR7xFz2UTgA6PFDd6L2V/6tpizrKZH195mdZhbO915OG0TFB9pFsrkSEQ/GBF CiScw4Ucji69BXDrqK2AZPT2CxElAW9U7Sey9odz/d0ZX+5/QDkC941zpsEnAG2H HqmSjD+1aWKyXayaevEsmgUP8iY+DEtL/dUVXM7BS+VY8g2Leul1a0PhCwuvfW0x EVuCKwj7cqcxaLUvVwcjvw6671bF+Qo+iWV2BTFHm3mUVVvyCc1b4giQnpljgbsg rEki/F8SAfDhJRStqdvp9ey4TutQQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvdeghedgleegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 29 Oct 2021 12:15:25 -0400 (EDT) From: Thomas Monjalon To: Maxime Coquelin Cc: dev@dpdk.org, techboard@dpdk.org, chenbo.xia@intel.com, xuemingl@nvidia.com, xiao.w.wang@intel.com, david.marchand@redhat.com Date: Fri, 29 Oct 2021 18:15:23 +0200 Message-ID: <2090872.1hmkV2J3kl@thomas> In-Reply-To: <20211028141531.58861-1-maxime.coquelin@redhat.com> References: <20211028141531.58861-1-maxime.coquelin@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-techboard] [PATCH v2] vhost: mark vDPA driver API as internal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 28/10/2021 16:15, Maxime Coquelin: > This patch marks the vDPA driver APIs as internal and > rename the corresponding header file to vdpa_driver.h. > > Signed-off-by: Maxime Coquelin > --- > > Hi Techboard, > > Please vote for an exception for this unannounced API > breakage. [...] > lib/vhost/{rte_vdpa_dev.h => vdpa_driver.h} | 12 +++++++++--- Hiding more internal structs is a good breakage. [...] > --- a/lib/vhost/rte_vdpa_dev.h > +++ b/lib/vhost/vdpa_driver.h > +__rte_internal > struct rte_vdpa_device * > rte_vdpa_register_device(struct rte_device *rte_dev, > struct rte_vdpa_dev_ops *ops); [...] > +__rte_internal > int > rte_vdpa_unregister_device(struct rte_vdpa_device *dev); [...] > +__rte_internal > int > rte_vhost_host_notifier_ctrl(int vid, uint16_t qid, bool enable); [...] > +__rte_internal > int > rte_vdpa_relay_vring_used(int vid, uint16_t qid, void *vring_m); [...] > --- a/lib/vhost/version.map > +++ b/lib/vhost/version.map > - rte_vdpa_register_device; > - rte_vdpa_relay_vring_used; > - rte_vdpa_unregister_device; > - rte_vhost_host_notifier_ctrl; OK to remove these functions from the ABI and mark them internal. I suppose this breakage should not hurt too much, as I don't see the need for out-of-tree vDPA drivers. Of course it is always better to announce such change, but it would be a pity to wait one more year for hiding this. Acked-by: Thomas Monjalon