From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EAFE443382; Wed, 22 Nov 2023 17:37:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D740041109; Wed, 22 Nov 2023 17:37:51 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 8D4F640265; Wed, 22 Nov 2023 17:37:50 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 326265C0251; Wed, 22 Nov 2023 11:37:50 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 22 Nov 2023 11:37:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1700671070; x=1700757470; bh=AombmLQC1Fn4RCaGTohuqBe6gvOw0W2Ia5I TJbAYRUc=; b=mOKtkcFNuJi6xWyzLVKHBe1QmdVEeBUZsrcdE2MyML/kAp1295r BOcAZ5Tx2Ws6JZ1j56eR+CYu/bWabcqJzDj/OB7oSFquvJVCq+1EQ32qdT5uTQRL AsNBQ1sVICdlNKda3dbluYHvQkaK9+y8szGHYGYs0wQjZfBGCQEM+aZVaviHT+99 xYy6KeBWrHMrn4n2oBaH0KHLHlk1GJ2LuNm+hXrW+iETB6dCdTKKCmAy4v9kWfRO TrZy026EsrWyIvju/7e5wmnj5Y1QfeRGXFVEVGdJR6UkQ0y/UqIGpp6CQgOk6vpa lA70MsO8bu4Do1f14HDGLmj/qs2K/4dOCtQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1700671070; x=1700757470; bh=AombmLQC1Fn4RCaGTohuqBe6gvOw0W2Ia5I TJbAYRUc=; b=O5zxOBwzYMd7FuggQZjYSBNGsR73PXURsKlZdvh14pJWReRkRPn fX13Mr90sw5qP3HOdeU6kXutq5AKekn8CeSsHVsSvmGoCsZLri23bjOMgiRJt33t WL1RBy/kaGr/568N0pgwZ44c3rx3BpomAv2fOuF8UUyIeLx5NAPe9VkOd9iAMfr2 smus/KzQPDXmFzI6lvTT0RkYua3FT82uIm47DVc1NgPA/FeJsng3S1X1jac4lxF/ K5xyUWb7TilYp3GTDfUToIMhfURMYRXwMyy2XYFPz06nNwAVd1sBNbHrEdr5q8wI Ymfx6Z5csChkpABVQDcaLQZWSqWogaaFHMg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudehuddgkeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 22 Nov 2023 11:37:48 -0500 (EST) From: Thomas Monjalon To: "Dooley, Brian" Cc: "dev@dpdk.org" , stable@dpdk.org, "Nicolau, Radu" , Akhil Goyal , "Power, Ciara" Subject: Re: [PATCH] examples/ipsec-secgw: fix partial overflow Date: Wed, 22 Nov 2023 17:37:47 +0100 Message-ID: <2090975.KlZ2vcFHjT@thomas> In-Reply-To: References: <20231115123101.2377544-1-brian.dooley@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > Case of partial overflow detected with ASan. Added extra padding to cdev_key > > structure. > > > > This structure is used for the key in hash table. > > Padding is added to force the struct to use 8 bytes, to ensure memory is > > notread past this structs boundary (the hash key calculation reads 8 bytes if > > this struct is size 5 bytes). > > The padding should be zeroed. > > If fields are modified in this struct, the padding must be updated to ensure > > multiple of 8 bytes size overall. > > > > Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application") > > Cc: sergio.gonzalez.monroy@intel.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Brian Dooley > > Acked-by: Ciara Power Applied and made the comment simpler with this: uint8_t padding[3]; /* padding to 8-byte size should be zeroed */