DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Reshma Pattan <reshma.pattan@intel.com>,
	Volodymyr Fialko <vfialko@marvell.com>
Cc: dev@dpdk.org, jerinj@marvell.com, anoobj@marvell.com
Subject: Re: [PATCH] reorder: introduce API to obtain memory footprint
Date: Thu, 01 Jun 2023 17:07:18 +0200	[thread overview]
Message-ID: <2091348.VsPgYW4pTa@thomas> (raw)
In-Reply-To: <20230414085251.272062-1-vfialko@marvell.com>

Hello,

2 comments below

14/04/2023 10:52, Volodymyr Fialko:
> At present, it is not easy to determine the memory requirement for the
> reorder buffer without delving into its implementation details.
> To facilitate the use of reorder buffer with user allocation, a new API
> `rte_reorder_memory_footprint_get()` is introduced.
> This API will provide the amount of required memory for reorder buffer.
> 
> Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
[...]
> +__rte_experimental
> +unsigned int
> +rte_reorder_memory_footprint_get(unsigned int size);

It should be of type size_t.
But I see other functions in this lib use the wrong type (unsigned int).

Like previous patches for the reorder library from Volodymyr,
the official maintainer (Reshma) is not reviewing.
Does it mean Reshma is not interested anymore in this maintenance?

Applied, thanks.



  reply	other threads:[~2023-06-01 15:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-14  8:52 Volodymyr Fialko
2023-06-01 15:07 ` Thomas Monjalon [this message]
2023-06-02 11:06   ` Pattan, Reshma
2023-06-02 11:30     ` Volodymyr Fialko
2023-06-02 11:33       ` Thomas Monjalon
2023-06-06  7:15         ` Pattan, Reshma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2091348.VsPgYW4pTa@thomas \
    --to=thomas@monjalon.net \
    --cc=anoobj@marvell.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=reshma.pattan@intel.com \
    --cc=vfialko@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).