From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1115542C04; Thu, 1 Jun 2023 17:07:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F25C040F18; Thu, 1 Jun 2023 17:07:22 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id E39E940DDC for ; Thu, 1 Jun 2023 17:07:21 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 7A2625C0212; Thu, 1 Jun 2023 11:07:21 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 01 Jun 2023 11:07:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1685632041; x=1685718441; bh=CI2lyHnySOPrAxDxcMcMrtLXDDVqYhnqUEm 7jYo+HNE=; b=J8fiqosPefLk4mYXxfKgdAFH39+NSOLMHMhQiYfB8cYBRYZMyHH ckmiYPxbdnyJyqCAJVPOanh+F1W4rPfB3bisTXFYWzDH5WeulbyQhw+yNxcRp0bb 91PEwZKIxbswOLxewkpjKIj1ACbVSYh2n441nxqJX6m+C31R1FVyjJ49Jab6vvJz 2bT/xSIeso/O9wdM7tUAb92FEMfYvrrzvzCRsQMSGHRvq7uxy+8YwZS1ZAaDEtjh kUDxCrYZuwqCb8VGp7N6zyuxzwdnpAsM8ktJ3KBv61OBelNRRTCRLk3dZyfSx+9J +2r9evbpgTYlchfeokHKtDx3pqSX8dhlOkw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1685632041; x=1685718441; bh=CI2lyHnySOPrAxDxcMcMrtLXDDVqYhnqUEm 7jYo+HNE=; b=c3DOmRVePj6eaoJ6tKP0jPwnz7ohD5XHy0/C8OLxXfPeT9TBEh4 wr6ZZbQUubVX1xUhV2OOpKWT/xHfetftzkqOp9Vjn97JMNBiUXoykXuVJ448iz1m GlUabLPvFw7YXLKZqxBWtnyu3R1ML96w/3/QVu9J48o3dcgdiTEq6Qu5H/Etg1oj TeeaRdjW6//6KxOH1IUv5lXffSR4Uw1zJk1+tseEQRBbP1IscK+xPT1T1imwGLLa 2PjYe3H0om4Yg1WsPQjCkYS5mvk47Kmv5+hkwfcX6yWryFeYJ/E11XKUaDwfjzSD uUfIhia0Aw3H0t0xpvoc5O2ZLNTIqLm1yXA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeeluddgkeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 1 Jun 2023 11:07:19 -0400 (EDT) From: Thomas Monjalon To: Reshma Pattan , Volodymyr Fialko Cc: dev@dpdk.org, jerinj@marvell.com, anoobj@marvell.com Subject: Re: [PATCH] reorder: introduce API to obtain memory footprint Date: Thu, 01 Jun 2023 17:07:18 +0200 Message-ID: <2091348.VsPgYW4pTa@thomas> In-Reply-To: <20230414085251.272062-1-vfialko@marvell.com> References: <20230414085251.272062-1-vfialko@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello, 2 comments below 14/04/2023 10:52, Volodymyr Fialko: > At present, it is not easy to determine the memory requirement for the > reorder buffer without delving into its implementation details. > To facilitate the use of reorder buffer with user allocation, a new API > `rte_reorder_memory_footprint_get()` is introduced. > This API will provide the amount of required memory for reorder buffer. > > Signed-off-by: Volodymyr Fialko [...] > +__rte_experimental > +unsigned int > +rte_reorder_memory_footprint_get(unsigned int size); It should be of type size_t. But I see other functions in this lib use the wrong type (unsigned int). Like previous patches for the reorder library from Volodymyr, the official maintainer (Reshma) is not reviewing. Does it mean Reshma is not interested anymore in this maintenance? Applied, thanks.