From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1BCCA00B8; Mon, 28 Oct 2019 09:38:52 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C28A81BEF9; Mon, 28 Oct 2019 09:38:51 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by dpdk.org (Postfix) with ESMTP id A26541BEF6 for ; Mon, 28 Oct 2019 09:38:49 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 255CE457; Mon, 28 Oct 2019 04:38:48 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 28 Oct 2019 04:38:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=8zfDwHki4batNKB7ZoBEp5pBmdY9WUK8+DeD8RWPV2Y=; b=q5+HjrFLtkxL SpBmJZM82F2t/r21ftAGPfEJjZUgSJJiwIdeBtrhq/U9JmGQ7F1YOsB66BV/nhwe 9b3rsN3kljIwXgzo/L4Gb56CBscmAH+ratxo8Hlr1lDufwXUSixTgU8+98dTVoeE QUELPTmqt95FAgYS83IIejV7LDAWO4Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=8zfDwHki4batNKB7ZoBEp5pBmdY9WUK8+DeD8RWPV 2Y=; b=E+fpRdGKczGB87g+oCQwC4N0NDd9IoduNdgUX5B+YC1ZWNgFXZKK9ZvPe WxFwreYA5BVXLtDBCUpXFGQG1C2HlRXO8zp+pTmL3K4oJXwKoIfi16lNi075wwB3 KDOIpeAkxpfCJyazTIs4IZJWfqHK53Uj39Bjv0J81RXnQwTF2X0lexiimDwkZPok 6Vr6Bv1rv7B9iK8SDclm3+1F6Wih+fMeE1zchP4HxuXhsUHF+2mKkMRPtz27pqR7 FHNcynoMDJ/EUcX0f+QItzIhGZWwhG1HoBMznI83TGXksM54FG4rWCrTR/MQQCIB +KYhVdQPsm/X5mHfhwWOSNwKR26wA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrleekgdduvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpehflhgrghdrqddqqdgrphhppdguphgukhdrohhrghenucfkphepjeejrddu feegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmh honhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 483FCD6005A; Mon, 28 Oct 2019 04:38:46 -0400 (EDT) From: Thomas Monjalon To: "Xu, Ting" Cc: "dev@dpdk.org" , "Lu, Wenzhuo" , "Wu, Jingjing" , "Iremonger, Bernard" , "olivier.matz@6wind.com" , "Yigit, Ferruh" Date: Mon, 28 Oct 2019 09:38:44 +0100 Message-ID: <2091577.580EmC4nEW@xps> In-Reply-To: <8C448DD570D7CD459EACDF44AB3869D7019324BD@SHSMSX106.ccr.corp.intel.com> References: <20191022122910.53743-1-ting.xu@intel.com> <1890292.h76DOOWmZ3@xps> <8C448DD570D7CD459EACDF44AB3869D7019324BD@SHSMSX106.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6] app/testpmd: enable GTP header parse and Tx checksum offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 28/10/2019 02:35, Xu, Ting: > Hi, Thomas, > > Sorry for my mistake about missing meson.build. I have fixed it as well as others based on your comments. > However, I am not quite understand your last reply. Do I still need to send a new patch now or not? No, this is already merged: http://git.dpdk.org/dpdk/commit/?id=d8e5e69f3a > Thanks for your patient help! > > Best Regards, > Ting Xu > > -----Original Message----- > From: Thomas Monjalon > Sent: Saturday, October 26, 2019 6:49 AM > To: Xu, Ting > Cc: dev@dpdk.org; Lu, Wenzhuo ; Wu, Jingjing ; Iremonger, Bernard ; olivier.matz@6wind.com; Yigit, Ferruh > Subject: Re: [dpdk-dev] [PATCH v6] app/testpmd: enable GTP header parse and Tx checksum offload > > 22/10/2019 18:26, Ting Xu: > > This patch enables testpmd to forward GTP packet in csum fwd mode. > > A GTP header structure (without optional fields and extension header) > > is defined in new rte_gtp.h. A parser function in testpmd is added. > > GTPU and GTPC packets are both supported, with respective UDP > > destination port and GTP message type. > > > > Signed-off-by: Ting Xu > > > > --- > > v6: complete doxygen documentation. > > v5: create rte_gtp.h and move GTP header definition to it. > > v4: move GTP header definition to rte_ether.h > > v3: correct coding style issue. > > v2: modify commit log > > > > depend on patch: lib/mbuf: add GTP tunnel type flag. > > --- > > app/test-pmd/csumonly.c | 97 +++++++++++++++++++++++++++++++++++---- > > doc/api/doxy-api-index.md | 1 + > > lib/librte_net/Makefile | 2 +- > > You missed meson.build in addition of Makefile. > > > lib/librte_net/rte_gtp.h | 52 +++++++++++++++++++++ > > 4 files changed, 141 insertions(+), 11 deletions(-) create mode > > 100644 lib/librte_net/rte_gtp.h > > Does it deserve 2 separate patches? GTP header + testpmd use > > [...] > > --- /dev/null > > +++ b/lib/librte_net/rte_gtp.h > [...] > > + > > +#endif /* RTE_GTP_H_ */ > > + > > Please remove this blank line at EOF. Such things are cleaned up sometimes: > http://git.dpdk.org/dpdk/commit/?id=6f3f0acd95