From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 4FF8EA0524;
Tue, 25 Feb 2020 10:47:08 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id A610A1BFCD;
Tue, 25 Feb 2020 10:46:59 +0100 (CET)
Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com
[64.147.123.20]) by dpdk.org (Postfix) with ESMTP id ED6321BFC7
for <dev@dpdk.org>; Tue, 25 Feb 2020 10:46:57 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.west.internal (Postfix) with ESMTP id A6D937DA;
Tue, 25 Feb 2020 04:46:56 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
by compute1.internal (MEProxy); Tue, 25 Feb 2020 04:46:57 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=mesmtp;
bh=CCi+TRNs4t0DUph8K84vn7/Ryhu66ywld3dQLR5Fo5Q=; b=mCqatmt6QOxz
fvuOoxLdnncpFBWSJyYw45CcZwO50N6k/z48UK6dorRQx/fq1rEZe0dPdJGBC9mr
yUonXMVhpj/av1BwiW6PDHEhSadaq//PqSMk7uhsTK8FlBvJRIGPz7AjqN5E+lWk
pcrAhoVvl+Jq5POWd9JaVzn7RndWgI8=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm2; bh=CCi+TRNs4t0DUph8K84vn7/Ryhu66ywld3dQLR5Fo
5Q=; b=yQZw/JqKlNUVzyeTHOF9ldYn68/uT6PmAM1hvXjNc/P+1BwtROw02rht3
tENdLd/lZEe5RTELeTZyxxvS33PCUdITLnte6k3CBB4kPCXHALwQyuIMw13Wqa7i
KbNNMQmoX/QnoEd5lDfTQGZT4lxEVsmIqNdL2pjqqEBjOQlYCtcZwX3svhoigMgg
8BJfcW16IF6/uhmQySUKIma8emvJS6EQUsa9AoReTTUJKrGK0SLO58f8MhUrq0Hs
/2oWb0eQrgnXzWGu/Vw8INsf0NYn/RdAJ0G6SNJRQJ6Y+54a3Ym0evLYmF2naJ3B
76EklejBY8WDQZQ30PnpQbR4uuH7g==
X-ME-Sender: <xms:D-1UXnkbdrHCfKKVmmbW_ogyD3iwVNfdoechuxYLpMC4IHqwIWKaXw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrledvgddtjecutefuodetggdotefrodftvf
curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs
ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph
epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr
rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth
X-ME-Proxy: <xmx:D-1UXimrVshs4Niz4Zd-cJyiFlqq1wx599wSr9wj2Xx7LgEcSKoOyw>
<xmx:D-1UXiomjdkvDG5mPPotG0qcXBuSPYR0a3VU7hOCjhcJgdKM-e_VPw>
<xmx:D-1UXnm27w342qZnvphbRYMmYbMh2-glKlsxwKu4a18huHN6EZuSwA>
<xmx:EO1UXs63Mkr-UWr_DlQzs__a8xIJY1SxaNbHQAzUDgXHtfK-0nv0GA>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 10EDA328005E;
Tue, 25 Feb 2020 04:46:54 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Matan Azrad <matan@mellanox.com>
Cc: dev@dpdk.org, Viacheslav Ovsiienko <viacheslavo@mellanox.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>
Date: Tue, 25 Feb 2020 10:46:53 +0100
Message-ID: <2091728.HovnAMPojK@xps>
In-Reply-To: <1582620228-25629-1-git-send-email-matan@mellanox.com>
References: <1582620228-25629-1-git-send-email-matan@mellanox.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] vdpa/mlx5: fix event setup
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
25/02/2020 09:43, Matan Azrad:
> The completion event mechanism should work only if at least one of the
> virtqs has valid callfd to be notified on.
>
> When all the virtqs works with poll mode, the event mechanism should not
> be configured.
>
> The driver didn't take it into account and crashed in the above case.
>
> Do not configure event interrupt when all the virtqs are in poll mode.
>
> Fixes: 8395927cdfaf ("vdpa/mlx5: prepare HW queues")
>
> Signed-off-by: Matan Azrad <matan@mellanox.com>
Applied, thanks
Note: there is no regression risk because it is fixing a new driver.