* [PATCH 2/2] build: fix warning when running external command
2023-05-29 5:57 [PATCH 1/2] config/arm: update config for Neoverse N2 Ruifeng Wang
@ 2023-05-29 5:57 ` Ruifeng Wang
2023-05-29 8:12 ` Bruce Richardson
2023-05-29 7:41 ` [PATCH 1/2] config/arm: update config for Neoverse N2 Juraj Linkeš
` (2 subsequent siblings)
3 siblings, 1 reply; 9+ messages in thread
From: Ruifeng Wang @ 2023-05-29 5:57 UTC (permalink / raw)
To: bruce.richardson
Cc: dev, jerinj, honnappa.nagarahalli, feifei.wang2, nd,
Ruifeng Wang, stable
Meson gives warnings on calls to run_command when there is
a missing "check" parameter. Most of the occurrences has been fixed.
Fixed the remaining one in this change.
Fixes: ecb904cc4596 ("build: fix warnings when running external commands")
Cc: bruce.richardson@intel.com
Cc: stable@dpdk.org
Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
config/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/config/meson.build b/config/meson.build
index fa730a1b14..65087ce090 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -366,7 +366,7 @@ if max_numa_nodes == 'detect'
error('Discovery of max_numa_nodes not supported for cross-compilation.')
endif
# overwrite the default value with discovered values
- max_numa_nodes = run_command(get_numa_count_cmd).stdout().to_int()
+ max_numa_nodes = run_command(get_numa_count_cmd, check: true).stdout().to_int()
message('Found @0@ numa nodes'.format(max_numa_nodes))
dpdk_conf.set('RTE_MAX_NUMA_NODES', max_numa_nodes)
elif max_numa_nodes != 'default'
--
2.25.1
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 2/2] build: fix warning when running external command
2023-05-29 5:57 ` [PATCH 2/2] build: fix warning when running external command Ruifeng Wang
@ 2023-05-29 8:12 ` Bruce Richardson
0 siblings, 0 replies; 9+ messages in thread
From: Bruce Richardson @ 2023-05-29 8:12 UTC (permalink / raw)
To: Ruifeng Wang; +Cc: dev, jerinj, honnappa.nagarahalli, feifei.wang2, nd, stable
On Mon, May 29, 2023 at 01:57:51PM +0800, Ruifeng Wang wrote:
> Meson gives warnings on calls to run_command when there is
> a missing "check" parameter. Most of the occurrences has been fixed.
> Fixed the remaining one in this change.
>
> Fixes: ecb904cc4596 ("build: fix warnings when running external commands")
> Cc: bruce.richardson@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] config/arm: update config for Neoverse N2
2023-05-29 5:57 [PATCH 1/2] config/arm: update config for Neoverse N2 Ruifeng Wang
2023-05-29 5:57 ` [PATCH 2/2] build: fix warning when running external command Ruifeng Wang
@ 2023-05-29 7:41 ` Juraj Linkeš
2023-06-06 13:51 ` Thomas Monjalon
2023-06-07 15:11 ` [EXT] " Pavan Nikhilesh Bhagavatula
3 siblings, 0 replies; 9+ messages in thread
From: Juraj Linkeš @ 2023-05-29 7:41 UTC (permalink / raw)
To: Ruifeng Wang
Cc: bruce.richardson, dev, jerinj, honnappa.nagarahalli, feifei.wang2, nd
[-- Attachment #1: Type: text/plain, Size: 1179 bytes --]
Acked-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
On Mon, May 29, 2023 at 7:58 AM Ruifeng Wang <ruifeng.wang@arm.com> wrote:
> Updated maximum number of lcores and numa nodes to support platforms
> with multiple numa nodes.
> Added mcpu compiler option.
>
> Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
> Reviewed-by: Feifei Wang <feifei.wang2@arm.com>
> ---
> config/arm/meson.build | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index 5213434ca4..9e55e9f2a4 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -91,11 +91,12 @@ part_number_config_arm = {
> '0xd49': {
> 'march': 'armv8.5-a',
> 'march_features': ['sve2'],
> + 'compiler_options': ['-mcpu=neoverse-n2'],
> 'flags': [
> ['RTE_MACHINE', '"neoverse-n2"'],
> ['RTE_ARM_FEATURE_ATOMICS', true],
> - ['RTE_MAX_LCORE', 64],
> - ['RTE_MAX_NUMA_NODES', 1]
> + ['RTE_MAX_LCORE', 128],
> + ['RTE_MAX_NUMA_NODES', 2]
> ]
> }
> }
> --
> 2.25.1
>
>
[-- Attachment #2: Type: text/html, Size: 1881 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 1/2] config/arm: update config for Neoverse N2
2023-05-29 5:57 [PATCH 1/2] config/arm: update config for Neoverse N2 Ruifeng Wang
2023-05-29 5:57 ` [PATCH 2/2] build: fix warning when running external command Ruifeng Wang
2023-05-29 7:41 ` [PATCH 1/2] config/arm: update config for Neoverse N2 Juraj Linkeš
@ 2023-06-06 13:51 ` Thomas Monjalon
2023-06-07 15:11 ` [EXT] " Pavan Nikhilesh Bhagavatula
3 siblings, 0 replies; 9+ messages in thread
From: Thomas Monjalon @ 2023-06-06 13:51 UTC (permalink / raw)
To: Ruifeng Wang
Cc: bruce.richardson, dev, jerinj, honnappa.nagarahalli, feifei.wang2, nd
29/05/2023 07:57, Ruifeng Wang:
> Updated maximum number of lcores and numa nodes to support platforms
> with multiple numa nodes.
> Added mcpu compiler option.
>
> Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
> Reviewed-by: Feifei Wang <feifei.wang2@arm.com>
Series applied, thanks.
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [EXT] [PATCH 1/2] config/arm: update config for Neoverse N2
2023-05-29 5:57 [PATCH 1/2] config/arm: update config for Neoverse N2 Ruifeng Wang
` (2 preceding siblings ...)
2023-06-06 13:51 ` Thomas Monjalon
@ 2023-06-07 15:11 ` Pavan Nikhilesh Bhagavatula
2023-06-08 4:29 ` Ruifeng Wang
3 siblings, 1 reply; 9+ messages in thread
From: Pavan Nikhilesh Bhagavatula @ 2023-06-07 15:11 UTC (permalink / raw)
To: Ruifeng Wang, bruce.richardson
Cc: dev, Jerin Jacob Kollanukkaran, honnappa.nagarahalli, feifei.wang2, nd
> Updated maximum number of lcores and numa nodes to support platforms
> with multiple numa nodes.
> Added mcpu compiler option.
>
> Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
> Reviewed-by: Feifei Wang <feifei.wang2@arm.com>
> ---
> config/arm/meson.build | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index 5213434ca4..9e55e9f2a4 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -91,11 +91,12 @@ part_number_config_arm = {
> '0xd49': {
> 'march': 'armv8.5-a',
> 'march_features': ['sve2'],
> + 'compiler_options': ['-mcpu=neoverse-n2'],
Hi Ruifeng,
I see the following warning when compiling with GCC 12
cc1: warning: switch '-mcpu=neoverse-n2' conflicts with '-march=armv8.5-a+sve2+crypto' switch
Removing 'armv8.5-a' from the list makes the warning go away but what's the correct march for neoverse-n2?
Armv9.0-a is not a supported march flag in GCC.
> 'flags': [
> ['RTE_MACHINE', '"neoverse-n2"'],
> ['RTE_ARM_FEATURE_ATOMICS', true],
> - ['RTE_MAX_LCORE', 64],
> - ['RTE_MAX_NUMA_NODES', 1]
> + ['RTE_MAX_LCORE', 128],
> + ['RTE_MAX_NUMA_NODES', 2]
> ]
> }
> }
> --
> 2.25.1
^ permalink raw reply [flat|nested] 9+ messages in thread* RE: [EXT] [PATCH 1/2] config/arm: update config for Neoverse N2
2023-06-07 15:11 ` [EXT] " Pavan Nikhilesh Bhagavatula
@ 2023-06-08 4:29 ` Ruifeng Wang
2023-06-08 4:34 ` Pavan Nikhilesh Bhagavatula
0 siblings, 1 reply; 9+ messages in thread
From: Ruifeng Wang @ 2023-06-08 4:29 UTC (permalink / raw)
To: Pavan Nikhilesh Bhagavatula, bruce.richardson
Cc: dev, jerinj, Honnappa Nagarahalli, Feifei Wang, nd, nd
> -----Original Message-----
> From: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
> Sent: Wednesday, June 7, 2023 11:12 PM
> To: Ruifeng Wang <Ruifeng.Wang@arm.com>; bruce.richardson@intel.com
> Cc: dev@dpdk.org; jerinj@marvell.com; Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>;
> Feifei Wang <Feifei.Wang2@arm.com>; nd <nd@arm.com>
> Subject: RE: [EXT] [PATCH 1/2] config/arm: update config for Neoverse N2
>
> > Updated maximum number of lcores and numa nodes to support platforms
> > with multiple numa nodes.
> > Added mcpu compiler option.
> >
> > Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
> > Reviewed-by: Feifei Wang <feifei.wang2@arm.com>
> > ---
> > config/arm/meson.build | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/config/arm/meson.build b/config/arm/meson.build index
> > 5213434ca4..9e55e9f2a4 100644
> > --- a/config/arm/meson.build
> > +++ b/config/arm/meson.build
> > @@ -91,11 +91,12 @@ part_number_config_arm = {
> > '0xd49': {
> > 'march': 'armv8.5-a',
> > 'march_features': ['sve2'],
> > + 'compiler_options': ['-mcpu=neoverse-n2'],
>
> Hi Ruifeng,
Hi Pavan,
> I see the following warning when compiling with GCC 12
>
> cc1: warning: switch '-mcpu=neoverse-n2' conflicts with '-march=armv8.5-a+sve2+crypto'
> switch
>
> Removing 'armv8.5-a' from the list makes the warning go away but what's the correct march
> for neoverse-n2?
> Armv9.0-a is not a supported march flag in GCC.
Thanks for pointing this out.
Neoverse-n2 is v9.0-a. The corresponding march flag in GCC is 'armv9-a' [1].
'armv8.5-a' should be removed from the list. It was used when armv9-a/neoverse-n2 is not available in compilers.
[1] https://gcc.gnu.org/onlinedocs/gcc-12.3.0/gcc/AArch64-Options.html
>
> > 'flags': [
> > ['RTE_MACHINE', '"neoverse-n2"'],
> > ['RTE_ARM_FEATURE_ATOMICS', true],
> > - ['RTE_MAX_LCORE', 64],
> > - ['RTE_MAX_NUMA_NODES', 1]
> > + ['RTE_MAX_LCORE', 128],
> > + ['RTE_MAX_NUMA_NODES', 2]
> > ]
> > }
> > }
> > --
> > 2.25.1
^ permalink raw reply [flat|nested] 9+ messages in thread* RE: [EXT] [PATCH 1/2] config/arm: update config for Neoverse N2
2023-06-08 4:29 ` Ruifeng Wang
@ 2023-06-08 4:34 ` Pavan Nikhilesh Bhagavatula
2023-06-08 5:25 ` Ruifeng Wang
0 siblings, 1 reply; 9+ messages in thread
From: Pavan Nikhilesh Bhagavatula @ 2023-06-08 4:34 UTC (permalink / raw)
To: Ruifeng Wang, bruce.richardson
Cc: dev, Jerin Jacob Kollanukkaran, Honnappa Nagarahalli,
Feifei Wang, nd, nd
> -----Original Message-----
> From: Ruifeng Wang <Ruifeng.Wang@arm.com>
> Sent: Thursday, June 8, 2023 9:59 AM
> To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>;
> bruce.richardson@intel.com
> Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran <jerinj@marvell.com>;
> Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>; Feifei Wang
> <Feifei.Wang2@arm.com>; nd <nd@arm.com>; nd <nd@arm.com>
> Subject: RE: [EXT] [PATCH 1/2] config/arm: update config for Neoverse N2
>
> > -----Original Message-----
> > From: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
> > Sent: Wednesday, June 7, 2023 11:12 PM
> > To: Ruifeng Wang <Ruifeng.Wang@arm.com>; bruce.richardson@intel.com
> > Cc: dev@dpdk.org; jerinj@marvell.com; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>;
> > Feifei Wang <Feifei.Wang2@arm.com>; nd <nd@arm.com>
> > Subject: RE: [EXT] [PATCH 1/2] config/arm: update config for Neoverse N2
> >
> > > Updated maximum number of lcores and numa nodes to support
> platforms
> > > with multiple numa nodes.
> > > Added mcpu compiler option.
> > >
> > > Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
> > > Reviewed-by: Feifei Wang <feifei.wang2@arm.com>
> > > ---
> > > config/arm/meson.build | 5 +++--
> > > 1 file changed, 3 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/config/arm/meson.build b/config/arm/meson.build index
> > > 5213434ca4..9e55e9f2a4 100644
> > > --- a/config/arm/meson.build
> > > +++ b/config/arm/meson.build
> > > @@ -91,11 +91,12 @@ part_number_config_arm = {
> > > '0xd49': {
> > > 'march': 'armv8.5-a',
> > > 'march_features': ['sve2'],
> > > + 'compiler_options': ['-mcpu=neoverse-n2'],
> >
> > Hi Ruifeng,
>
> Hi Pavan,
>
> > I see the following warning when compiling with GCC 12
> >
> > cc1: warning: switch '-mcpu=neoverse-n2' conflicts with '-march=armv8.5-
> a+sve2+crypto'
> > switch
> >
> > Removing 'armv8.5-a' from the list makes the warning go away but what's
> the correct march
> > for neoverse-n2?
> > Armv9.0-a is not a supported march flag in GCC.
>
> Thanks for pointing this out.
> Neoverse-n2 is v9.0-a. The corresponding march flag in GCC is 'armv9-a' [1].
> 'armv8.5-a' should be removed from the list. It was used when armv9-
> a/neoverse-n2 is not available in compilers.
I see, should I send a fix?
>
> [1] https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__gcc.gnu.org_onlinedocs_gcc-2D12.3.0_gcc_AArch64-
> 2DOptions.html&d=DwIFAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=E3SgYMjtKCM
> VsB-fmvgGV3o-
> g_fjLhk5Pupi9ijohpc&m=v0RqCjWj9zEynw7pgt6ghZX4BNI5Vnk0UxA4sYAxRr
> RtO8lLHUhKYCNTniy2Jb5L&s=tEj1y2WPKFeatDFYUFqX49tv-
> 2rG2wx0UiWklOYUvhY&e=
>
> >
> > > 'flags': [
> > > ['RTE_MACHINE', '"neoverse-n2"'],
> > > ['RTE_ARM_FEATURE_ATOMICS', true],
> > > - ['RTE_MAX_LCORE', 64],
> > > - ['RTE_MAX_NUMA_NODES', 1]
> > > + ['RTE_MAX_LCORE', 128],
> > > + ['RTE_MAX_NUMA_NODES', 2]
> > > ]
> > > }
> > > }
> > > --
> > > 2.25.1
^ permalink raw reply [flat|nested] 9+ messages in thread* RE: [EXT] [PATCH 1/2] config/arm: update config for Neoverse N2
2023-06-08 4:34 ` Pavan Nikhilesh Bhagavatula
@ 2023-06-08 5:25 ` Ruifeng Wang
0 siblings, 0 replies; 9+ messages in thread
From: Ruifeng Wang @ 2023-06-08 5:25 UTC (permalink / raw)
To: Pavan Nikhilesh Bhagavatula, bruce.richardson
Cc: dev, jerinj, Honnappa Nagarahalli, Feifei Wang, nd, nd, nd
> -----Original Message-----
> From: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
> Sent: Thursday, June 8, 2023 12:35 PM
> To: Ruifeng Wang <Ruifeng.Wang@arm.com>; bruce.richardson@intel.com
> Cc: dev@dpdk.org; jerinj@marvell.com; Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>;
> Feifei Wang <Feifei.Wang2@arm.com>; nd <nd@arm.com>; nd <nd@arm.com>
> Subject: RE: [EXT] [PATCH 1/2] config/arm: update config for Neoverse N2
>
>
>
> > -----Original Message-----
> > From: Ruifeng Wang <Ruifeng.Wang@arm.com>
> > Sent: Thursday, June 8, 2023 9:59 AM
> > To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>;
> > bruce.richardson@intel.com
> > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran <jerinj@marvell.com>;
> > Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>; Feifei Wang
> > <Feifei.Wang2@arm.com>; nd <nd@arm.com>; nd <nd@arm.com>
> > Subject: RE: [EXT] [PATCH 1/2] config/arm: update config for Neoverse
> > N2
> >
> > > -----Original Message-----
> > > From: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
> > > Sent: Wednesday, June 7, 2023 11:12 PM
> > > To: Ruifeng Wang <Ruifeng.Wang@arm.com>; bruce.richardson@intel.com
> > > Cc: dev@dpdk.org; jerinj@marvell.com; Honnappa Nagarahalli
> > <Honnappa.Nagarahalli@arm.com>;
> > > Feifei Wang <Feifei.Wang2@arm.com>; nd <nd@arm.com>
> > > Subject: RE: [EXT] [PATCH 1/2] config/arm: update config for
> > > Neoverse N2
> > >
> > > > Updated maximum number of lcores and numa nodes to support
> > platforms
> > > > with multiple numa nodes.
> > > > Added mcpu compiler option.
> > > >
> > > > Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
> > > > Reviewed-by: Feifei Wang <feifei.wang2@arm.com>
> > > > ---
> > > > config/arm/meson.build | 5 +++--
> > > > 1 file changed, 3 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/config/arm/meson.build b/config/arm/meson.build index
> > > > 5213434ca4..9e55e9f2a4 100644
> > > > --- a/config/arm/meson.build
> > > > +++ b/config/arm/meson.build
> > > > @@ -91,11 +91,12 @@ part_number_config_arm = {
> > > > '0xd49': {
> > > > 'march': 'armv8.5-a',
> > > > 'march_features': ['sve2'],
> > > > + 'compiler_options': ['-mcpu=neoverse-n2'],
> > >
> > > Hi Ruifeng,
> >
> > Hi Pavan,
> >
> > > I see the following warning when compiling with GCC 12
> > >
> > > cc1: warning: switch '-mcpu=neoverse-n2' conflicts with
> > > '-march=armv8.5-
> > a+sve2+crypto'
> > > switch
> > >
> > > Removing 'armv8.5-a' from the list makes the warning go away but
> > > what's
> > the correct march
> > > for neoverse-n2?
> > > Armv9.0-a is not a supported march flag in GCC.
> >
> > Thanks for pointing this out.
> > Neoverse-n2 is v9.0-a. The corresponding march flag in GCC is 'armv9-a' [1].
> > 'armv8.5-a' should be removed from the list. It was used when armv9-
> > a/neoverse-n2 is not available in compilers.
>
> I see, should I send a fix?
Sure. Please go ahead.
Thanks.
>
> >
> > [1] https://urldefense.proofpoint.com/v2/url?u=https-
> > 3A__gcc.gnu.org_onlinedocs_gcc-2D12.3.0_gcc_AArch64-
> > 2DOptions.html&d=DwIFAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=E3SgYMjtKCM
> > VsB-fmvgGV3o-
> > g_fjLhk5Pupi9ijohpc&m=v0RqCjWj9zEynw7pgt6ghZX4BNI5Vnk0UxA4sYAxRr
> > RtO8lLHUhKYCNTniy2Jb5L&s=tEj1y2WPKFeatDFYUFqX49tv-
> > 2rG2wx0UiWklOYUvhY&e=
> >
> > >
> > > > 'flags': [
> > > > ['RTE_MACHINE', '"neoverse-n2"'],
> > > > ['RTE_ARM_FEATURE_ATOMICS', true],
> > > > - ['RTE_MAX_LCORE', 64],
> > > > - ['RTE_MAX_NUMA_NODES', 1]
> > > > + ['RTE_MAX_LCORE', 128],
> > > > + ['RTE_MAX_NUMA_NODES', 2]
> > > > ]
> > > > }
> > > > }
> > > > --
> > > > 2.25.1
^ permalink raw reply [flat|nested] 9+ messages in thread