From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Wenzhuo Lu <wenzhuo.lu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] lib/librte_ether: bypass code cleanup
Date: Mon, 11 Jul 2016 09:11:15 +0200 [thread overview]
Message-ID: <2092181.9Q4Kasxdod@xps13> (raw)
In-Reply-To: <1468218079-8064-1-git-send-email-wenzhuo.lu@intel.com>
2016-07-11 14:21, Wenzhuo Lu:
> In testpmd code, device id is used directly to check if bypass
> is supported. But APP should not know the details of HW, the NIC
> specific info should not be exposed here.
Right
> This patch adds a new rte API to check if bypass is supported.
Hmmm. It's true it is cleaner. But I am not sure having a generic API
for bypass is a good idea at all.
I was thinking to totally remove it.
Maybe we can try to have a specific API by including ixgbe_bypass.h in
the application.
next prev parent reply other threads:[~2016-07-11 7:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 6:21 Wenzhuo Lu
2016-07-11 7:11 ` Thomas Monjalon [this message]
2016-07-11 8:09 ` Lu, Wenzhuo
2016-07-11 8:18 ` Ananyev, Konstantin
2016-07-11 9:19 ` Thomas Monjalon
2016-07-11 9:56 ` Ananyev, Konstantin
2016-07-11 10:19 ` [dpdk-dev] specific driver API - was " Thomas Monjalon
2016-07-11 10:39 ` Ananyev, Konstantin
2016-07-11 7:50 ` [dpdk-dev] [PATCH] lib/librte_ether: " Wu, Jingjing
2016-07-11 8:09 ` Lu, Wenzhuo
2016-07-11 8:29 ` [dpdk-dev] [PATCH v2] app/testpmd: " Wenzhuo Lu
2016-07-11 13:18 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2092181.9Q4Kasxdod@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).