From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-lf0-f54.google.com (mail-lf0-f54.google.com [209.85.215.54]) by dpdk.org (Postfix) with ESMTP id 0A1362B98 for <dev@dpdk.org>; Mon, 11 Jul 2016 09:11:19 +0200 (CEST) Received: by mail-lf0-f54.google.com with SMTP id f6so63387268lfg.0 for <dev@dpdk.org>; Mon, 11 Jul 2016 00:11:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=TkR3FnHe5VPmE9sONI1F8t/nqyLXKyD+QzpnvaMhuso=; b=jzs7oCZftJh8Af9nlgrBDF80bjX3us+QMNW/C5I5k4hHWwF91K7mP5J2DyJBK60nXX YFeF4TDZVs6/lGqVsyE3zJ5Vrw3sNhOxPXXu1/LpOc0USFl6624dM7SRaerq/1w+aWxD O07afpgSfUlbhw8P1Myujvb8mts6ZwzQtCofxlXuQvOLFo/jU9aT0C4Iz4hbrgDvAGCQ ka1yCi1s1U/RyE4V3CqmP/CNCelQeyeFu2EwLkrXVYZ4QwfjNrQSpjjM3O8SfUGG9tsY oyR5idh7NOWiFH80wNFvIOZG9Zx3i1kdtXYFI3pGx8D4Yv7Btc949BRLICNjQJcj2Ujk 4WQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=TkR3FnHe5VPmE9sONI1F8t/nqyLXKyD+QzpnvaMhuso=; b=Jfzo0eBlpLPXtGGg31+60uO5yTkXJjrhHKveFFxN9SHpSMioaGYN2mpktTqjYJbI9n B8QgtrwTEM/mSHqusMg65wGRpRl0DpnAaF/mdhL8pTaghcvKjyI2byFW87agaeZ+ihbZ dmq5OoHcxjPSkUt6FtK1cMJYaVnz2dfgpeckSpob5VqUEWzYUO7zOd0OEjdGTj2O3+K9 PrgqFr86nUU+5xUn5djStZYB9SQ+oU4G/FvD0XPcger3WkZq1i3fS8lHhUrK3AiXk08b 8hFVoCY+yTRj+Gg6wP6p7N9dvr3+bCEgVNaPW8Rxtmg/Vy1QSZiG1nEy/y5I+QoYaPEl puOA== X-Gm-Message-State: ALyK8tLEwQlXc17xhgj+mDLPMZ1DF6rEfLyGvxnBqF1o5+Ow/H1Sc3MGpZxdYyPS2dPExNGZ X-Received: by 10.25.43.202 with SMTP id r193mr4000494lfr.80.1468221078602; Mon, 11 Jul 2016 00:11:18 -0700 (PDT) Received: from xps13.localnet (230.202.154.77.rev.sfr.net. [77.154.202.230]) by smtp.gmail.com with ESMTPSA id u19sm10367270lja.12.2016.07.11.00.11.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Jul 2016 00:11:17 -0700 (PDT) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: Wenzhuo Lu <wenzhuo.lu@intel.com> Cc: dev@dpdk.org Date: Mon, 11 Jul 2016 09:11:15 +0200 Message-ID: <2092181.9Q4Kasxdod@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1468218079-8064-1-git-send-email-wenzhuo.lu@intel.com> References: <1468218079-8064-1-git-send-email-wenzhuo.lu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] lib/librte_ether: bypass code cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 11 Jul 2016 07:11:19 -0000 2016-07-11 14:21, Wenzhuo Lu: > In testpmd code, device id is used directly to check if bypass > is supported. But APP should not know the details of HW, the NIC > specific info should not be exposed here. Right > This patch adds a new rte API to check if bypass is supported. Hmmm. It's true it is cleaner. But I am not sure having a generic API for bypass is a good idea at all. I was thinking to totally remove it. Maybe we can try to have a specific API by including ixgbe_bypass.h in the application.