From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C4DF2A055A;
	Tue, 25 Feb 2020 18:47:37 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 74A6F1BF8D;
	Tue, 25 Feb 2020 18:47:36 +0100 (CET)
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id A3E7F1BC24;
 Tue, 25 Feb 2020 18:47:34 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 3DE112208C;
 Tue, 25 Feb 2020 12:47:34 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Tue, 25 Feb 2020 12:47:34 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=mesmtp;
 bh=4YBBHvAPfbaiOELNDcPxo1a8hoes5ZALpsnMpZ13BSs=; b=BD2J+rj5Odoq
 BN5YuS/BulKtQZEjIvz1zbGTbf8Neqqr1byMONoH13Y0kcMk0LIfD2vmM0Xrv33J
 KNf5S6k2Z2XfRzLIrgOaLLsqPwHcWvK5Lkmg9U2CQxvqtJAGsbSzME+pWH//5pjR
 p8CVaXXIGEVW94xnMpfamflL3ZvuiSk=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm2; bh=4YBBHvAPfbaiOELNDcPxo1a8hoes5ZALpsnMpZ13B
 Ss=; b=NWh11yNq5LpgzoBiBQGTZxf5ADQSHguPdTzTSMec/WelqbKIegSe+d7tW
 6qdIBMrFh4d61/7ZVKVLcu0FD5XiZuPwgj/ULddeMy8qZECC1Xbf1O/g/94R3d8T
 vsBEZS+bIjVYlgWeN9qN1Q7rT5f0pdt53bk5etAdqkZcJrcCqwAIoGQgXqQS1xI5
 svidi0y4rZ2m4jxX08Hx9rctIjdgMoeZ6qaBX2pzW4iV2kld/D2SyWrsg+/E96GY
 v4is6U2HqgU6wsJjf78WidlZ1zzHuKRi+JOheU9KzateMualrtjklq0LQe3HL2gz
 PYa/xpDtZmBARakeMoSxFDr6P9RhA==
X-ME-Sender: <xms:tV1VXiun05_8rjfi1R3EosEgWvhxI8LVwtymUWjw0swLu4jIu6HeRw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrledvgddutdegucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
 shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff
 homhgrihhnpehsohhurhgtvghfohhrghgvrdhiohenucfkphepjeejrddufeegrddvtdef
 rddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh
 epthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth
X-ME-Proxy: <xmx:tV1VXsoWc8uolvaORbS0r9jVLXQUwGXqx8bs80bEXEyz0amqoISJGQ>
 <xmx:tV1VXhK4HFTqYtCDxClrM06l7rlgwuRZ1FuGOkpw47pyFdY87zb3iA>
 <xmx:tV1VXsvKUIhOEMIThJJ0REQVdKTqXsirjBvQgfDOR5Wxv6pLVzbf9w>
 <xmx:tl1VXjplK9LEl5WDUaSrMhVgWiZTMH62OSbg3QufMyPLN53NXGnGmw>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 6F69A3060FE0;
 Tue, 25 Feb 2020 12:47:32 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: David Hunt <david.hunt@intel.com>, john.mcnamara@intel.com,
 marko.kovacevic@intel.com
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
 Bernard Iremonger <bernard.iremonger@intel.com>, dev@dpdk.org,
 David Marchand <david.marchand@redhat.com>,
 Bruce Richardson <bruce.richardson@intel.com>, techboard@dpdk.org
Date: Tue, 25 Feb 2020 18:47:31 +0100
Message-ID: <2094532.KTMopqUuYO@xps>
In-Reply-To: <2915716.TQGk6oTFT5@xps>
References: <20200107091343.22965-1-david.hunt@intel.com>
 <f5155aef-d8da-23f3-0b97-9d4bcc38d8e4@intel.com> <2915716.TQGk6oTFT5@xps>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2] doc: rework vm power manager user guide
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

25/02/2020 17:59, Thomas Monjalon:
> 25/02/2020 17:46, Ferruh Yigit:
> > On 2/17/2020 10:48 AM, David Hunt wrote:
> > > Review and re-work of vm_power_manager documentation. Hopefully this
> > > is clearer, easier to follow.
> > > 
> > > Signed-off-by: David Hunt <david.hunt@intel.com>
> > <...>
> > 
> > Bernard reported following errors [1] in DPDK 20.02-rc4 caused by this patch,
> > while building the docs in Ubuntu with "Sphinx (sphinx-build) 1.3.6".
> > 
> > I can't reproduce it with "sphinx-build 1.8.5" on Ubuntu, or with "sphinx-build
> > 2.3.1" on Fedora.
> > 
> > I am putting this as a record, not sure if something needs to be done.
> > 
> > @John, do we have a minimum required sphinx version required?
> > 
> > 
> > 
> > [1]
> > .../doc/guides/sample_app_ug/vm_power_management.rst:420: ERROR: Malformed table.
> > Column span alignment problem in table line 5.
> > 
> > .../doc/guides/sample_app_ug/vm_power_management.rst:545: ERROR: Malformed table.
> > Column span alignment problem in table line 5.
> > 
> > .../doc/guides/sample_app_ug/vm_power_management.rst:754: ERROR: Malformed table.
> > Column span alignment problem in table line 5.
> 
> 
> Thank you for reporting.
> I was testing PDF on the server at the same time and discovered this issue.
> 
> We should avoid big tables.
> Here the table have only two columns so they can be formatted differently.
> One option is to use the definition lists:
> 	https://docutils.sourceforge.io/docs/user/rst/quickref.html#definition-lists
> 
> Please could we have a fix very quickly?
> It is a blocker for the release (planned to be done in the next hour).

I did the fix myself.

I think we must talk about having a doc maintainer, really.