From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DE70A42490; Thu, 26 Jan 2023 11:57:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7D77940A79; Thu, 26 Jan 2023 11:57:51 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id 0BAC240697 for ; Thu, 26 Jan 2023 11:57:50 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 262E8320093E; Thu, 26 Jan 2023 05:57:47 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 26 Jan 2023 05:57:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1674730666; x= 1674817066; bh=/JEysvjYFhYqUmPbX+3LDgn/bxY5nTpSSyaxPwzjAkY=; b=V b/dp+pcezxAk9GfQ1Nh+/es3D9TFLXJjzvVw6EQh5GieUmm7FI5Aix5Px5EzCnLQ YztVTR8JRR4d9X0tODf6Fdy15WmeQ0F1JqMCgv/tvPWJybVQ34tdXdfIrD85POrr d35+qeIGcH6dpIkyXf9FIM6OllQQ66MzpLgvDvmy5mNf8bcJ/TDnOCCpa6diUxCC hU3fi512wzeGwPX/IoRjCuY8LAsnj2/DLJ0MOLWWHAohjacY+JRt7LD3N1jTA8Jx ew2zn//9Ii8WQ967chgUVVFPgSmmavyVIICsSgHGoJa+LMQUNLF4sl2mCuqYjbQa 6a5uXcLWfQFfhn2mQrVMQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1674730666; x= 1674817066; bh=/JEysvjYFhYqUmPbX+3LDgn/bxY5nTpSSyaxPwzjAkY=; b=o Gu1YNZVIJhauj8derasSDrCiEtPeqk3cFXUqKUGabHS0/oHAkHwxmKK/+U59N3L2 IWLyvZRNQ1lP/GVSI654K3643+yhpNZiew7hGMWj5cuMv7gN4SjVSbBNWXeJGDCe Fo9cLhx5IjUn1E0lmJPctwYITBKzPZKsnpZ2OkkOqdY53/rJDDrCJOD5XOnHQXNU z/WthFl+brOusk3ZbPAtyhBVASkZeqQwDi2Q1rRX5NNYRLExD7xS1HucDyiFQcet 5qFl4kQNchqxrNiPaPBV1m7iT/e9o4W9kIw7DYcxUfMavKWBl15FwL7CckF5Eklj x+hBoKVsyFI+ircUjBoxg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddvgedgvddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 26 Jan 2023 05:57:45 -0500 (EST) From: Thomas Monjalon To: Shivah Shankar Shankar Narayan Rao , Srikanth Yalavarthi Cc: "dev@dpdk.org" , Jerin Jacob Kollanukkaran , Anup Prabhu , "ferruh.yigit@amd.com" , "bruce.richardson@intel.com" , "david.marchand@redhat.com" , Srikanth Yalavarthi Subject: Re: [EXT] Re: [PATCH v3 0/4] implementation of ML common code Date: Thu, 26 Jan 2023 11:57:43 +0100 Message-ID: <2095842.dTVjPilprF@thomas> In-Reply-To: References: <20221212172108.17993-1-syalavarthi@marvell.com> <4307135.zXnORWrf4K@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 25/01/2023 15:59, Srikanth Yalavarthi: > From: Thomas Monjalon > > 25/01/2023 14:25, Srikanth Yalavarthi: > > > From: Thomas Monjalon > > > > 20/12/2022 18:52, Srikanth Yalavarthi: > > > > > This patch series implements the common ML code that can be used > > > > > by ML drivers. Common code include functions to convert ML IO type > > > > > to string, IO format type to string, function get size of ML IO > > > > > type, and functions for converting data types from higher > > > > > precision to lower precision and vice-versa. > > > > > > > > I'm not sure about the path of this code. > > > > In general we implement drivers helper in the same directory as the > > > > driver and mark it as internal. > > > > Would it work here? > > > > > > We are planning to implement two different ML drivers, ml/cnxk driver > > (submitted for review) and a software only driver (part of ML roadmap and > > currently WIP). Both the drivers would be using these common functions for > > quantization and dequantization. Hence, placed the files in common/ml > > directory. > > > > > > Moreover, these functions are used to convert data from higher to lower > > precision or vice-versa and can also be used by future ML drivers for other > > platforms. > > > > I understand, and what you say does not contradict with having this code in > > lib/mldev/. > > So would you agree to move? > > These common functions do not have an rte_ml_dev_ prefix. As it is exported, it should have rte_ prefix. > Is it ok to have non-RTE code in lib/mldev. If yes, we can move to lib/mldev. Look at lib/ethdev/ethdev_driver.h, it should be similar.