From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 656CE4318A; Tue, 17 Oct 2023 15:26:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F033B40273; Tue, 17 Oct 2023 15:26:13 +0200 (CEST) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id F109F40270; Tue, 17 Oct 2023 15:26:12 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id B955F32009B6; Tue, 17 Oct 2023 09:26:11 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 17 Oct 2023 09:26:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1697549171; x=1697635571; bh=UVK2biLbv29IBephtzJaqIU9WNu30c8//PF PB0dx/Gk=; b=BWXRE29Vaf0+tEM0Jzu1O9pT4W+B2uQsAkbUC9b4tuziOJRPnWg QfKSO8tz3GXz2MrFwM3EFiax/SmuJfbZNmMfwnvVtFdtuT/SdU1e+wcxuzAar2dr 0e2B2tjgpqZxCmdvFsuMOf5yvGRXmRAgBdsGV+qZP1lljYz3tn2k4mDEodGnC8eR mqwjlA0lcAwz8kdPUNASAhzM78pws4giz/Lko1y7d9tRp7vayQN15PCs8YnpZk76 lZH37MNgbQBprstYwPR+waYHUau+PWdQpx2tkBMGdQu1m46cB/SO8gxqbVbeB4Gg UYrwtEXUjeWAv34EoZ1Lm+lburgkD1QRvag== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1697549171; x=1697635571; bh=UVK2biLbv29IBephtzJaqIU9WNu30c8//PF PB0dx/Gk=; b=kahBu/XAte9oHYZ5NuiRYfJO4WGxGJUPZgjxQpEEHfcFplQovVg e07NyYHC8vcnkFL8xMkBYcTNZWyml9LtxaU+Iucl/Kl/vC/gzcghelCjvKCFMIO9 fLvvqE+bZV2oKo19JDwymffPmicowOtGoIcVS5kXlhcpBvm810RQHsr9/xhCk8Ia G1TcoJBam9oDD8UpkzFN2alblZ7l2tlWNUPpwBi4XrwrrVApVjZjtDsDmZxrK15Y 7WEOM6SeWHJH+/1PYrn4myFScF0hXZI431/JA27ojp1/PLpFmIKBb6jCVACKisQ+ QTxm7LWouWfWCOW/UqZUoxqLBvDmbYJK3iw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrjedvgdeivdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 17 Oct 2023 09:26:10 -0400 (EDT) From: Thomas Monjalon To: Vladimir Medvedkin Cc: dev@dpdk.org, stable@dpdk.org Subject: Re: [PATCH] fib: fix adding default route overwriting entire table Date: Tue, 17 Oct 2023 15:26:09 +0200 Message-ID: <20959154.0c2gjJ1VT2@thomas> In-Reply-To: <20231002151148.675857-1-vladimir.medvedkin@intel.com> References: <20231002151148.675857-1-vladimir.medvedkin@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 02/10/2023 17:11, Vladimir Medvedkin: > When FIB contains any route covering last ip address > (255.255.255.255), upon adding a new default route > the entire fib table will be overwritten with corresponding > default route next hop. > > Previous fix added check for ledge against 0 for case > if default route is added as a first route, however > this check was also erroneously triggered in case when > ledge was wrapped around the address space > (this would happen if FIB contains any route covering > last possible address - 255.255.255.255). > > This fix prevents wrap around from happening. > > Fixes: 880bc2b5f3bd ("fib: fix adding default route") > Cc: stable@dpdk.org > > Signed-off-by: Vladimir Medvedkin Applied, thanks.