From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) by dpdk.org (Postfix) with ESMTP id 0C9E66787 for ; Tue, 3 Nov 2015 09:17:54 +0100 (CET) Received: by wijp11 with SMTP id p11so66463200wij.0 for ; Tue, 03 Nov 2015 00:17:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=shZRNVoDf5OPHVRwvFp3Zq3lJ0b8U+C/AFmBJsZVfsY=; b=Cy7IMyc/iaPk+QkTgq0t80HGBowkfav+POGwMNH2MzpGQqnlg0vY8dYpNW2Wzzj1v2 +w3sIE25AXtnYh0DNaTg6x6k217yhEkm23CBlcqbCTl5P4S82Ma4vX/TG2n1R9QNABGt cxcfOapFrO7tiLCBWD8Q94hqkqgdIQAqpr88Y2eYaW0JsySoL/rwhs93xzRdoEcCQJd9 c5o6ixAQgLecmKP8O1K3WTtu/7GuhfRLfB56DX0bWg3mO7kbrpamtFcPI4Tz+8gSq68A ScSC5An+mniFgtgUHsHzsIQTzSYcPupvg64FT2xa5R8TNp1A0djC8ozyEpPHOlznVIxJ nauQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=shZRNVoDf5OPHVRwvFp3Zq3lJ0b8U+C/AFmBJsZVfsY=; b=hIk5G3f7+4JulszQe0NS0Leu1jWSS9Md1WuukBfck6FAG/H4K6zr+WAgQDZBD1EfWV CdV9jwa+cU2snfhnKj6ONji8tnP9b2kuIusC0NT+/zAa21A7SzvygWBEC3BUd4FPGSzF Xnmw6E9n6Gg8/J956TDc+1EuvNqxZ163rcW3eLMNz7RKl4ZorTe0XLJqECVlzn3yNMU0 mR3JjsF2eClJBCQedOEGWNIBCRL3ge2C62hIm/VTg6u4KMc4wTzzhwlhsz35qvXXDSzF wr21hg7fdoYGTcrgmXkvvtKB2zk4UW7KNPMuhViv3fErkVILoB7qOR/b6LHRbrurzG+G jxyg== X-Gm-Message-State: ALoCoQm3cYRHgN2SMqMySiEHc7/bMLAdrzpJgmNuk/LefTyScOVixrUHmPcIiUNPaOetNlX5vpmL X-Received: by 10.194.78.109 with SMTP id a13mr27704202wjx.20.1446538673867; Tue, 03 Nov 2015 00:17:53 -0800 (PST) Received: from xps13.localnet ([82.235.116.147]) by smtp.gmail.com with ESMTPSA id s127sm22131673wmb.8.2015.11.03.00.17.52 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Nov 2015 00:17:53 -0800 (PST) From: Thomas Monjalon To: Panu Matilainen , Eric Kinzie Date: Tue, 03 Nov 2015 09:16:38 +0100 Message-ID: <20975652.eOFrqL9zPp@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <563858B0.9010404@redhat.com> References: <1445268976-27491-1-git-send-email-ehkinzie@gmail.com> <20151102164206.GA14543@roosta.home> <563858B0.9010404@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v6 3/4] bond mode 4: allow external state machine X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Nov 2015 08:17:54 -0000 2015-11-03 08:48, Panu Matilainen: > On 11/02/2015 06:42 PM, Eric Kinzie wrote: > > On Mon Nov 02 12:23:47 +0200 2015, Panu Matilainen wrote: > >> On 11/01/2015 08:17 PM, Thomas Monjalon wrote: > >>> 2015-10-19 08:36, Eric Kinzie: > >>>> Size of struct rte_eth_bond_8023ad_conf changed. Increment LIBABIVER > >>>> and version bond_mode_8023ad_setup and bond_mode_8023ad_conf_get > >>>> functions. > >>> [...] > >>>> +VERSION_SYMBOL(bond_mode_8023ad_setup, _v20, 2.0); > >>> [...] > >>>> +BIND_DEFAULT_SYMBOL(bond_mode_8023ad_setup, _v22, 2.2); > >>>> +MAP_STATIC_SYMBOL(void bond_mode_8023ad_setup(struct rte_eth_dev *dev, struct rte_eth_bond_8023ad_conf *conf), \ > >>>> + bond_mode_8023ad_setup_v22); > >>> > >>> I'm sorry it doesn't work well when trying to build a combined lib: > >>> > >>> ld: libdpdk.so: version node not found for symbol bond_mode_8023ad_setup@@DPDK_2.2 > >>> > >>> The symbols are OK in the .o file: > >>> 0000000000002340 g F .text 0000000000000171 bond_mode_8023ad_setup@@DPDK_2.2 > >>> 0000000000002260 g F .text 00000000000000da bond_mode_8023ad_setup@DPDK_2.0 > >>> 0000000000002260 g F .text 00000000000000da bond_mode_8023ad_setup_v20 > >>> 0000000000002340 g F .text 0000000000000171 bond_mode_8023ad_setup_v22 > >>> 0000000000000000 *UND* 0000000000000000 bond_mode_8023ad_setup > >>> > >>> I don't understand the problem and I am considering disabling versioning in > >>> combined library. > >>> > >>> Any idea? > >>> > >> > >> The .map additions look incorrect to me: > >> > >>> diff --git a/drivers/net/bonding/rte_eth_bond_version.map b/drivers/net/bonding/rte_eth_bond_version.map > >>> index 22bd920..7f78717 100644 > >>> --- a/drivers/net/bonding/rte_eth_bond_version.map > >>> +++ b/drivers/net/bonding/rte_eth_bond_version.map > >>> @@ -17,6 +17,9 @@ DPDK_2.0 { > >>> rte_eth_bond_slaves_get; > >>> rte_eth_bond_xmit_policy_get; > >>> rte_eth_bond_xmit_policy_set; > >>> + rte_eth_bond_8023ad_ext_collect; > >>> + rte_eth_bond_8023ad_ext_distrib; > >>> + rte_eth_bond_8023ad_ext_slowtx; > >> > >> These symbols didn't exist in DPDK 2.0 but are only being added > >> here. So why are they being added to the 2.0 section? > > > > Yes, I think these should probably be moved. > > > > > >>> > >>> local: *; > >>> }; > >>> @@ -27,3 +30,10 @@ DPDK_2.1 { > >>> rte_eth_bond_free; > >>> > >>> } DPDK_2.0; > >>> + > >>> +DPDK_2.2 { > >>> + local > >>> + > >>> + bond_mode_8023ad_conf_get; > >>> + bond_mode_8023ad_setup; > >>> +} DPDK_2.1; > >> > >> These are marked local, as in, "not exported" which doesn't seem > >> right. Also they're lacking the rte_eth_ prefix. AFAICS this is what > >> the symbol export map should look like here: > > > > > > These were not exported to begin with. But after versioning these > > functions, they are exported unless explicitly declared to be local here. > > > > And this does not ring any warning bells? :) > > Sorry, I was not looking at the patch as a whole. You're declaring these > symbols as exported with the versioning macros, eg > > BIND_DEFAULT_SYMBOL(bond_mode_8023ad_setup, _v22, 2.2); > > ...and then explicitly telling it to not export them by declaring local, > and then we wonder why it has trouble finding the symbols. > The versioning macros wont invent the librte_ prefix for you, you need > to rename the functions accordingly. > > But all this versioning gymnastics is moot anyway because you declare > the ABI incompatible: > > -LIBABIVER := 1 > +LIBABIVER := 2 > > This changes the library soname, so no binary compiled against the > previous version can possibly use it anymore. As in, by definition there > can be no callers of the _v20 variants after this ABI version bump. Panu, thanks for your careful review. We must remove the private functions from the export map.and not bump LIBABIVER.