From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id C54042BD3 for ; Sat, 30 Mar 2019 01:14:17 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 599F0220E3; Fri, 29 Mar 2019 20:14:17 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 29 Mar 2019 20:14:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=BwbpEzFh2hxd5A32sTBlEifyTdR79evuYC8Y99aFIC4=; b=gs8bCk9u5K8/ cI3JJ8ysN7liJ9UXVPMIwJQCHHmnw9vKa1Ey0ZBNLF1LxbqPw92FkeJ8ZeB8ifcX SUmeATYzsYzvWN01j2X+iNWAQa0M1cBjrsHJX8yx6qwgL1lCkjWh60oYxU3BF1HX 0XZnBzON3d46yekylRMa2xe/vK7K7GI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=BwbpEzFh2hxd5A32sTBlEifyTdR79evuYC8Y99aFI C4=; b=FuLiTa5WtTKHfdxV6BZTgSq4ZqYquaphW/4VolOLqY1jFUoefpEjD+5b/ SGorXsm2y7BflzW8B2ktRb5IM69pjjWqzE2cjDQHqaTZ0p+EWzi46Smg+WUjyT9W gUWm83ZJZ3TaWxTFCMV2szDbLrCpkJrl1jcoxTiglKpkiwtm/lW8Kgp8fLnqw0Ne U/Gxj6VAxvNrfQbG6f3quHI4Mzx9yl206yTfKpgVtP6+s7yLHHivzwbE+tIiTyg0 synu5eVGknzuz59dAdwVs6NrJeADp8zFOcss/2mFekfP6am5ysWzXLtR3/WcVYoK sbV7T5w9fq1WrwUU9hycRwcDpvC3w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkeekgddulecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 305B7E46C1; Fri, 29 Mar 2019 20:14:16 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, Ferruh Yigit Date: Sat, 30 Mar 2019 01:14:14 +0100 Message-ID: <2099028.RPQpNJaItd@xps> In-Reply-To: References: <20190327135805.11067-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] examples: detect build directory rather than hardcoding X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Mar 2019 00:14:18 -0000 27/03/2019 16:02, Ferruh Yigit: > On 3/27/2019 1:58 PM, Bruce Richardson wrote: > > Most examples have in their makefiles a default RTE_TARGET directory to be > > used in case RTE_TARGET is not set. Rather than just using a hard-coded > > default, we can instead detect what the build directory is relative to > > RTE_SDK directory. > > > > This fixes a potential issue for anyone who continues to build using > > "make install T=x86_64-native-linuxapp-gcc" and skips setting RTE_TARGET > > explicitly, instead relying on the fact that they were building in a > > directory which corresponded to the example default path - which was > > changed to "x86_64-native-linux-gcc" by commit 218c4e68c1d9 ("mk: use > > linux and freebsd in config names"). > > > > Signed-off-by: Bruce Richardson > > Acked-by: Ferruh Yigit Applied, thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D1F31A05D3 for ; Sat, 30 Mar 2019 01:14:20 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 634252BF4; Sat, 30 Mar 2019 01:14:19 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id C54042BD3 for ; Sat, 30 Mar 2019 01:14:17 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 599F0220E3; Fri, 29 Mar 2019 20:14:17 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 29 Mar 2019 20:14:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=BwbpEzFh2hxd5A32sTBlEifyTdR79evuYC8Y99aFIC4=; b=gs8bCk9u5K8/ cI3JJ8ysN7liJ9UXVPMIwJQCHHmnw9vKa1Ey0ZBNLF1LxbqPw92FkeJ8ZeB8ifcX SUmeATYzsYzvWN01j2X+iNWAQa0M1cBjrsHJX8yx6qwgL1lCkjWh60oYxU3BF1HX 0XZnBzON3d46yekylRMa2xe/vK7K7GI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=BwbpEzFh2hxd5A32sTBlEifyTdR79evuYC8Y99aFI C4=; b=FuLiTa5WtTKHfdxV6BZTgSq4ZqYquaphW/4VolOLqY1jFUoefpEjD+5b/ SGorXsm2y7BflzW8B2ktRb5IM69pjjWqzE2cjDQHqaTZ0p+EWzi46Smg+WUjyT9W gUWm83ZJZ3TaWxTFCMV2szDbLrCpkJrl1jcoxTiglKpkiwtm/lW8Kgp8fLnqw0Ne U/Gxj6VAxvNrfQbG6f3quHI4Mzx9yl206yTfKpgVtP6+s7yLHHivzwbE+tIiTyg0 synu5eVGknzuz59dAdwVs6NrJeADp8zFOcss/2mFekfP6am5ysWzXLtR3/WcVYoK sbV7T5w9fq1WrwUU9hycRwcDpvC3w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkeekgddulecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 305B7E46C1; Fri, 29 Mar 2019 20:14:16 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, Ferruh Yigit Date: Sat, 30 Mar 2019 01:14:14 +0100 Message-ID: <2099028.RPQpNJaItd@xps> In-Reply-To: References: <20190327135805.11067-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] examples: detect build directory rather than hardcoding X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190330001414.nHLL-10E4_cOqLw4b1_CRqOjMisk7kvO78QH_Eb8Kmc@z> 27/03/2019 16:02, Ferruh Yigit: > On 3/27/2019 1:58 PM, Bruce Richardson wrote: > > Most examples have in their makefiles a default RTE_TARGET directory to be > > used in case RTE_TARGET is not set. Rather than just using a hard-coded > > default, we can instead detect what the build directory is relative to > > RTE_SDK directory. > > > > This fixes a potential issue for anyone who continues to build using > > "make install T=x86_64-native-linuxapp-gcc" and skips setting RTE_TARGET > > explicitly, instead relying on the fact that they were building in a > > directory which corresponded to the example default path - which was > > changed to "x86_64-native-linux-gcc" by commit 218c4e68c1d9 ("mk: use > > linux and freebsd in config names"). > > > > Signed-off-by: Bruce Richardson > > Acked-by: Ferruh Yigit Applied, thanks