From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20080.outbound.protection.outlook.com [40.107.2.80]) by dpdk.org (Postfix) with ESMTP id D3DD0493D for ; Wed, 1 May 2019 02:56:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8nuFxhecYodktH0xYGzUWHNRgZ/amuotnRuD+iv4JLM=; b=rPNX2lV6xG3joHVvEmczLjRaTtTfV0T8PtjRzTL++JidvJ/CdIzC3MWkl9Ajsdj7EqngVeVAcTakPpGajtmWyKzmj+YQqAOQUcByT9DMeAVJ3DH7C454BEKzp6fs+nmP192fyMLmTPMJeRxg54OHPXNDcY6UDRxY75oXnb6FCW4= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB3963.eurprd05.prod.outlook.com (52.134.72.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1856.10; Wed, 1 May 2019 00:56:44 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::e8d5:4aff:902d:6e98]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::e8d5:4aff:902d:6e98%5]) with mapi id 15.20.1856.008; Wed, 1 May 2019 00:56:45 +0000 From: Yongseok Koh To: Stephen Hemminger CC: Shahaf Shuler , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: check Tx queue size overflow Thread-Index: AQHU/4eTD0s19/fX1k2gVK/oXjWvrKZVLHeAgABCOwCAAAO7gA== Date: Wed, 1 May 2019 00:56:44 +0000 Message-ID: <20E5FC4A-C548-41CF-8D0E-9A3F3C386456@mellanox.com> References: <20190430190426.44018-1-yskoh@mellanox.com> <20190430134619.36cc9b21@hermes.lan> <769F5F97-2566-4826-89BB-441B97481E44@mellanox.com> In-Reply-To: <769F5F97-2566-4826-89BB-441B97481E44@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 46b39d35-9730-41d9-2ebc-08d6cdcfe1d4 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:DB3PR0502MB3963; x-ms-traffictypediagnostic: DB3PR0502MB3963: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 00246AB517 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(376002)(396003)(346002)(136003)(366004)(189003)(199004)(51914003)(6512007)(76176011)(53936002)(6246003)(4326008)(25786009)(86362001)(54906003)(316002)(99286004)(2906002)(64756008)(91956017)(66476007)(66556008)(66446008)(66946007)(73956011)(14454004)(36756003)(14444005)(3846002)(256004)(478600001)(76116006)(6116002)(7736002)(305945005)(83716004)(8676002)(26005)(6486002)(2616005)(186003)(6506007)(229853002)(5660300002)(71190400001)(71200400001)(102836004)(53546011)(82746002)(6436002)(68736007)(66066001)(8936002)(81156014)(6916009)(81166006)(33656002)(486006)(476003)(446003)(11346002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB3963; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: Qj31OYr1ldZvwSCnrX3F1/X9/HX10syJIgayRZ4ay9Me5lPDkTX0T/lFeVswAJEqRux/dTXWttJOIdZrANZv/klCIrvQqA41RPA2w2ZYdILTdKhcHiT23lP3IzjidzA+sDl7ku2J0mT/TpKamaqB7XjYyegdUP4drHxkTe2oB7RDVg0uj56xlgGhgW2hRmlSmpWEin5K0yTcnpwITIPGCj3eJwURV5s9M0gbFV354UmT72N2DdvcOASELZz7LohM49Qfw/Feg17Koabc3iLkgFVCZS2TztYMCbHbiA/0k0rcFa4Uk3/dPoDmXtfO0ZHp87GN34xXue4mOT1tnRDYH3e7rsAajX235PTfNp/8yC2/UW4+OEa9X0MQ+NDwAyIQjKbcXgd5gPt6Qdws1el2MenByrmBoCt/e0Q0WpccUbA= Content-Type: text/plain; charset="us-ascii" Content-ID: <7DD5A43FE349A041B64974675D0C0D3E@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 46b39d35-9730-41d9-2ebc-08d6cdcfe1d4 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 May 2019 00:56:44.6825 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB3963 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: check Tx queue size overflow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 May 2019 00:56:47 -0000 > On Apr 30, 2019, at 5:43 PM, Yongseok Koh wrote: >=20 >>=20 >> On Apr 30, 2019, at 1:46 PM, Stephen Hemminger wrote: >>=20 >> On Tue, 30 Apr 2019 12:04:26 -0700 >> Yongseok Koh wrote: >>=20 >>> + priv->sh->device_attr.orig_attr.max_qp_wr) { >>> + DRV_LOG(DEBUG, >>> + "port %u Tx WQEBB count exceeds the limit (%d)," >>> + " try smaller queue size again", >>> + dev->data->port_id, >>=20 >> The patch looks good, but it could be improved to make life easier >> for the users. >>=20 >> This is an error, why not print it at NOTICE level since DEBUG messages >> are usually suppressed. >=20 > Okay, better to set ERROR. >=20 >> Please don't break long lines in log messages. >=20 > That doesn't add new-line and mlx5 specific coding style. >=20 >> The latter part of the message >> is obvious, why not skip it. >=20 > Because not all users know what WQEBB means, I wanted to make user's life= easier > by informing what to do. >=20 >> Also since max_qp_wr is __u32, the print format should be %u >=20 > It was copied from the removing line but agree to change. No, it is 'int'. Please check 'struct ibv_device_attr'. >=20 >> Instead: >> DRV_LOG(NOTICE, >> "port %u Tx WQEBB count (%u) exceeds the limit (%u)", >> dev->data->port_id, >> txq_calc_wqebb_cnt(tmpl), >> priv->sh->device_attr.orig_attr.max_qp_wr); >>=20 >> Also, should it have a Fixes: tag to backport to stable? >=20 > Okay, no harm to give more information. >=20 >=20 > Thanks for the review. > Yongseok From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 35595A0679 for ; Wed, 1 May 2019 02:56:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1CD344C95; Wed, 1 May 2019 02:56:48 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20080.outbound.protection.outlook.com [40.107.2.80]) by dpdk.org (Postfix) with ESMTP id D3DD0493D for ; Wed, 1 May 2019 02:56:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8nuFxhecYodktH0xYGzUWHNRgZ/amuotnRuD+iv4JLM=; b=rPNX2lV6xG3joHVvEmczLjRaTtTfV0T8PtjRzTL++JidvJ/CdIzC3MWkl9Ajsdj7EqngVeVAcTakPpGajtmWyKzmj+YQqAOQUcByT9DMeAVJ3DH7C454BEKzp6fs+nmP192fyMLmTPMJeRxg54OHPXNDcY6UDRxY75oXnb6FCW4= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB3963.eurprd05.prod.outlook.com (52.134.72.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1856.10; Wed, 1 May 2019 00:56:44 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::e8d5:4aff:902d:6e98]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::e8d5:4aff:902d:6e98%5]) with mapi id 15.20.1856.008; Wed, 1 May 2019 00:56:45 +0000 From: Yongseok Koh To: Stephen Hemminger CC: Shahaf Shuler , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: check Tx queue size overflow Thread-Index: AQHU/4eTD0s19/fX1k2gVK/oXjWvrKZVLHeAgABCOwCAAAO7gA== Date: Wed, 1 May 2019 00:56:44 +0000 Message-ID: <20E5FC4A-C548-41CF-8D0E-9A3F3C386456@mellanox.com> References: <20190430190426.44018-1-yskoh@mellanox.com> <20190430134619.36cc9b21@hermes.lan> <769F5F97-2566-4826-89BB-441B97481E44@mellanox.com> In-Reply-To: <769F5F97-2566-4826-89BB-441B97481E44@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 46b39d35-9730-41d9-2ebc-08d6cdcfe1d4 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:DB3PR0502MB3963; x-ms-traffictypediagnostic: DB3PR0502MB3963: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 00246AB517 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(376002)(396003)(346002)(136003)(366004)(189003)(199004)(51914003)(6512007)(76176011)(53936002)(6246003)(4326008)(25786009)(86362001)(54906003)(316002)(99286004)(2906002)(64756008)(91956017)(66476007)(66556008)(66446008)(66946007)(73956011)(14454004)(36756003)(14444005)(3846002)(256004)(478600001)(76116006)(6116002)(7736002)(305945005)(83716004)(8676002)(26005)(6486002)(2616005)(186003)(6506007)(229853002)(5660300002)(71190400001)(71200400001)(102836004)(53546011)(82746002)(6436002)(68736007)(66066001)(8936002)(81156014)(6916009)(81166006)(33656002)(486006)(476003)(446003)(11346002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB3963; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: Qj31OYr1ldZvwSCnrX3F1/X9/HX10syJIgayRZ4ay9Me5lPDkTX0T/lFeVswAJEqRux/dTXWttJOIdZrANZv/klCIrvQqA41RPA2w2ZYdILTdKhcHiT23lP3IzjidzA+sDl7ku2J0mT/TpKamaqB7XjYyegdUP4drHxkTe2oB7RDVg0uj56xlgGhgW2hRmlSmpWEin5K0yTcnpwITIPGCj3eJwURV5s9M0gbFV354UmT72N2DdvcOASELZz7LohM49Qfw/Feg17Koabc3iLkgFVCZS2TztYMCbHbiA/0k0rcFa4Uk3/dPoDmXtfO0ZHp87GN34xXue4mOT1tnRDYH3e7rsAajX235PTfNp/8yC2/UW4+OEa9X0MQ+NDwAyIQjKbcXgd5gPt6Qdws1el2MenByrmBoCt/e0Q0WpccUbA= Content-Type: text/plain; charset="UTF-8" Content-ID: <7DD5A43FE349A041B64974675D0C0D3E@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 46b39d35-9730-41d9-2ebc-08d6cdcfe1d4 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 May 2019 00:56:44.6825 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB3963 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: check Tx queue size overflow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190501005644.aeTvz1e6fqfxPWrFofpTvYTkMwArWRV4GJwqc8iLJn4@z> > On Apr 30, 2019, at 5:43 PM, Yongseok Koh wrote: >=20 >>=20 >> On Apr 30, 2019, at 1:46 PM, Stephen Hemminger wrote: >>=20 >> On Tue, 30 Apr 2019 12:04:26 -0700 >> Yongseok Koh wrote: >>=20 >>> + priv->sh->device_attr.orig_attr.max_qp_wr) { >>> + DRV_LOG(DEBUG, >>> + "port %u Tx WQEBB count exceeds the limit (%d)," >>> + " try smaller queue size again", >>> + dev->data->port_id, >>=20 >> The patch looks good, but it could be improved to make life easier >> for the users. >>=20 >> This is an error, why not print it at NOTICE level since DEBUG messages >> are usually suppressed. >=20 > Okay, better to set ERROR. >=20 >> Please don't break long lines in log messages. >=20 > That doesn't add new-line and mlx5 specific coding style. >=20 >> The latter part of the message >> is obvious, why not skip it. >=20 > Because not all users know what WQEBB means, I wanted to make user's life= easier > by informing what to do. >=20 >> Also since max_qp_wr is __u32, the print format should be %u >=20 > It was copied from the removing line but agree to change. No, it is 'int'. Please check 'struct ibv_device_attr'. >=20 >> Instead: >> DRV_LOG(NOTICE, >> "port %u Tx WQEBB count (%u) exceeds the limit (%u)", >> dev->data->port_id, >> txq_calc_wqebb_cnt(tmpl), >> priv->sh->device_attr.orig_attr.max_qp_wr); >>=20 >> Also, should it have a Fixes: tag to backport to stable? >=20 > Okay, no harm to give more information. >=20 >=20 > Thanks for the review. > Yongseok