From: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
To: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: wrong spi read from packet
Date: Tue, 7 Jun 2016 13:57:19 +0100 [thread overview]
Message-ID: <20a3e36a-e043-ed4f-6f59-8e1fce4c2050@intel.com> (raw)
In-Reply-To: <1465301834-5477-1-git-send-email-slawomirx.mrozowicz@intel.com>
On 07/06/2016 13:17, Slawomir Mrozowicz wrote:
> In ipsec-secgw wrong SPI number is read from incoming ESP packet.
> The problem exist inside function inbound_sa_lookup().
> The SPI is read from mbuf where the information is stored in big-endian.
> In low-endian environment the value is erroneous.
> Fixed by add conversion rte_be_to_cpu_32().
>
> Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application")
>
> Signed-off-by: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>
> ---
This is a bug, but I don't think it is the right fix.
Anyway, the code has change with the last patch set [1] and the bug is
not present anymore.
[1] http://dpdk.org/ml/archives/dev/2016-May/039270.html
Sergio
prev parent reply other threads:[~2016-06-07 12:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 12:17 Slawomir Mrozowicz
2016-06-07 12:57 ` Sergio Gonzalez Monroy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20a3e36a-e043-ed4f-6f59-8e1fce4c2050@intel.com \
--to=sergio.gonzalez.monroy@intel.com \
--cc=dev@dpdk.org \
--cc=slawomirx.mrozowicz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).