From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 88FA58EA0 for ; Tue, 7 Jun 2016 14:57:21 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP; 07 Jun 2016 05:57:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,433,1459839600"; d="scan'208";a="715224175" Received: from smonroyx-mobl.ger.corp.intel.com (HELO [10.237.220.56]) ([10.237.220.56]) by FMSMGA003.fm.intel.com with ESMTP; 07 Jun 2016 05:57:20 -0700 To: Slawomir Mrozowicz References: <1465301834-5477-1-git-send-email-slawomirx.mrozowicz@intel.com> Cc: dev@dpdk.org From: Sergio Gonzalez Monroy Message-ID: <20a3e36a-e043-ed4f-6f59-8e1fce4c2050@intel.com> Date: Tue, 7 Jun 2016 13:57:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <1465301834-5477-1-git-send-email-slawomirx.mrozowicz@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: wrong spi read from packet X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jun 2016 12:57:21 -0000 On 07/06/2016 13:17, Slawomir Mrozowicz wrote: > In ipsec-secgw wrong SPI number is read from incoming ESP packet. > The problem exist inside function inbound_sa_lookup(). > The SPI is read from mbuf where the information is stored in big-endian. > In low-endian environment the value is erroneous. > Fixed by add conversion rte_be_to_cpu_32(). > > Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application") > > Signed-off-by: Slawomir Mrozowicz > --- This is a bug, but I don't think it is the right fix. Anyway, the code has change with the last patch set [1] and the bug is not present anymore. [1] http://dpdk.org/ml/archives/dev/2016-May/039270.html Sergio