From: Balazs Nemeth <bnemeth@redhat.com>
To: Devendra Singh Rawat <dsinghrawat@marvell.com>,
Igor Russkikh <irusskikh@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>, Rasesh Mody <rmody@marvell.com>
Subject: Re: [dpdk-dev] Potential regression introduced by commit b10231aed1edb9
Date: Wed, 30 Dec 2020 13:55:26 +0100 [thread overview]
Message-ID: <20b494692d1b54d1a83f519759584662371073c8.camel@redhat.com> (raw)
In-Reply-To: <CY4PR18MB1496E9B762B05AA9F14CBD5EB6D71@CY4PR18MB1496.namprd18.prod.outlook.com>
Hi, I already posted a patch that fixes the issue on my side here:
http://mails.dpdk.org/archives/dev/2020-December/195206.html
Regards,
Balazs
On Wed, 2020-12-30 at 12:51 +0000, Devendra Singh Rawat wrote:
> Adding more people to comment/investigate here.
>
> Devendra, could it be that we don't consider subsequent calls of
> promisc_enabled + allmulti_enable ?
>
> Devendra >> yes, I agree that as long as promiscuous mode is enabled
> for a port, all traffic should be accepted even if allmulticast is
> enabled latter. Commit b10231aed1edb9 shouldn't have changed that.
> I will prepare a fix patch for this.
>
> On 18/12/2020 2:34 pm, Balazs Nemeth wrote:
> > Hi,
> >
> > introduces a regression on my systems. I have a
> > "QLogic Corp. FastLinQ QL41000 Series 10/25/40/50GbE Controller"
> > which
> > relies on the qede driver. Calling
> > rte_eth_promiscuous_enable(portid)
> > followed by rte_eth_allmulticast_enable(port_id) causes no packets
> > to
> > arrive from my generator. It's important to add that the generator
> > doesn't specifically target the mac of the port. I presume that
> > irrespective of dst mac, if a port is put into promiscuous mode,
> > all
> > packets should arrive and rte_eth_allmulticast_enable should not
> > cause
> > *less* packets to arrive. Am I missing something? It seems that
> > b10231aed1edb9 inadvertently introduced either a bug or a pretty
> > significant change in semantics (at least for qede)?
> >
> > Regards,
> > Balazs
> >
next prev parent reply other threads:[~2020-12-30 12:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-18 13:34 Balazs Nemeth
2020-12-29 13:29 ` Igor Russkikh
2020-12-30 12:51 ` Devendra Singh Rawat
2020-12-30 12:55 ` Balazs Nemeth [this message]
2021-01-04 12:03 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20b494692d1b54d1a83f519759584662371073c8.camel@redhat.com \
--to=bnemeth@redhat.com \
--cc=dev@dpdk.org \
--cc=dsinghrawat@marvell.com \
--cc=irusskikh@marvell.com \
--cc=rmody@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).