From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <anatoly.burakov@intel.com>
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
by dpdk.org (Postfix) with ESMTP id 46A701B137
for <dev@dpdk.org>; Mon, 29 Apr 2019 12:42:42 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
29 Apr 2019 03:42:41 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,409,1549958400"; d="scan'208";a="168909437"
Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.113])
([10.237.220.113])
by fmsmga001.fm.intel.com with ESMTP; 29 Apr 2019 03:42:40 -0700
To: "Suanming.Mou" <mousuanming@huawei.com>, dev@dpdk.org
Cc: vipin.varghese@intel.com
References: <1556210141-43153-1-git-send-email-mousuanming@huawei.com>
<1556427506-49150-1-git-send-email-mousuanming@huawei.com>
<c777a608-6b5a-7f6e-8de9-999095580125@intel.com>
<58514852-12be-5ba5-60df-b7b01b586072@huawei.com>
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Message-ID: <20bb04a2-1961-6fb8-f594-9c169e4ee690@intel.com>
Date: Mon, 29 Apr 2019 11:42:39 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <58514852-12be-5ba5-60df-b7b01b586072@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v2] app/pdump: add exit_with_primary option
support.
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Apr 2019 10:42:42 -0000
On 29-Apr-19 10:43 AM, Suanming.Mou wrote:
>
<snip> :)
>>> /* true if x is a power of 2 */
>>> #define POWEROF2(x) ((((x)-1) & (x)) == 0)
>>> @@ -143,12 +147,14 @@ struct parse_val {
>>> static struct rte_eth_conf port_conf_default;
>>> static volatile uint8_t quit_signal;
>>> static uint8_t multiple_core_capture;
>>> +static uint8_t exit_with_primary;
>>
>> <snip>
> Could you please help to confirm that the 'snip' here mean we should
> delete the 'exit_with_primary' code?
No, "snip" means i'm skipping irrelevant sections, just to keep my reply
shorter and to the point :)
--
Thanks,
Anatoly
From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id 66D23A0679
for <public@inbox.dpdk.org>; Mon, 29 Apr 2019 12:42:45 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id A6BC21B138;
Mon, 29 Apr 2019 12:42:43 +0200 (CEST)
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
by dpdk.org (Postfix) with ESMTP id 46A701B137
for <dev@dpdk.org>; Mon, 29 Apr 2019 12:42:42 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
29 Apr 2019 03:42:41 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,409,1549958400"; d="scan'208";a="168909437"
Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.113])
([10.237.220.113])
by fmsmga001.fm.intel.com with ESMTP; 29 Apr 2019 03:42:40 -0700
To: "Suanming.Mou" <mousuanming@huawei.com>, dev@dpdk.org
Cc: vipin.varghese@intel.com
References: <1556210141-43153-1-git-send-email-mousuanming@huawei.com>
<1556427506-49150-1-git-send-email-mousuanming@huawei.com>
<c777a608-6b5a-7f6e-8de9-999095580125@intel.com>
<58514852-12be-5ba5-60df-b7b01b586072@huawei.com>
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Message-ID: <20bb04a2-1961-6fb8-f594-9c169e4ee690@intel.com>
Date: Mon, 29 Apr 2019 11:42:39 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <58514852-12be-5ba5-60df-b7b01b586072@huawei.com>
Content-Type: text/plain; charset="UTF-8"; format="flowed"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v2] app/pdump: add exit_with_primary option
support.
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190429104239.uv_TknTqKDptyU2qfw0y-WcAwOLSnanRN7jT3-k5YA8@z>
On 29-Apr-19 10:43 AM, Suanming.Mou wrote:
>
<snip> :)
>>> /* true if x is a power of 2 */
>>> #define POWEROF2(x) ((((x)-1) & (x)) == 0)
>>> @@ -143,12 +147,14 @@ struct parse_val {
>>> static struct rte_eth_conf port_conf_default;
>>> static volatile uint8_t quit_signal;
>>> static uint8_t multiple_core_capture;
>>> +static uint8_t exit_with_primary;
>>
>> <snip>
> Could you please help to confirm that the 'snip' here mean we should
> delete the 'exit_with_primary' code?
No, "snip" means i'm skipping irrelevant sections, just to keep my reply
shorter and to the point :)
--
Thanks,
Anatoly