From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A6EE74236B; Thu, 12 Oct 2023 04:01:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8C261402BA; Thu, 12 Oct 2023 04:01:08 +0200 (CEST) Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mails.dpdk.org (Postfix) with ESMTP id D250540279 for ; Thu, 12 Oct 2023 04:01:06 +0200 (CEST) Received: from dggpeml100024.china.huawei.com (unknown [172.30.72.54]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4S5XqB6XpNz1M99y; Thu, 12 Oct 2023 09:58:30 +0800 (CST) Received: from [10.67.121.161] (10.67.121.161) by dggpeml100024.china.huawei.com (7.185.36.115) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Thu, 12 Oct 2023 10:01:05 +0800 Subject: Re: [PATCH v5 38/40] app/proc-info: adjust the display format of RSS info To: Jie Hai , , Reshma Pattan , Vipin Varghese , John McNamara CC: , References: <20230908080030.3837515-1-haijie1@huawei.com> <20231011092805.693171-1-haijie1@huawei.com> <20231011092805.693171-39-haijie1@huawei.com> From: fengchengwen Message-ID: <20c34c73-0301-1a85-fd67-a51f35bba27d@huawei.com> Date: Thu, 12 Oct 2023 10:01:05 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20231011092805.693171-39-haijie1@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.161] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpeml100024.china.huawei.com (7.185.36.115) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi HaiJie, On 2023/10/11 17:28, Jie Hai wrote: > This patch splits the length and value of RSS key into two parts, > removes spaces between RSS keys, and adds line breaks between RSS > key and RSS hf. > > Before the adjustment, RSS info is shown as: > - RSS > -- RSS len 40 key (hex): 6d 5a 56 da 25 5b e c2 41 67 \ > 25 3d 43 a3 8f b0 d0 ca 2b cb ae 7b 30 b4 77 cb 2d \ > a3 80 30 f2 c 6a 42 b7 3b be ac 1 fa -- hf 0x0 > and after: > - RSS info > -- key len : 40 > -- key (hex) : 6d5a56da255b0ec24167253d43a38fb0d0c \ > a2bcbae7b30b477cb2da38030f20c6a42b73bbeac01fa > -- hash function : 0x0 How about convert to string? e.g. hash function: SIMPLE_XOR > > Fixes: 8a37f37fc243 ("app/procinfo: add --show-port") > Cc: stable@dpdk.org > > Signed-off-by: Jie Hai > Signed-off-by: Dongdong Liu > Acked-by: Reshma Pattan > --- > app/proc-info/main.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/app/proc-info/main.c b/app/proc-info/main.c > index 4509b3c16e36..e98352118db1 100644 > --- a/app/proc-info/main.c > +++ b/app/proc-info/main.c > @@ -1178,12 +1178,13 @@ show_port(void) > rss_conf.rss_key_len = dev_info.hash_key_size; > ret = rte_eth_dev_rss_hash_conf_get(i, &rss_conf); > if (ret == 0) { > - printf(" - RSS\n"); > - printf("\t -- RSS len %u key (hex):", > + printf(" - RSS info\n"); > + printf("\t -- key len : %u\n", > rss_conf.rss_key_len); > + printf("\t -- key (hex) : "); > for (k = 0; k < rss_conf.rss_key_len; k++) > - printf(" %x", rss_conf.rss_key[k]); > - printf("\t -- hf 0x%"PRIx64"\n", > + printf("%02x", rss_conf.rss_key[k]); > + printf("\n\t -- hash function : 0x%"PRIx64"\n", > rss_conf.rss_hf); Suggest %d other PRIx64 > } > >