From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD31642D68; Tue, 27 Jun 2023 20:03:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5F4FF40F18; Tue, 27 Jun 2023 20:03:23 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2047.outbound.protection.outlook.com [40.107.92.47]) by mails.dpdk.org (Postfix) with ESMTP id B2A7C40EE1 for ; Tue, 27 Jun 2023 20:03:22 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bxpb1KrJDWgUHuK+jOAgcWWUhj2pMr4PJAOmlgC5F6dny8HJMRm46wXWn0wy++wPwo3xuyig2z+LMxtDnF337avhYLVIBjVzmbZRdum1jWDwKa2LvduF49zeYHAgKgScHxzM5hV8jiCatN9yhcpzBquqCCMo8W060JQvetti83Vw47Np4tkmETvJ6ndz2q4FozSwgKqBTYlU4cvP63XNG7ICBRnOPpD0lWjOvDeIntNE7iLkCuh15sulfXROUykgNAx2y1j00NUyTxHY5qZD6HEfJrVsejq3d3zlLc3fiFvW2p/Fb+tO0OtQT63yPdHD9fgwE6XoQX+btTt4z0Ghcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kp9Fr4V+q2xhMOWLFR+5rHrRxnZ/7uGqb+VB26CTdoQ=; b=aBQVNjwzogmgIsY59VKp0HJF2VTN8Lh1DVeZB40oka6eixDh3iqetVL1Fxf6K4VHt2BEdBtxTQS1yy1HM+pemcc1ENjMuojLTNHE6B5J7uGXxifQFlenJfexFFuZ3XGRWD88wK5ZWHWvFmlj3McmBkIA9XyGOMak2KxYUKcmokvDklW5r5NH8MYjRepTW3Ouqn2upzM/AyH5Rp7KKCphiD3eAlIoycq0hJrl5QF/HCA1J5lO5x93r4zz8A5hnxnYg9xvcQTcWtuqNhAYeuOWPhgKGb2Dq1pR+VlU+i3M9f9j+sZ9OKYOZQ/j8r4aNiDuPg93TkehRIBi1C7X6WJXKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kp9Fr4V+q2xhMOWLFR+5rHrRxnZ/7uGqb+VB26CTdoQ=; b=t7yy+zyRR0q6flPb6Elxh53RDrnkPRj5wyoKuCW9u3K9dsgDfG1HqEvKm7k6E6W/9QCJOGxuTwVTYqfRZh1kQY798Uzw1s7Kaq++GPf/jmqf8/Xr6N1wXNaDtSHPUu5wFZK2XcdUgXDcecNSYE7+4zuxWClTgq4DctdYkwtqSZU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH7PR12MB6635.namprd12.prod.outlook.com (2603:10b6:510:210::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.23; Tue, 27 Jun 2023 18:03:20 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42%3]) with mapi id 15.20.6544.012; Tue, 27 Jun 2023 18:03:20 +0000 Message-ID: <20d2748d-34b8-31ed-7072-684b98af10e2@amd.com> Date: Tue, 27 Jun 2023 19:03:14 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] app/testpmd: add dump command help message Content-Language: en-US To: Viacheslav Ovsiienko References: <20230627144426.23144-1-viacheslavo@nvidia.com> Cc: Aman Singh , dev@dpdk.org From: Ferruh Yigit In-Reply-To: <20230627144426.23144-1-viacheslavo@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR2P264CA0038.FRAP264.PROD.OUTLOOK.COM (2603:10a6:101:1::26) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH7PR12MB6635:EE_ X-MS-Office365-Filtering-Correlation-Id: b5758dba-4e34-46b7-085d-08db7738ca6d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MHDJRDs4vMSnAWSCzRekQwaXMmE7RRsPvpRKH9B3wMmlX3wsbdpyMdQLbCrEFsLSWT9Q+3S8hpSFsgaEcek6RwP3HiV6k8peqqqjlj95iXk4iwEY+yaHRFe3attwjnukM54fTDUsBKMeghJI/L1EFmKrNph2aquge8uRuJ3FWi4uBrHNmYQGf2i3+q+0M3GYT3FTyD/TUlW+lhvdKVo9EFlhboa/gf2kcloVUkQTNmb8gDJ7qPK1ZiEYFsI2748O9LqROK2QRh28yJ/b2SqDkUonMBib4ctmL7APnL++MzvaSy0FbBNL83OSK6uRQ3uqd8frIPHrkzqN2yNPrA1wyBv1QwB8TnVrAqtfCa2YWFRgfL64g53ansk26e2Wn5nuA+TTlabfeiuNYHSY/vQ19vck+S5X2rQn2R1Xq5L/PY5zykh6rjFLTOi3x9YNVTbt6/8zu3rhasgW5HPWDMTS98D+kytWV9ART10VSCIfyI/fMD2Tjny97kwijB21bzV27ittPNnoFhQgghVJOl/CJ3BevvMGysOft9rBaG9dZ5SuItu6LXJqWpj7B1aAJ4GIVApE6CY1FaimHgq4RACI8AvNfGhCb2LIpJwnCTQn/ddczGjC6VWPeJmPTEt0Xfhp8I9ucfKMplZBUQIFd8mEaw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(346002)(136003)(39860400002)(366004)(376002)(451199021)(66556008)(66476007)(6506007)(36756003)(6666004)(478600001)(2616005)(83380400001)(26005)(186003)(53546011)(2906002)(6486002)(15650500001)(5660300002)(44832011)(6916009)(66946007)(31696002)(38100700002)(8676002)(86362001)(316002)(4326008)(41300700001)(8936002)(31686004)(6512007)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M1NhOFloa0RwdDNIYXhmZWF2UVZtY004QmdZTU5OSnpTOWlWMElLNDZlU3ox?= =?utf-8?B?cEhJOHhrWVNWOUZTR2NPZURlQlpsenRPRkQ0KzlpMHBweW45SDlrTXhHblhT?= =?utf-8?B?WjIwZElVWWltcXo3M1JrN1AySFp0NlZGUzljRGxnL2pta3hlUVY1UFZib05X?= =?utf-8?B?QkdicjlFU2gxTHl6Z0NGRkoxQzhYbFltQkpCMXYrQldYN2FMbGhReEpjWlZ5?= =?utf-8?B?VlpOOHlFQVdwWDh5NHAwMmhNTUJpYnpYVjNjTVExZ0dQRGlkSjRWeWI2S3BN?= =?utf-8?B?UndDaVR2QTI0VW9mRVlwem56M0FhZXFZak9PVFhNWFpYWWNyQkRaT0U2dmNZ?= =?utf-8?B?dEZ3Y3JzOFkzU1Q4eUc2dFAwRFc3N05xMzJQUDFLL0p5bDVOQXNZT2RseXZK?= =?utf-8?B?R2RYV1kzeVV0aURUMmRsakhwVVdtMHRINTdpajFFN1pvUGNRdHJnbk05d2pp?= =?utf-8?B?a0Y5WVpiSG9HUWt6ZWMrc3ByTCtUZUlZV3pZRmdzZllVRDhEVy9jMStOeis4?= =?utf-8?B?aUFpV0QwVWtkRVQxSnNacDRYNUxScmgyYXJ3WlB3d3gyQVNQYU1ISHhKOGpZ?= =?utf-8?B?VDZOOW9oM0p4U1BjYVJpS0ZKeUMrMmZlcllVYm14emcvVXZ1WFo2R3d0aGIz?= =?utf-8?B?VW1ZdnpUNmJIMkVSZ3IwVW4vYjhUZmdEWVN5MklqS1VlSXh2TG5zUWVlMFI3?= =?utf-8?B?dEh2Vm5WZUdkUk1NRWRzMklHZHJGSjAxbnZlb0NDdWxKZEd4OTQ4YklDVFYy?= =?utf-8?B?L2J5Um5nQk1Ma3pCNDlhejNmMmxLVDNsTW9oZDFXdHNleW5SbDdCdUU4YUpm?= =?utf-8?B?T1l1OHJlZzlZTGxKeW9nOThLWWFYN2tNTEVGS0VHTkVKQkg5ZVpiRGFzQkd6?= =?utf-8?B?bUhhOFpGaEk5QVQwZmNPcEp2MFJGYVhaV2dXMVd4VDVuV1V6VFJmcVdTdEFl?= =?utf-8?B?UVNXTVJURWR4dVBjMExRREZIVzRQNFFzRUlMWnl3YS93SlF4dE5kRUJ2em01?= =?utf-8?B?a3FoRHUwbkhWNkphNmY0OXFFSDBpZkxqMU0xeDFxZ1hiMllLckplQU1vdVk4?= =?utf-8?B?M2RyUHRublJ0T0dQSHMyLytsZlk5V0xrT0tHcHNyM2Z3ZlFzb2N6eUdmRHp1?= =?utf-8?B?N1NRbEdBZnlFbmZUZk9ERW5UQ3VSUWNHRFErNFp1T24vK2hvMHRkR0NUNnFt?= =?utf-8?B?a1hpcWdOUnZQZGlUdmErbFlZaExBTTViTlBmVkI0eG5DTTFlejN6Tm9GZCs2?= =?utf-8?B?UXVrbURGZFJoc2IwKzdtdCs5dytwbkxoRDdRWWtnNEJJbS9VSkZvRk5UbkZF?= =?utf-8?B?aDg1dTVyK2Z4L1k5RjRPaG9DR043QTZKMk9DR2hUODVpcE1hNGZZcmRMc1lm?= =?utf-8?B?RU1yUTRzVm53OFRRQlp0eGxaSjhEOFZGZkdaeW5DaW1vN2JVei9RRGlLb2o2?= =?utf-8?B?ZVZXMmxIcEF2eXkwaFB4K3VUZGh4LzlCUGwvTENTc2NFY3hMRGJoMGlsNllF?= =?utf-8?B?ZEdYaE9NNlMyQTZUckNob2JmM0NKZUNuUUQ2Vmo0cTdkSXREYkFjSlRZUyt0?= =?utf-8?B?MUltbDErS285d1Q2T2p5MHlwNlNqelRieFZsOFNRWCtnWTl3Rld3ZnVMbHdl?= =?utf-8?B?V0FKaDFCWEl4eGFveTlVR1J2Y2V4YkJySDEwcTJTYjJ6SlJEeEtzU2NTM0pm?= =?utf-8?B?WXQvalpPdndSTG5BdlZvekwzSnVpMUV3UFVJYXdvZ1lBM3hhUkpjc0FUWWZo?= =?utf-8?B?dlBWRjltbWtsTkw4b3lUWVZLc0xYeG9MUHo2UmNnM1hXMWxsMkxnaVlHM0xB?= =?utf-8?B?YmpVcjZWRFh2eDNFaE83dmwxYkRaaUhua0pWUTI1dURscTE3L3lyNUxCbndS?= =?utf-8?B?UTRjUHdkd29tN3N4WFYyVFcvWVhOanNHeHhHRk03R3ZkQ29iaUhtK3BJK0hQ?= =?utf-8?B?U0VaNWpLcWsxSnlndGxvQ1lEbmdKb2t6dFRzK1JNN3JsRVB6dFp2eDUwcnNR?= =?utf-8?B?ekxyWTJVS1BkQmV2Y29SS29rY0hTdXVoclpBSTVxYmRKdkJBS2IvdGowOEcv?= =?utf-8?B?eGgxdGhKRU5jdE5uT3BocWt1MFhTb0FVdTZuTFFTQzI5VEtnQXNITzNTL3RO?= =?utf-8?Q?+Q9ZiNINzXtyaYO9XYvuuXKDf?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5758dba-4e34-46b7-085d-08db7738ca6d X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jun 2023 18:03:20.3527 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OlUh2kJz07/anVGqV4/ql4GskZk8GRkwZhUqkMZeLpbgDLdD6iDRKe1IEkhlWJVq X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6635 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/27/2023 3:44 PM, Viacheslav Ovsiienko wrote: > There was missing "dump_xxxxx" commands help message. > Patch adds support for "help dump" command to see one. > Hi Slava, Thanks for the patch, this seems missed for a while. > Signed-off-by: Viacheslav Ovsiienko > --- > app/test-pmd/cmdline.c | 43 ++++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 41 insertions(+), 2 deletions(-) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index 18e6e19497..9edbb7d04f 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -92,6 +92,7 @@ static void cmd_help_brief_parsed(__rte_unused void *parsed_result, > " help ports : Configuring ports.\n" > " help filters : Filters configuration help.\n" > " help traffic_management : Traffic Management commands.\n" > + " help dump : Dumps related commands.\n" I am not sure 'dump_*' commands are unique group to make a new help section, even description is vague "dump related ..", or if they are important enough for a new section, what would you think to append them to 'display' section?