From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id EF49A1B1FE; Mon, 1 Oct 2018 15:45:05 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Oct 2018 06:45:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,327,1534834800"; d="scan'208";a="95443221" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.49]) ([10.237.221.49]) by orsmga001.jf.intel.com with ESMTP; 01 Oct 2018 06:45:03 -0700 To: Jerin Jacob , Olivier Matz Cc: dev@dpdk.org, stable@dpdk.org, jiayu.hu@intel.com References: <20180913134707.23698-1-jerin.jacob@caviumnetworks.com> <20180913134707.23698-2-jerin.jacob@caviumnetworks.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: <20d2c484-6c86-7c55-4973-d55f1da20a6c@intel.com> Date: Mon, 1 Oct 2018 14:45:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180913134707.23698-2-jerin.jacob@caviumnetworks.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/4] mbuf: fix Tx offload mask X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2018 13:45:06 -0000 On 9/13/2018 2:47 PM, Jerin Jacob wrote: > Fixes missing PKT_TX_UDP_SEG value in PKT_TX_OFFLOAD_MASK. > > Fixes: 6d18505efaa6 ("vhost: support UDP Fragmentation Offload") > Cc: stable@dpdk.org > Cc: jiayu.hu@intel.com > > Signed-off-by: Jerin Jacob > --- > lib/librte_mbuf/rte_mbuf.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h > index 9ce5d76d7..6a5dbbc8f 100644 > --- a/lib/librte_mbuf/rte_mbuf.h > +++ b/lib/librte_mbuf/rte_mbuf.h > @@ -343,7 +343,8 @@ extern "C" { > PKT_TX_VLAN_PKT | \ > PKT_TX_TUNNEL_MASK | \ > PKT_TX_MACSEC | \ > - PKT_TX_SEC_OFFLOAD) > + PKT_TX_SEC_OFFLOAD | \ > + PKT_TX_UDP_SEG) Also can you sort the list, it seem there was an intention to sort from high bits to low, but broken, it makes easy to recognize missing items later.