From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: "Min Hu (Connor)" <humin29@huawei.com>, dev@dpdk.org
Cc: ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [PATCH 1/6] net/hns3: modify max reset fail retry count
Date: Mon, 14 Jun 2021 17:36:46 +0300 [thread overview]
Message-ID: <20fda17a-9fb9-62eb-c1f7-1794d796be2a@oktetlabs.ru> (raw)
In-Reply-To: <1623551516-49635-2-git-send-email-humin29@huawei.com>
On 6/13/21 5:31 AM, Min Hu (Connor) wrote:
> From: HongBo Zheng <zhenghongbo3@huawei.com>
>
> When the device is very busy, VF reset may have to be
> retried many times to succeed, leading to the current
> max reset fail retry count not enough.
>
> This patch modify max reset fail retry count to 30 to
> enhance the reliability of reset function.
Drop "This patch", just "Modify ..."
> Fixes: 2790c6464725 ("net/hns3: support device reset")
> Cc: stable@dpdk.org
>
> Signed-off-by: HongBo Zheng <zhenghongbo3@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> ---
> drivers/net/hns3/hns3_intr.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/hns3/hns3_intr.c b/drivers/net/hns3/hns3_intr.c
> index 6bdb17f..0b307fd 100644
> --- a/drivers/net/hns3/hns3_intr.c
> +++ b/drivers/net/hns3/hns3_intr.c
> @@ -2582,7 +2582,7 @@ hns3_clear_reset_level(struct hns3_hw *hw, uint64_t *levels)
> static bool
> hns3_reset_err_handle(struct hns3_adapter *hns)
> {
> -#define MAX_RESET_FAIL_CNT 5
> +#define MAX_RESET_FAIL_CNT 30
>
> struct hns3_hw *hw = &hns->hw;
>
> @@ -2676,7 +2676,7 @@ hns3_reset_pre(struct hns3_adapter *hns)
> static int
> hns3_reset_post(struct hns3_adapter *hns)
> {
> -#define TIMEOUT_RETRIES_CNT 5
> +#define TIMEOUT_RETRIES_CNT 30
> struct hns3_hw *hw = &hns->hw;
> struct timeval tv_delta;
> struct timeval tv;
next prev parent reply other threads:[~2021-06-14 14:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-13 2:31 [dpdk-dev] [PATCH 0/6] bugfixes for hns3 PMD Min Hu (Connor)
2021-06-13 2:31 ` [dpdk-dev] [PATCH 1/6] net/hns3: modify max reset fail retry count Min Hu (Connor)
2021-06-14 14:36 ` Andrew Rybchenko [this message]
2021-06-13 2:31 ` [dpdk-dev] [PATCH 2/6] net/hns3: fix delay time for waiting to stop rxtx Min Hu (Connor)
2021-06-13 2:31 ` [dpdk-dev] [PATCH 3/6] net/hns3: fix incorrect fake queue rollback Min Hu (Connor)
2021-06-13 2:31 ` [dpdk-dev] [PATCH 4/6] net/hns3: fix VLAN strip log Min Hu (Connor)
2021-06-13 2:31 ` [dpdk-dev] [PATCH 5/6] net/hns3: fix config max queues to zero when fails Min Hu (Connor)
2021-06-13 2:31 ` [dpdk-dev] [PATCH 6/6] net/hns3: delete redundant blank lines Min Hu (Connor)
2021-06-14 14:43 ` [dpdk-dev] [PATCH 0/6] bugfixes for hns3 PMD Andrew Rybchenko
2021-06-15 0:47 ` Min Hu (Connor)
2021-06-17 14:56 ` Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20fda17a-9fb9-62eb-c1f7-1794d796be2a@oktetlabs.ru \
--to=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=humin29@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).