From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 1DEA4A0C44;
	Mon, 14 Jun 2021 16:36:50 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id F41174067A;
	Mon, 14 Jun 2021 16:36:49 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 5AB984003F
 for <dev@dpdk.org>; Mon, 14 Jun 2021 16:36:48 +0200 (CEST)
Received: from [192.168.1.71] (unknown [188.170.85.171])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 8FF447F504;
 Mon, 14 Jun 2021 17:36:47 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 8FF447F504
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1623681407;
 bh=nn8zNFj4WtqtcAsizJ6MM5mJw6hmdzjQzw7Psgrp1K0=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=w97ue9vzja4n7ak+LGMQ2n+13YSJCUjvIBWcdvmPX0jU8uqo2o6HOu5oCkNuhARL7
 oYkNlz1BdUsEfA4Ybf3knxyk0yiP7PMxCGoTAIbfs5hR+BUd05D7jJxgzwe+868Arg
 J45R7hxsP0m4v+hAXd8AWhMck952uGw/LvCVU+60=
To: "Min Hu (Connor)" <humin29@huawei.com>, dev@dpdk.org
Cc: ferruh.yigit@intel.com
References: <1623551516-49635-1-git-send-email-humin29@huawei.com>
 <1623551516-49635-2-git-send-email-humin29@huawei.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Message-ID: <20fda17a-9fb9-62eb-c1f7-1794d796be2a@oktetlabs.ru>
Date: Mon, 14 Jun 2021 17:36:46 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.0
MIME-Version: 1.0
In-Reply-To: <1623551516-49635-2-git-send-email-humin29@huawei.com>
Content-Language: en-US
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
Subject: Re: [dpdk-dev] [PATCH 1/6] net/hns3: modify max reset fail retry
 count
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 6/13/21 5:31 AM, Min Hu (Connor) wrote:
> From: HongBo Zheng <zhenghongbo3@huawei.com>
>
> When the device is very busy, VF reset may have to be
> retried many times to succeed, leading to the current
> max reset fail retry count not enough.
>
> This patch modify max reset fail retry count to 30 to
> enhance the reliability of reset function.

Drop "This patch", just "Modify ..."

> Fixes: 2790c6464725 ("net/hns3: support device reset")
> Cc: stable@dpdk.org
>
> Signed-off-by: HongBo Zheng <zhenghongbo3@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> ---
>   drivers/net/hns3/hns3_intr.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/hns3/hns3_intr.c b/drivers/net/hns3/hns3_intr.c
> index 6bdb17f..0b307fd 100644
> --- a/drivers/net/hns3/hns3_intr.c
> +++ b/drivers/net/hns3/hns3_intr.c
> @@ -2582,7 +2582,7 @@ hns3_clear_reset_level(struct hns3_hw *hw, uint64_t *levels)
>   static bool
>   hns3_reset_err_handle(struct hns3_adapter *hns)
>   {
> -#define MAX_RESET_FAIL_CNT 5
> +#define MAX_RESET_FAIL_CNT 30
>   
>   	struct hns3_hw *hw = &hns->hw;
>   
> @@ -2676,7 +2676,7 @@ hns3_reset_pre(struct hns3_adapter *hns)
>   static int
>   hns3_reset_post(struct hns3_adapter *hns)
>   {
> -#define TIMEOUT_RETRIES_CNT	5
> +#define TIMEOUT_RETRIES_CNT	30
>   	struct hns3_hw *hw = &hns->hw;
>   	struct timeval tv_delta;
>   	struct timeval tv;