From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8D0C0A00C4; Thu, 31 Oct 2019 14:43:48 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 019601C23F; Thu, 31 Oct 2019 14:43:48 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 7E5511C23D for ; Thu, 31 Oct 2019 14:43:46 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 23EF4217DD; Thu, 31 Oct 2019 09:43:46 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 31 Oct 2019 09:43:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=CRllc4RGjthWPk8pNI/dhPlVwkpZzhdzW//c7iExcWQ=; b=GbXRz59xM/pi 666CCVJr4Zcv72P2sj39Z5M7UG196kSRIJr2fqvStyI91TJmSGLTZ0nGoTaBVguf W3jEiNffz8INxLDYERy6cBKIUQ86dlYrMGaPQFsEo/ABAalB5po6i8mmgm1dUIWr Jrw0vjOm7YXKQg4oBq4TGZqfekunRk0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=CRllc4RGjthWPk8pNI/dhPlVwkpZzhdzW//c7iExc WQ=; b=Qo5YLSRS799CZj2LONqzNvkuNFOHfSGiGmhF29I7kzT21DFm/FzS2ZnZt GWeR3Cw80+LxdcilWeDULPqQSZhSZ8UGcSUkuBOZZ2vNMATEkgq+kypaS6Y5mrSi s9WOeeL4H8bkF+nltysqCF/54ZDf0CbjWv/irFnsFnF0oweq441Gxe/Sh+kMspBD gZiKmb5Oy4MioDHiJPK2k4Q0YHjN6TdVhMfqYSl7w1dE3PIlfo0sGBrG67qMcAtf jHvzfUG1yI/59laDteA/EUqrdFL+Dq3X7H63OH6Lkv8BAxpEK7jHtMJw5sgasB3s +QsNKTnXJUjYRqX9GDgdWiycowc2w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedruddthedgheefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 798C7306006E; Thu, 31 Oct 2019 09:43:44 -0400 (EDT) From: Thomas Monjalon To: pbhagavatula@marvell.com Cc: dev@dpdk.org, ferruh.yigit@intel.com, arybchenko@solarflare.com, jerinj@marvell.com, John McNamara , Marko Kovacevic , olivier.matz@6wind.com Date: Thu, 31 Oct 2019 14:43:42 +0100 Message-ID: <2100322.CaLuLyjtmg@xps> In-Reply-To: <20191029153722.4547-3-pbhagavatula@marvell.com> References: <20191029050312.2715-1-pbhagavatula@marvell.com> <20191029153722.4547-1-pbhagavatula@marvell.com> <20191029153722.4547-3-pbhagavatula@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v15 2/7] ethdev: add mbuf RSS update as an offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 29/10/2019 16:37, pbhagavatula@marvell.com: > --- a/doc/guides/rel_notes/release_19_11.rst > +++ b/doc/guides/rel_notes/release_19_11.rst > @@ -239,6 +239,13 @@ New Features > * This scheme will allow PMDs to avoid lookup to internal ptype table on Rx > and thereby improve Rx performance if application wishes do so. > > +* **Added Rx offload flag to enable or disable RSS update** > + > + * Added new Rx offload flag `DEV_RX_OFFLOAD_RSS_HASH` which can be used to > + enable/disable PMDs write to `rte_mbuf::hash::rss`. > + * PMDs notify the validity of `rte_mbuf::hash:rss` to the application > + by enabling `PKT_RX_RSS_HASH ` flag in `rte_mbuf::ol_flags`. Please move this paragraph in the right order (before net drivers). > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h > @@ -1048,6 +1048,7 @@ struct rte_eth_conf { > #define DEV_RX_OFFLOAD_KEEP_CRC 0x00010000 > #define DEV_RX_OFFLOAD_SCTP_CKSUM 0x00020000 > #define DEV_RX_OFFLOAD_OUTER_UDP_CKSUM 0x00040000 > +#define DEV_RX_OFFLOAD_RSS_HASH 0x00080000 OK, it looks simple. Olivier, are missing something regarding mbuf offload?