From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 49B0FA059F; Fri, 10 Apr 2020 12:24:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 290951C29C; Fri, 10 Apr 2020 12:24:17 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 7EC961C295 for ; Fri, 10 Apr 2020 12:24:15 +0200 (CEST) IronPort-SDR: ElLZI4wGAvZZz+ORB/v8fgQV3i6+sP72IhYvMdDFw29jeOP9QMx+nSmJ882Hpa0mVLq0dCzFxZ zAp3RffJ2pVQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2020 03:24:14 -0700 IronPort-SDR: fK5VJZAopfHHvGLZa/I669Rp860eOnBAxyXuU4zoBX2+sKdybBc7rcAjbDRDOnCrlSEOFz8Q9s 7CzIr5tOdm4g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,366,1580803200"; d="scan'208";a="297773329" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.252.17.204]) ([10.252.17.204]) by FMSMGA003.fm.intel.com with ESMTP; 10 Apr 2020 03:24:12 -0700 From: Ferruh Yigit To: podovinnikov , Chas Williams , "Wei Hu (Xavier)" , "Wei Hu (Xavier)" Cc: dev@dpdk.org References: <20191125180323.E0B174C90@dpdk.org> <20191126115508.11138-1-podovinnikov@protei.ru> <906848bc-7411-79dd-0ee1-c0f3c5d1ff16@intel.com> <96d3e5ae-ad62-2f7d-c91f-e13d170d210d@intel.com> Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: <2100656d-c4e1-1aed-8d7c-1e728371ea2a@intel.com> Date: Fri, 10 Apr 2020 11:24:12 +0100 MIME-Version: 1.0 In-Reply-To: <96d3e5ae-ad62-2f7d-c91f-e13d170d210d@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2] fix lacp check system address X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/10/2020 11:21 AM, Ferruh Yigit wrote: > On 4/10/2020 11:15 AM, Ferruh Yigit wrote: >> On 11/26/2019 3:09 PM, podovinnikov wrote: >>> Hi Ferruh >>> >>>> This is bonding patch, please cc bonding maintainers (Chas, instead of John W. >>>> Linville). >>> Sorry about that. I have 2 patches ( one for af packet, one for bonding). >>> >>> I am a little confused. >>> >>> >>>> Can you please give more details, what is failing what is the impact etc. >>> >>> In bond (lacp) we have several nics ( ports ) >>> >>> When we have negotiation with peer about what port we prefer, >>> >>> we send information about what system we preferred in partner system >>> name field. >>> >>> Peer also sends us what partner system name it prefer. >>> >>> When we receive a message from it we must compare its preferred >>> >>> system name with our system name, but not with our port mac address >>> >>> In my test I have several problems with that >>> >>> 1. If master port (mac address same as system address) >>> >>> shuts down (I have two ports) I loose connection >>> >>> 2. If secondary port (mac address not same as system address) >>> >>> receives message before master port, my connection is not established. >> >> Hi Vadim, >> >> Thanks for the info and sorry for late response, it is sitting in backlog for a >> long time now. >> >> @Chas, do you have any objection on the fix, if not I am planning to merge it soon. >> >> Thanks, >> ferruh > > cc'ed Xavier, he also has a bonding patch in the backlog waiting for review [1]. > > > Vadim, Xavier, > > Since you both send bonding patches, I assume you both know about bonding at > some level, at least more than me, so would you mind reviewing eachother's > patch? So both can go it. + other email address of the Xavier. > > Thanks, > ferruh > > > [1] > https://patchwork.dpdk.org/user/todo/dpdk/?series=8679 > >> >>> >>> >>> 26.11.2019 16:27, Ferruh Yigit пишет: >>>> Hi Vadim, >>>> >>>> On 11/26/2019 11:55 AM, Vadim wrote: >>>>> Signed-off-by: Vadim >>>> Can you please provide full "Name Surname " signature? >>>> >>>> >>>> This is bonding patch, please cc bonding maintainers (Chas, instead of John W. >>>> Linville). >>>> >>>>> fix lacp check system address >>>> Can you please give more details, what is failing what is the impact etc. >>>> >>>>> --- >>>>> drivers/net/bonding/rte_eth_bond_8023ad.c | 17 ++++++++++++++++- >>>>> 1 file changed, 16 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c >>>>> index b77a37ddb..d4dda790a 100644 >>>>> --- a/drivers/net/bonding/rte_eth_bond_8023ad.c >>>>> +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c >>>>> @@ -792,18 +792,33 @@ rx_machine_update(struct bond_dev_private *internals, uint16_t slave_id, >>>>> struct rte_mbuf *lacp_pkt) { >>>>> struct lacpdu_header *lacp; >>>>> struct lacpdu_actor_partner_params *partner; >>>>> + struct port *port, *agg; >>>>> >>>>> if (lacp_pkt != NULL) { >>>>> lacp = rte_pktmbuf_mtod(lacp_pkt, struct lacpdu_header *); >>>>> RTE_ASSERT(lacp->lacpdu.subtype == SLOW_SUBTYPE_LACP); >>>>> >>>>> partner = &lacp->lacpdu.partner; >>>>> + port = &bond_mode_8023ad_ports[slave_id]; >>>>> + agg = &bond_mode_8023ad_ports[port->aggregator_port_id]; >>>>> + >>>>> if (rte_is_same_ether_addr(&partner->port_params.system, >>>>> - &internals->mode4.mac_addr)) { >>>>> + &agg->actor.system)) { >>>>> /* This LACP frame is sending to the bonding port >>>>> * so pass it to rx_machine. >>>>> */ >>>>> rx_machine(internals, slave_id, &lacp->lacpdu); >>>>> + } else { >>>>> + char preferred_system_name[RTE_ETHER_ADDR_FMT_SIZE]; >>>>> + char self_system_name[RTE_ETHER_ADDR_FMT_SIZE]; >>>>> + rte_ether_format_addr(preferred_system_name, >>>>> + RTE_ETHER_ADDR_FMT_SIZE, >>>>> + &partner->port_params.system); >>>>> + rte_ether_format_addr(self_system_name, >>>>> + RTE_ETHER_ADDR_FMT_SIZE, &agg->actor.system); >>>>> + MODE4_DEBUG("preferred partner system %s not equal " >>>>> + "self system: %s\n", >>>>> + preferred_system_name, self_system_name); >>>>> } >>>>> rte_pktmbuf_free(lacp_pkt); >>>>> } else >>>>> >> >