From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f172.google.com (mail-wr0-f172.google.com [209.85.128.172]) by dpdk.org (Postfix) with ESMTP id 1B585DE0 for ; Mon, 13 Feb 2017 18:38:06 +0100 (CET) Received: by mail-wr0-f172.google.com with SMTP id k90so155098493wrc.3 for ; Mon, 13 Feb 2017 09:38:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=S5zDdHC+nxneGmKhS2qXQiwkbC7qz48OWm34zSeK6jw=; b=JNV+66wFZUx+e9zTvC346czav2FBSMlN5IWhpHHMo+ZAgW+IoRcmYVkoSwhcQQuHFL Hin66NjptXEwXaU84ErUb/7nF6U7dBdqxcGD/fFCwKd1S3fqjoNBG9FJdHpTVt9ABX7H ukNsjxcMGFLBArbRSJ0X2pqTXqDfIcJjEnv34Ww7yn/IYIIKyTX0+gISMKct7fMvaqT0 5TSd0+mvw8Ulhu8EOQSZVPMq3EDeN4Ao8QAerPWDvXC8GuvRW/r2racoTT0PEBAmbMzE 8FcGlIB9zI018qRS572zI2kyPglJojv3PNyzWP1fZgM9p0PINTJHMymj/xQ+/L9aENJs dlWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=S5zDdHC+nxneGmKhS2qXQiwkbC7qz48OWm34zSeK6jw=; b=Tp5KUshYYQGYLivZIMRuI3d4V7tx9t+lDc6evTeHIpo4qJdGP5jX8cwTkmWwTACDIS DFj4+cMLOcr0zRHVJJjDYdjFu4qjqZIeSCleL+5YMhGjhp8Jq1tDeQS13WocS5uFaU1J MhrrKgOz5iSAGvtwQEo09m2Da5zpvRUKN32Ns7L2SkjuVP+wbqzPKCw96GW4CmJeVm2y Fqcj3og9y6YOfRGAYUSamUONNIFBPeaNcUVhJL5sRvxDpW6AzHf+51/haANwxRcmWYjH 2X7kt/2hOflOr+xfIyc5idaJb22Hu2a9nDrV08uWlySVbE8IGNyatp3n+5crZ54I3/bi 3uTA== X-Gm-Message-State: AMke39mCzz+q5LuAKBN+vv74+p6RT+tViLQ9nwZpTUo7At28/VhlLz0qOqOdQKrQePfKSSRz X-Received: by 10.223.168.87 with SMTP id l81mr24123625wrc.194.1487007485862; Mon, 13 Feb 2017 09:38:05 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id g5sm14692594wrd.0.2017.02.13.09.38.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Feb 2017 09:38:05 -0800 (PST) From: Thomas Monjalon To: Ferruh Yigit Cc: "Dumitrescu, Cristian" , dev@dpdk.org, "Richardson, Bruce" , "Wiles, Keith" Date: Mon, 13 Feb 2017 18:38:04 +0100 Message-ID: <2103008.ubY7H1HT7g@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <3EB4FA525960D640B5BDFFD6A3D891265274BEE4@IRSMSX108.ger.corp.intel.com> <1593922.H4Bo57569h@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] doc: deprecation notice for ethdev ops? X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Feb 2017 17:38:06 -0000 2017-02-13 16:46, Ferruh Yigit: > On 2/13/2017 4:09 PM, Thomas Monjalon wrote: > > 2017-02-13 16:02, Dumitrescu, Cristian: > >> Hi Thomas, > >> > >> When a new member (function pointer) is added to struct eth_dev_ops (as the last member), does it need to go through ABI chance process (e.g. chance notice one release before)? > >> > >> IMO the answer is no: struct eth_dev_ops is marked as internal and its instances are only accessed through pointers, so the rte_eth_devices array should not be impacted by the ops structure expanding at its end. Unless there is something that I am missing? > > > > You are right, it is an internal struct. > > So no need of a deprecation notice. > > When dpdk compiled as dynamic library, application will load PMDs > dynamically as plugin. > Is this use case cause ABI compatibility issue? > > I think drivers <--> libraries interface can cause ABI breakages for > dynamic library case, although not sure how common use case this is. Yes it is a problem for drivers/library interface. It is not an ABI, which is an application/library interface.