From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9CED942428; Wed, 25 Jan 2023 13:51:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6193442D3E; Wed, 25 Jan 2023 13:51:44 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 580ED42D31 for ; Wed, 25 Jan 2023 13:51:42 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id CC43C5C004D; Wed, 25 Jan 2023 07:51:39 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 25 Jan 2023 07:51:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1674651099; x= 1674737499; bh=3BlIE4rF7cBq6ZODzpnioyfaVzQAMhUlDl2mg2ybVJ4=; b=m PnH3DWKs0Acrfcs/z/P0/VylM4zGrXC/6G2A2YdHZma4OSPacLk3dBk+KVzTQTI3 6Aqjr79XxwdcUPiD3Lbu5OLQuEK2Ynyhd7wxxJ6AabjJm/voKd2N67XKQMXcBnfT yY6fgbfm6DoczAkCllaackxNdMBi0qEW/hcDR3+3fvm516JlXDzijxwLxfT4HDh1 tEWsdFTzSCuSmHoCGk7zFFXfTT2M9VgskJQS71/1EKmbRwPNKG0obrpoRuisST4O I8j7cLUnexeDQ/I3oFIEv1v4v4uRDqDsWOqk0AAq7VG6JJw9CzSPZ1EyXYlHU+I4 SCkJomr1ssTtoHLhXFtiw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1674651099; x= 1674737499; bh=3BlIE4rF7cBq6ZODzpnioyfaVzQAMhUlDl2mg2ybVJ4=; b=P +a83UNAhmh473nIU0+hRgOoDoHpwJ2JiGWQ9xOToMukmWoWnAuDt7J7IpGs7M2ee nbn843yVmaantejhDSgt5xdSQmEKedXb7cHbvbbubUhzhE/JIq5lQ7ABa8T0ikHL iQD+8QkIogdqC64RnxCy+/oNxIoFwTrO0MtkuDkgKXwJwS6e9XpE1Gc8pcgUuuly MfIkQOPbK1SqedT66EJEcoiGsInKdEabmc9nRh6oJdM0KyWsk3xbsSQUKrvYjUjy R5uvfcMglMo+thbioydluLhbw9mAMaVawSn0hOmb1Rjx2zF3KwPKQSqxuBHzQdc8 L5YzIWzFDa0WARCnsLP+A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddvvddggeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 25 Jan 2023 07:51:38 -0500 (EST) From: Thomas Monjalon To: Hanumanth Reddy Pothula Cc: Aman Singh , Yuying Zhang , "dev@dpdk.org" , "andrew.rybchenko@oktetlabs.ru" , "viacheslavo@nvidia.com" , Jerin Jacob Kollanukkaran , Nithin Kumar Dabilpuram , "david.marchand@redhat.com" Subject: Re: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation Date: Wed, 25 Jan 2023 13:51:37 +0100 Message-ID: <2105532.ucjEoNaZvj@thomas> In-Reply-To: References: <20221220200250.2413443-1-hpothula@marvell.com> <2415589.KiezcSG77Q@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 19/01/2023 11:33, Hanumanth Reddy Pothula: > From: Thomas Monjalon > > 21/12/2022 03:07, Hanumanth Pothula: > > > Presently, Rx metadata is sent to PMD by default, leading to a > > > performance drop as processing for the same in Rx path takes extra > > > cycles. > > > > > > Hence, add new testpmd command, > > > 'enable port nic_to_pmd_rx_metadata' > > > > > > This command helps in sending Rx metadata to PMD and thereby Rx > > > metadata flow command requests are processed. > > > > > > Signed-off-by: Hanumanth Pothula > > > > As said in previous versions, please don't add such option in testpmd. > > The problem is somewhere else, probably in your driver. > > You should make sure your driver is not sending metadata if not needed. > > By the way you didn't reply to the last comments on v3 in December. > > > I added following comment on V4, > - As per spec rte_eth_rx_metadata_negotiate() is processed only > when dev_configured is set. Not exactly. It is said " Invoke this API before the first rte_eth_dev_configure() invocation to let the PMD make preparations that are inconvenient to do later. " > Hence can't enable(Rx metadata negotiation) > automatically when a flow command requests metadata. This sentence does not make any sense. First you negotiate to prepare the feature. Later you enable per flow. > - Add new testpmd command to allow NIC to PMD Rx metadata negotiation. > > As we can't enable Rx metadata negotiation on fly, > introduced new testpmd command to enable Rx metadata negotiation > by resetting the ports. You can enable on the fly. Fix your driver.