From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by dpdk.org (Postfix) with ESMTP id ACA741BB91; Fri, 19 Apr 2019 12:26:50 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 32E8358E; Fri, 19 Apr 2019 06:26:49 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 19 Apr 2019 06:26:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Fkp63ozjDmnWismu+1DONoNUbjPEGeIqr9axTFiMHsY=; b=TNTPvv+ESJGm rmInWRxZZtfZbMBVgDEBMHG+W8uLbRPTj72nCCBoS94n0ZUi8lWvdKzgO3FCsAiY LpA9lHN+jJFfIgnZPWYkD9BNx9s8UrO4CfUh36Hbyx1Orb9hpOI7el43GW1Ld+GL CySgtq8Rz/qw8Ys+jDjPRg9KLBBgJs0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Fkp63ozjDmnWismu+1DONoNUbjPEGeIqr9axTFiMH sY=; b=U+7GOVfRta3NLAiXjQ8VCyFd2X6OA8W+UAFrRQocZtJaocbNxzwGYFlPv Xb+J9PH1nUTcA3YkuMtNa318Ruci1XSXOONoD/wmIy/ZnQjYYNiBy/73j6V13qnP qK0Wb9t6APRCEAlzqagki8JSJK4bZukrkIN77aFs/vMP6idCvfE0GWhJ5D3oM1Se 379YZU0qTf66uFgFahFnb6nfSQr0ImTiCea4Q9+KqvJsyI17Nc6ndj0uzSP+sKK+ qMQmvU8VpYuDba6Gfei/qd+LH1hQp6u1X+VNovwJlAOlDNsJrbVm7KbCbti9msrB 2PfWbwZEW5QptDjc0GlKTUJASHVsA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrfeejgddviecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 957C7103C9; Fri, 19 Apr 2019 06:26:47 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: stable@dpdk.org, Rami Rosen , Ferruh Yigit , dev Date: Fri, 19 Apr 2019 12:26:46 +0200 Message-ID: <2106587.LJE47Oa69J@xps> In-Reply-To: References: <20190408142226.88179-1-ferruh.yigit@intel.com> <20190408200035.GA1146@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] kni: fix build for ndo_fdb_add in Linux 5.1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Apr 2019 10:26:51 -0000 09/04/2019 19:59, Rami Rosen: > On Mon, Apr 08, 2019 at 03:22:26PM +0100, Ferruh Yigit wrote: > > Build error seen with Linux kernel 5.1 and > > when CONFIG_RTE_KNI_KMOD_ETHTOOL is enabled. > > > > Build error: > > .../dpdk/build/build/kernel/linux/kni/igb_main.c:2352:18: > > error: initialization of ... from incompatible pointer type ... > > [-Werror=incompatible-pointer-types] > > .ndo_fdb_add = igb_ndo_fdb_add, > > ^~~~~~~~~~~~~~~ > > > > ndo_fdb_add() is changed in Linux kernel version 5.1 and now requires > > a new parameter, 'struct netlink_ext_ack *extack': > > Linux Commit 87b0984ebfab ("net: Add extack argument to ndo_fdb_add()") > > > > ndo_fdb_add() parameter updated with compile time Linux kernel version > > check. > > > > Cc: stable@dpdk.org > > > > Signed-off-by: Ferruh Yigit > > --- > Tested-by: Bruce Richardson > > Thanks. > Checked build with CONFIG_RTE_KNI_KMOD_ETHTOOL=y > after applying the patch, build was done against the bleeding edge of > net-next of today (kernel 5.1-rc4). > Build of the kni kernel module completed successfully. > > Reviewed-by: Rami Rosen Applied, thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id BD0BAA00E6 for ; Fri, 19 Apr 2019 12:26:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AF7CE1BBD0; Fri, 19 Apr 2019 12:26:51 +0200 (CEST) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by dpdk.org (Postfix) with ESMTP id ACA741BB91; Fri, 19 Apr 2019 12:26:50 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 32E8358E; Fri, 19 Apr 2019 06:26:49 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 19 Apr 2019 06:26:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Fkp63ozjDmnWismu+1DONoNUbjPEGeIqr9axTFiMHsY=; b=TNTPvv+ESJGm rmInWRxZZtfZbMBVgDEBMHG+W8uLbRPTj72nCCBoS94n0ZUi8lWvdKzgO3FCsAiY LpA9lHN+jJFfIgnZPWYkD9BNx9s8UrO4CfUh36Hbyx1Orb9hpOI7el43GW1Ld+GL CySgtq8Rz/qw8Ys+jDjPRg9KLBBgJs0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Fkp63ozjDmnWismu+1DONoNUbjPEGeIqr9axTFiMH sY=; b=U+7GOVfRta3NLAiXjQ8VCyFd2X6OA8W+UAFrRQocZtJaocbNxzwGYFlPv Xb+J9PH1nUTcA3YkuMtNa318Ruci1XSXOONoD/wmIy/ZnQjYYNiBy/73j6V13qnP qK0Wb9t6APRCEAlzqagki8JSJK4bZukrkIN77aFs/vMP6idCvfE0GWhJ5D3oM1Se 379YZU0qTf66uFgFahFnb6nfSQr0ImTiCea4Q9+KqvJsyI17Nc6ndj0uzSP+sKK+ qMQmvU8VpYuDba6Gfei/qd+LH1hQp6u1X+VNovwJlAOlDNsJrbVm7KbCbti9msrB 2PfWbwZEW5QptDjc0GlKTUJASHVsA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrfeejgddviecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 957C7103C9; Fri, 19 Apr 2019 06:26:47 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: stable@dpdk.org, Rami Rosen , Ferruh Yigit , dev Date: Fri, 19 Apr 2019 12:26:46 +0200 Message-ID: <2106587.LJE47Oa69J@xps> In-Reply-To: References: <20190408142226.88179-1-ferruh.yigit@intel.com> <20190408200035.GA1146@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] kni: fix build for ndo_fdb_add in Linux 5.1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190419102646.UVy-Z6kGkwy2O3731aFQddr-c1tV_eBGKnNVsEJsvrs@z> 09/04/2019 19:59, Rami Rosen: > On Mon, Apr 08, 2019 at 03:22:26PM +0100, Ferruh Yigit wrote: > > Build error seen with Linux kernel 5.1 and > > when CONFIG_RTE_KNI_KMOD_ETHTOOL is enabled. > > > > Build error: > > .../dpdk/build/build/kernel/linux/kni/igb_main.c:2352:18: > > error: initialization of ... from incompatible pointer type ... > > [-Werror=incompatible-pointer-types] > > .ndo_fdb_add = igb_ndo_fdb_add, > > ^~~~~~~~~~~~~~~ > > > > ndo_fdb_add() is changed in Linux kernel version 5.1 and now requires > > a new parameter, 'struct netlink_ext_ack *extack': > > Linux Commit 87b0984ebfab ("net: Add extack argument to ndo_fdb_add()") > > > > ndo_fdb_add() parameter updated with compile time Linux kernel version > > check. > > > > Cc: stable@dpdk.org > > > > Signed-off-by: Ferruh Yigit > > --- > Tested-by: Bruce Richardson > > Thanks. > Checked build with CONFIG_RTE_KNI_KMOD_ETHTOOL=y > after applying the patch, build was done against the bleeding edge of > net-next of today (kernel 5.1-rc4). > Build of the kni kernel module completed successfully. > > Reviewed-by: Rami Rosen Applied, thanks