DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: bruce.richardson@intel.com, dev@dpdk.org,
	david.marchand@redhat.com, Jerin Jacob <jerinj@marvell.com>,
	Gavin Hu <gavin.hu@arm.com>,
	Jan Viktorin <viktorin@rehivetech.com>,
	Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
	Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Subject: Re: [dpdk-dev] [PATCH] eal: fix compiler detection in public headers
Date: Wed, 18 Mar 2020 00:58:28 +0100	[thread overview]
Message-ID: <2108133.o7ts2hSHzF@xps> (raw)
In-Reply-To: <20200317100940.726df3a2@Sovereign>

17/03/2020 08:09, Dmitry Kozlyuk:
> > > This case is now better fixed with a patch removing EAL dependencies
> > > from the PCI library, which drops rte_common.h inclusion from pmdinfogen:
> > >     http://patches.dpdk.org/patch/66701/  
> > 
> > Actually rte_common.h is directly included by buildtools/pmdinfogen/pmdinfogen.c
> > so we need this patch in my opinion.
> > 
> > > As a consequence, I send this EAL patch just in case we need it
> > > in future. We can decide to apply or leave it.  
> > 
> > This patch is now gating acceptance of MinGW support.
> 
> Applied on top of this patch, MinGW patchset builds OK:
> 
> * by host Clang and target GCC on Linux,
> * by host Clang and target MinGW on Linux,
> * by Clang on Windows,
> * and by MinGW on Windows.
> 
> Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>

Applied



      reply	other threads:[~2020-03-17 23:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-16 12:04 Thomas Monjalon
2020-03-16 14:25 ` Thomas Monjalon
2020-03-17  7:09   ` Dmitry Kozlyuk
2020-03-17 23:58     ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2108133.o7ts2hSHzF@xps \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=gavin.hu@arm.com \
    --cc=jerinj@marvell.com \
    --cc=viktorin@rehivetech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).