From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A1AF0A056A; Wed, 18 Mar 2020 00:58:38 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 704BF1C0CB; Wed, 18 Mar 2020 00:58:37 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 4D14C1BF98 for ; Wed, 18 Mar 2020 00:58:35 +0100 (CET) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id A7D925C0282; Tue, 17 Mar 2020 19:58:32 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 17 Mar 2020 19:58:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=e0//nTYLNEu3Abhn7c//RTSwSP5725kjEE/hg0mVDEY=; b=ZgnJRK8SwH99 zxs8HmhRWfKaaYzf0V4sZ2/muK2CLkCAsUC69cFQQWoTIPhapTV8HNTe2MmFjR19 kJ9zGvy5SGJTgxybE4DJwH80u0qqW8WUDtQEZO3L3WbKvfoliWvwMnFkIaLQhgOH NTO6aKefI8PdTAefc6TAAl8PLSXa0kY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=e0//nTYLNEu3Abhn7c//RTSwSP5725kjEE/hg0mVD EY=; b=cqugFrlK5uQMSUbIC8FuaY0qxa3aEEg5r/ms8hVqQ3d6qqDzRXdk28W/p sCeqyPsyEhEjj/xMQ7OS5kt9fiwZZZ4zlNyYKwQmx3ck8Qyti/YJcy3qTunBZpBt lKJ8qobgnt3Jp5fxdSWwqaN9/C7fuElPiDRhP4Mk+q6AGi2plAg3D/gK3IiqY1yW GoCdPpXHi5mUzgUZvkV64h/0poOrjgqqRGp+bux9Z7/vFHD/+8Biz3r9RPxsS0fV lVwxCp3wI3ZUss6OWX9rqh555SK23aYD9VuaFnGW3dEEhUU+Wdm0jaKia54ziT0R 0a5ZSf6vSADrN+KnS3ruMI4dpcR0Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudefiedgudegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrddvtdefrddukeegnecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrg hssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4D72F3061CB6; Tue, 17 Mar 2020 19:58:30 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: bruce.richardson@intel.com, dev@dpdk.org, david.marchand@redhat.com, Jerin Jacob , Gavin Hu , Jan Viktorin , Cristian Dumitrescu , Dmitry Kozlyuk Date: Wed, 18 Mar 2020 00:58:28 +0100 Message-ID: <2108133.o7ts2hSHzF@xps> In-Reply-To: <20200317100940.726df3a2@Sovereign> References: <20200316120454.933575-1-thomas@monjalon.net> <4502147.F8r316W7xa@xps> <20200317100940.726df3a2@Sovereign> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: fix compiler detection in public headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 17/03/2020 08:09, Dmitry Kozlyuk: > > > This case is now better fixed with a patch removing EAL dependencies > > > from the PCI library, which drops rte_common.h inclusion from pmdinfogen: > > > http://patches.dpdk.org/patch/66701/ > > > > Actually rte_common.h is directly included by buildtools/pmdinfogen/pmdinfogen.c > > so we need this patch in my opinion. > > > > > As a consequence, I send this EAL patch just in case we need it > > > in future. We can decide to apply or leave it. > > > > This patch is now gating acceptance of MinGW support. > > Applied on top of this patch, MinGW patchset builds OK: > > * by host Clang and target GCC on Linux, > * by host Clang and target MinGW on Linux, > * by Clang on Windows, > * and by MinGW on Windows. > > Acked-by: Dmitry Kozlyuk Applied