From: Thomas Monjalon <thomas@monjalon.net>
To: Zhiyong Yang <zhiyong.yang@intel.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] bus/pci: fix wrong intr_handle.type with uio_pci_generic
Date: Fri, 29 Dec 2017 12:07:08 +0100 [thread overview]
Message-ID: <2110508.9oViqIghhz@xps> (raw)
In-Reply-To: <20171229075511.33180-1-zhiyong.yang@intel.com>
29/12/2017 08:55, Zhiyong Yang:
> For virtio legacy device, testpmd startup fails when using
> uio_pci_generic. The issue is caused by invoking the function
> pci_ioport_map. The right intr_handle.type is already set before
> calling it, we should avoid overwriting the default value "RTE_
> INTR_HANDLE_UNKNOWN" in it. Besides, the removal has no harm to
> other cases since it already is set to this value (0) at init.
To be more precise, it is set to 0 by a memset on the whole struct
during allocation in the scan function (pci_scan_one).
> --- a/drivers/bus/pci/linux/pci.c
> +++ b/drivers/bus/pci/linux/pci.c
> @@ -723,7 +723,6 @@ pci_ioport_map(struct rte_pci_device *dev, int bar __rte_unused,
> if (!found)
> return -1;
>
> - dev->intr_handle.type = RTE_INTR_HANDLE_UNKNOWN;
There is the same assignment in pci_vfio_map_resource_primary(),
pci_vfio_map_resource_secondary() and pci_uio_map_resource().
Please could you check why there is such assignments?
next prev parent reply other threads:[~2017-12-29 11:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-28 6:12 [dpdk-dev] [PATCH] " Zhiyong Yang
2017-12-28 9:05 ` Thomas Monjalon
2017-12-28 9:37 ` Yang, Zhiyong
2017-12-28 10:49 ` Thomas Monjalon
2017-12-29 2:10 ` Yang, Zhiyong
2017-12-29 7:55 ` [dpdk-dev] [PATCH v2] " Zhiyong Yang
2017-12-29 11:07 ` Thomas Monjalon [this message]
2017-12-30 14:19 ` Yang, Zhiyong
2018-01-03 3:29 ` Yang, Zhiyong
2018-01-09 15:34 ` Thomas Monjalon
2018-01-10 1:28 ` Yang, Zhiyong
2018-01-10 2:32 ` [dpdk-dev] [PATCH v3] " Zhiyong Yang
2018-01-12 0:04 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2110508.9oViqIghhz@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
--cc=zhiyong.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).