From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 917FF2B9E for ; Fri, 5 May 2017 17:59:32 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 31034208B2; Fri, 5 May 2017 11:59:32 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Fri, 05 May 2017 11:59:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=YBnw8C1gKgwPgFK s61uM/MfBoVkPqWE5Ly8IP/15U6Q=; b=ajRU5PgFvMNb6Uw1TYjAgbtktMcXsvc VvFp2+ozqUVinrvI9CRmY956APAGyAKoMSo2foIChIqF/GXivNWuExVO1FyFQLn+ eNgrDAJIaDLv3QBRxgTlm/LjPg3PaVcz/zlPBB33YOPK8+J9wIaF86diTmaePlZt ilYcEYzv86UA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=YBnw8C1gKgwPgFKs61uM/MfBoVkPqWE5Ly8IP/15U6Q=; b=CxzmkB5J sMYjYuUBRHwmpVVL/xNAcgi/t99bsb6Mnsae6Fn8enV1BL9RkP+b2AkEwXK08U6Y iHf9oPcmcbLeZGEVm0z3ubp0g/ZL5MZ1an1gbVdvCFyt89e8eBa5NRF0nduTcLVN N1hF4InqHViMyChMKwZcUKJHWPJTj5kblbGey8suiAwIdr0GVBKQMev5vQ4dXTXA LnBR5HKy/4yDcRcEE/t2utz+pK6/nRv/3MVFwP3FQu4FoXPG7EcDUQC6fS8XKFLr Gm+hWk1xh5EmDODp1CEJK/+eP9MNDqOhTq/5qGGyEJfIW+kzg2gOVkchg7o7CTxh 4dWcahBkTtK9Og== X-ME-Sender: X-Sasl-enc: ZxQBSyW7PTZ+MIoGHGUiVhHB2tZJ4VkUVhzfd74X88fO 1493999971 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D59392418B; Fri, 5 May 2017 11:59:31 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, "John W. Linville" , Chas Williams Date: Fri, 05 May 2017 17:59:30 +0200 Message-ID: <2111180.fiu7QRScOO@xps> In-Reply-To: <20170504111659.17670-1-ferruh.yigit@intel.com> References: <20170504111659.17670-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/af_packet: prefer snprintf against strncpy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 May 2017 15:59:32 -0000 04/05/2017 13:16, Ferruh Yigit: > strncpy may left destination buffer not NULL terminated, switched using > snprintf to be sure destination buffer is NULL terminated. > > Coverity issue: 1407495 > Coverity issue: 1407498 > Fixes: cc68ac4847bc ("net/af_packet: support MTU change") > Fixes: 218259590ea4 ("net/af_packet: support promiscuous") > > Signed-off-by: Ferruh Yigit Applied, thanks