From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A760A0555; Fri, 3 Jun 2022 09:44:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 67D0740691; Fri, 3 Jun 2022 09:44:05 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id 332B94021E for ; Fri, 3 Jun 2022 09:44:04 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 8869A3200437; Fri, 3 Jun 2022 03:44:01 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Fri, 03 Jun 2022 03:44:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1654242241; x= 1654328641; bh=NXJBzzpY+OrET77hBQNs0tTFL7BPW6o2wV64qH3Xq3Y=; b=a 0qv0pEAnF+YmvZo4dhwWpxVzRhrii+CMvD93hvmOYLsbJL1+FCyKtSpJfJdT2lXe I1z+In4Pzay1yYIlla0K9zlj/GPelqDfPYng9DUlHDuHJB8ziCraw5Q+simd7bJ2 Jh/RU3pMn4bsjbMQt7qgfljTKui0yVzWqxr5NNgyjJ43n2spOimCCWMYZ+CmnMDK zPDJ4NlhDYCvh8vL5NMoWDTjDx3Oosb2eYJpmfGHNGjO7j+dd47FKbHuONPZkCKX AVJWQOnN7No2/3bp/nIHad+zSDm/GLpsNt3fF2hM1uza468crKHVENn/iJqL8V2g tar7sYaE19LqrrBiBPG1A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1654242241; x= 1654328641; bh=NXJBzzpY+OrET77hBQNs0tTFL7BPW6o2wV64qH3Xq3Y=; b=j iM6tzgPLovE8II81UTGog0P+9OfgHmlf6eG7aQvMs9riOV7/vsa63SZIIZsddscQ riAOyjIfczfsCuAjhifjo4keR/pW/eucf6PKEDxdaYhY5yifUu2QnC0Jm3zUIZkb prPdzv7EPmL67/tZO/TGvFF3J5Gp38rdaZ+alv64+s39o6aOYRbF6bs5WPBX92wf LP7+fRLUVDhVXhGH8R5tyK/bO8qsXDM5kQ/4s0XzbnfaxEgUoS5izqdiEErqNFDE RORK0RGpF/frSL2fptQlISXBpOSjP7i0QXzkAhYdAp/rnQyWhTVcF/yrrz4Fb/ma Wf/1EKKOZVdh0jpmBsbRQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrleehgdduvdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 3 Jun 2022 03:43:59 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: Stanislaw Kardach , Stephen Hemminger , Vladimir Medvedkin , dev@dpdk.org, Frank Zhao , Sam Grove , upstream@semihalf.com Subject: Re: [PATCH v4 1/2] lpm: add const to lpm arg of rte_lpm_lookup Date: Fri, 03 Jun 2022 09:43:57 +0200 Message-ID: <2111317.Mh6RI2rZIc@thomas> In-Reply-To: References: <20220601111542.401360-1-kda@semihalf.com> <1821120.CQOukoFCf9@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 03/06/2022 09:29, Bruce Richardson: > On Thu, Jun 02, 2022 at 10:52:25PM +0200, Thomas Monjalon wrote: > > 01/06/2022 13:15, Stanislaw Kardach: > > > All other rte_lpm_lookup* functions take lpm argument as a const. As the > > > basic rte_lpm_lookup() performs the same function, it should also do > > > that. > > > > > > As this function is inline, no API/ABI change happens. > > > > It is an API change and should be noted in the release notes. > > > > > static inline int > > > -rte_lpm_lookup(struct rte_lpm *lpm, uint32_t ip, uint32_t *next_hop) > > > +rte_lpm_lookup(const struct rte_lpm *lpm, uint32_t ip, uint32_t *next_hop) > > > While I've no particular objection to it appearing in the RN doc, I wonder > whether it really counts as an API change. I can't see any practical > difference that this change would make to the end user - no source code > needs updating for example. Yes you're right, we can skip the release notes here.