From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com
 [209.85.212.171]) by dpdk.org (Postfix) with ESMTP id 7F0C268A8
 for <dev@dpdk.org>; Wed, 21 May 2014 15:46:49 +0200 (CEST)
Received: by mail-wi0-f171.google.com with SMTP id cc10so5061113wib.16
 for <dev@dpdk.org>; Wed, 21 May 2014 06:46:59 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=kteMdp4PY+8gFSO1waCsY3vtlEvWEUbtF/+503P0YIw=;
 b=jyrhapnVEE/qRu9hTBkHep+7tFyItv9PDUZK/fznYgPAYybFCMHSYRNp4ODjWOcmO9
 OgGYcjLdUgyT5qhNB0qd/QDgJKZMI4cKmt/Z+9V/A9VPSSHGGDG2FYguVl/eX2p8GrwD
 DvQFJzr8f5hXzxJtyTW7tZ4sLt++FvLFzw5b9eNpDyjDpJPFlkiswY/kkm9YBldS4tT5
 VPvVEm2gDgPtrmKy0LWxMHD/QYAk9177Deb//u1MV02IMIH3howzo3wV+KNPG6pvFbNG
 5M5wKdUYutdEbqZKUaqb305ThkM39pYGp/Y8l5im7/VMgUcI2+pUOOoJ55v9ynQm3gwB
 l9IA==
X-Gm-Message-State: ALoCoQnSaTWhR8etzvosi7+DKTS6ZRzlKblZmp4Ml9cbpowjQ3Kwvwo0FsDJH0vMnHs9Ap7/Diua
X-Received: by 10.180.212.107 with SMTP id nj11mr10726592wic.40.1400680018915; 
 Wed, 21 May 2014 06:46:58 -0700 (PDT)
Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237])
 by mx.google.com with ESMTPSA id p18sm2421625wik.3.2014.05.21.06.46.56
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 21 May 2014 06:46:58 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Date: Wed, 21 May 2014 15:46:54 +0200
Message-ID: <2113546.l6ZKBghbYd@xps13>
Organization: 6WIND
User-Agent: KMail/4.13 (Linux/3.14.4-1-ARCH; KDE/4.13.0; x86_64; ; )
In-Reply-To: <1400514709-24087-6-git-send-email-anatoly.burakov@intel.com>
References: <C6ECDF3AB251BE4894318F4E45123697592AA9BE@IRSMSX101.ger.corp.intel.com>
 <1400514709-24087-6-git-send-email-anatoly.burakov@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 05/16] Moved interrupt type out of igb_uio
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 21 May 2014 13:46:49 -0000

Few more comments from checkpatch.pl on this patch:

ERROR: else should follow close brace '}'
#252: FILE: lib/librte_eal/linuxapp/igb_uio/igb_uio.c:225:
 	}
+	else if (udev->mode == RTE_INTR_MODE_LEGACY) {

WARNING: suspect code indent for conditional statements (8, 8)
#316: FILE: lib/librte_eal/linuxapp/igb_uio/igb_uio.c:590:
 	if (((struct rte_uio_pci_dev *)info->priv)->mode ==
[...]
+	pci_disable_msix(dev);

-- 
Thomas