From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E7B054249E; Fri, 27 Jan 2023 10:26:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9C43540150; Fri, 27 Jan 2023 10:26:56 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 6FFA740146 for ; Fri, 27 Jan 2023 10:26:55 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id F09F85C0170; Fri, 27 Jan 2023 04:26:53 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Fri, 27 Jan 2023 04:26:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1674811613; x= 1674898013; bh=+9I0p9Y23CTC43EppTKZWF0amVQrlnQ2Fhp//OqSQ4E=; b=S 1M0fRtywT1ckE9KR7EF5PhxECeaK4ml1HK0uOIetj1gVwsZqoqyuaQD7S5Rqyks9 SNq8A1PXeXtOKqPpEnh+T77/n2QU3r5N6HsRHY674VWWNKHbgi6fvlx0KFTs66LA KwpTdbsSygyqQ7j63+jx3dqS/Hod5wTGZmjO+0tbJ+zbc8mA/tOG90nUku8BpXLj SW1WJwZreygVyJ+ZFgbNdAEOTeNqjzMa7fh26R88PP3YNPk8hoqY+dkh1H2RH/Qp UQdjJ1yUzGvTtt2rHVKRGXvgbx0kuYwpyGshDv7IVpbsZcvr+xC394D+hgT1Xx3U 12a5KT/VndZLt5734sCSw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1674811613; x= 1674898013; bh=+9I0p9Y23CTC43EppTKZWF0amVQrlnQ2Fhp//OqSQ4E=; b=L wY1y9xzUjOgM6MtRdiPKzX46myGV77QfuYCiGhcNBGX506WLUa2+j0fevPzKjqXc 5UsF3R0Xvd24KVVrxoKms78KkOV/4k2Y6G3ipqP9iFcZFROa0/Xlg5JvpvZ4xNbb TiAhFh/UAwOw0P4+qQ9ZZiQQ5lPUGJW+BH98e9v0kVIN430W6P0O/FUNB5GOLE57 i4z6Byv9zczgp7DhR31Ga1MH0dxdhJp5WXCltqJ+5Ue/YPILIv+x8ZL6GvMBYECL PxP7pqCUwbliMKZ/ZgPSjkNe/DvDekBmNrG5fZCOZz7fSg+xAN4RQ67sjd4IcT9k v3vWugdl7wNSP/C/mDZuA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddviedgtdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 27 Jan 2023 04:26:52 -0500 (EST) From: Thomas Monjalon To: Jerin Jacob Cc: Shivah Shankar Shankar Narayan Rao , Srikanth Yalavarthi , "dev@dpdk.org" , Jerin Jacob Kollanukkaran , Anup Prabhu , "ferruh.yigit@amd.com" , "bruce.richardson@intel.com" , "david.marchand@redhat.com" Subject: Re: [EXT] Re: [PATCH v3 0/4] implementation of ML common code Date: Fri, 27 Jan 2023 10:26:51 +0100 Message-ID: <2113604.MHSsGVy7CF@thomas> In-Reply-To: References: <20221212172108.17993-1-syalavarthi@marvell.com> <2166662.Bm8zEkEi59@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 27/01/2023 10:02, Jerin Jacob: > On Fri, Jan 27, 2023 at 2:20 PM Thomas Monjalon wrote: > > 27/01/2023 07:40, Jerin Jacob: > > > On Thu, Jan 26, 2023 at 4:27 PM Thomas Monjalon wrote: > > > > 25/01/2023 15:59, Srikanth Yalavarthi: > > > > > From: Thomas Monjalon > > > > > > 25/01/2023 14:25, Srikanth Yalavarthi: > > > > > > > From: Thomas Monjalon > > > > > > > > 20/12/2022 18:52, Srikanth Yalavarthi: > > > > > > > > > This patch series implements the common ML code that can be used > > > > > > > > > by ML drivers. Common code include functions to convert ML IO type > > > > > > > > > to string, IO format type to string, function get size of ML IO > > > > > > > > > type, and functions for converting data types from higher > > > > > > > > > precision to lower precision and vice-versa. > > > > > > > > > > > > > > > > I'm not sure about the path of this code. > > > > > > > > In general we implement drivers helper in the same directory as the > > > > > > > > driver and mark it as internal. > > > > > > > > Would it work here? > > > > > > > > > > > > > > We are planning to implement two different ML drivers, ml/cnxk driver > > > > > > (submitted for review) and a software only driver (part of ML roadmap and > > > > > > currently WIP). Both the drivers would be using these common functions for > > > > > > quantization and dequantization. Hence, placed the files in common/ml > > > > > > directory. > > > > > > > > > > > > > > Moreover, these functions are used to convert data from higher to lower > > > > > > precision or vice-versa and can also be used by future ML drivers for other > > > > > > platforms. > > > > > > > > > > > > I understand, and what you say does not contradict with having this code in > > > > > > lib/mldev/. > > > > > > So would you agree to move? > > > > > > > > > > These common functions do not have an rte_ml_dev_ prefix. > > > > > > > > As it is exported, it should have rte_ prefix. > > > > > > The exposed functions are similar to lib/ethdev/sff_* where multiple > > > driver can "use" it > > > but not by application directly. > > > If so, What is the recommendation > > > a) Keeping driver/common/ml without rte_prefix > > > b) Keeping in lib/mldev/ with rte_mldev_pmd_ prefix? > > > > > > I prefer (a) as it will not pollute lib/mldev. No strong opinion, > > > either. Let me know your view or any other suggestion? > > > > I don't see it as pollution, it comes with the library, > > so I prefer lib/mldev/ with rte_mldev_pmd_ prefix. > > > > > > > > Is it ok to have non-RTE code in lib/mldev. If yes, we can move to lib/mldev. > > > > > > > > Look at lib/ethdev/ethdev_driver.h, it should be similar. > > > > > > Here scope is different. See above. > > > > No the scope is not different. > > They are functions used by drivers not by application. > > When you say lib/ethdev/ethdev_driver.h. You mean "struct eth_dev_ops" scheme. No I don't mean that. Did you check the internal functions in this file? I mean functions like rte_eth_dev_allocate() or rte_eth_dev_attach_secondary().