From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B4882A04B6; Mon, 12 Oct 2020 23:37:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E4A5E1D909; Mon, 12 Oct 2020 23:37:17 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by dpdk.org (Postfix) with ESMTP id 88CB51D8F6 for ; Mon, 12 Oct 2020 23:37:14 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id D4AC1132C; Mon, 12 Oct 2020 17:37:09 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 12 Oct 2020 17:37:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= 64vw0qiWad7ybmeF+f6boaqUcsjUK99b2fKz2D0XZXc=; b=dCo0+Y5YRybsB0Wb 0111GknSMzyYqIK2Xf6IhtIs1LPOr2C3L73vtb3qF1a90AwwMHSF0BKmCxIlgzi/ Kx9wv7E7n5/2DyEji2+QUkn9TzybxaH9/H3VC88YA/wOQ32vBNaWWVfv+3//BXev 3t0Hr0Q25m5sYBz6EtJG4eStkOZKN8+njk3MZIPviTJSfPPQ1Zl7sKMzJej27V4Q Tg5RA6FsNN5RIY53o/JGWdylxWjljMX7HHQ9QVoBrv4Ly/OjJsVzYQejlEE09Jab xLWeRCw7ibTa75OZPPnjkrFu4XlUOpSkH6JOQ+wBkjKSvHupnBvKS+7TNKa/dbk6 CmywzA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=64vw0qiWad7ybmeF+f6boaqUcsjUK99b2fKz2D0XZ Xc=; b=EyESVTOS6WcG9sK8ih8TMwswMciVhxpkh+bBeyQjfyowM1zeQVHcbzZpV NTZi4YsmoEoO7KjKYFpxinMjb3gPwfiiKKapY0iLgwgb7JuQvhpcbw8+fpzQuwq5 qYOgrPtYhZS8IV4s7BgZe8Cz0BvcazHh4ppo4M5mKBBHN7FiHdBVupSmCsr37+lB XG4EpNRWiS33Yv/CPfwk0WuEDLbbP2ZZjjAKq3KbCGv/Pnmxjfqxy/13urykV+T1 pcSaUi2yGYBS7S2mXjNsSOSEsuwEZ7oRD4v2vUDZ3MEfXpvhBB7qgi10+nqbmFss re7pqGO+shhpCllJdyBJ6c7YCSDFg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrheekgddtudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3B0623280059; Mon, 12 Oct 2020 17:37:07 -0400 (EDT) From: Thomas Monjalon To: Bing Zhao Cc: orika@nvidia.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, mdr@ashroe.eu, nhorman@tuxdriver.com, bernard.iremonger@intel.com, beilei.xing@intel.com, wenzhuo.lu@intel.com, dev@dpdk.org Date: Mon, 12 Oct 2020 23:37:06 +0200 Message-ID: <2115353.iQtFZFVSCL@thomas> In-Reply-To: <1602158717-32038-3-git-send-email-bingz@nvidia.com> References: <1602147098-9768-1-git-send-email-bingz@nvidia.com> <1602158717-32038-1-git-send-email-bingz@nvidia.com> <1602158717-32038-3-git-send-email-bingz@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 2/6] ethdev: add new attributes to hairpin config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/10/2020 14:05, Bing Zhao: > struct rte_eth_hairpin_conf { > - uint16_t peer_count; /**< The number of peers. */ > + uint32_t peer_count:16; /**< The number of peers. */ Why not keeping uint16_t? > + uint32_t tx_explicit:1; /**< Explicit TX flow rule mode. */ > + uint32_t manual_bind:1; /**< Manually bind hairpin queues. */ Please describe more the expectations of these bits: What is changed at ethdev or PMD level? What the application is supposed to do? Why choosing one mode or the other?