From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com
 [209.85.212.180]) by dpdk.org (Postfix) with ESMTP id B7A3E8D3C
 for <dev@dpdk.org>; Fri, 25 Sep 2015 12:12:17 +0200 (CEST)
Received: by wiclk2 with SMTP id lk2so15296106wic.0
 for <dev@dpdk.org>; Fri, 25 Sep 2015 03:12:17 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=+69z7BIB/QAtff+nUUoFVmodhktizo/F1QCJa/RMZwk=;
 b=hXslwXEP9ZZBkUs0XzAsT4sZSzYTVv7FkjpDgHlO8Md3UrIRPCFgMQg313CiQZwrkN
 k6ykYu2CJsi50iLI+/y+zGPWjEvz+lZoOd3bZ3pT1jKagc7Zk7M0Ri4KB/P6+i/PiCdA
 CdxPUZufzntHEKxIgG9CxUcSI05A/S6aUFdXUSM/W5VLX3MyHrj29m1PaF/ddXBs5uP6
 ULYsVwKEEYuuFChiX1skPkUujtrOy4Jyhsgy9jhpLsm4DR9BxaOMPPYWStn7D1qJYIOQ
 Ub+3rF6oThYaJhNfps520FQsN0skRIhB3dBNzxXTDSJNKn036aDjS96OUcTCe6JXeHIl
 FT3Q==
X-Gm-Message-State: ALoCoQkV0esCe9UCBIK4LMVK9hASgGBqHp6gakEl4uAPQ2u/dnYyV5sN9y9NvLGOLnqLuOWXvEvM
X-Received: by 10.194.88.74 with SMTP id be10mr4958012wjb.67.1443175937471;
 Fri, 25 Sep 2015 03:12:17 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by smtp.gmail.com with ESMTPSA id ht5sm2496035wib.10.2015.09.25.03.12.16
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 25 Sep 2015 03:12:16 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Tomasz Kulasek <tomaszx.kulasek@intel.com>
Date: Fri, 25 Sep 2015 12:11:10 +0200
Message-ID: <2117107.CAUBaR2rrA@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <1436981189-3320-6-git-send-email-tomaszx.kulasek@intel.com>
References: <1435589444-1988-1-git-send-email-tomaszx.kulasek@intel.com>
 <1436981189-3320-1-git-send-email-tomaszx.kulasek@intel.com>
 <1436981189-3320-6-git-send-email-tomaszx.kulasek@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCHv4 5/9] null: export eth_dev_null_create
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Sep 2015 10:12:17 -0000

Hi Tomasz,

2015-07-15 19:26, Tomasz Kulasek:
> --- a/drivers/net/null/rte_eth_null.c
> +++ b/drivers/net/null/rte_eth_null.c
> @@ -2,6 +2,7 @@
>   *   BSD LICENSE
>   *
>   *   Copyright (C) IGEL Co.,Ltd.
> + *   Copyright (c) 2015 Intel Corporation.
>   *   All rights reserved.
>   *
>   *   Redistribution and use in source and binary forms, with or without
> @@ -481,7 +482,7 @@ static const struct eth_dev_ops ops = {
>  	.rss_hash_conf_get = eth_rss_hash_conf_get
>  };
>  
> -static int
> +int
>  eth_dev_null_create(const char *name,
>  		const unsigned numa_node,
>  		unsigned packet_size,

There is no rule to update a copyright but I think it is not justified here.

> --- a/drivers/net/null/rte_pmd_null_version.map
> +++ b/drivers/net/null/rte_pmd_null_version.map
> @@ -2,3 +2,10 @@ DPDK_2.0 {
>  
>  	local: *;
>  };
> +
> +DPDK_2.1 {
> +	global:
> +
> +	eth_dev_null_create;
> +
> +} DPDK_2.0;

Please, could you update it to DPDK_2.2?

Thanks