From: Thomas Monjalon <thomas@monjalon.net>
To: David Hunt <david.hunt@intel.com>
Cc: dev@dpdk.org, Liang Ma <liang.j.ma@intel.com>, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] lib/distributor: fix livelock issue on flush
Date: Mon, 29 Jul 2019 23:22:00 +0200 [thread overview]
Message-ID: <2119448.PvesTm3FVn@xps> (raw)
In-Reply-To: <20190725090301.4821-1-david.hunt@intel.com>
25/07/2019 11:03, David Hunt:
> From: Liang Ma <liang.j.ma@intel.com>
>
> The Distributor autotest can lock if ran enough times. Worker and
> distributir threads get into a livelock situation waiting on each
> other.
> Issue first encountered by RedHat in Travis CI
> https://bugs.dpdk.org/show_bug.cgi?id=316
>
> To repeat:
> `while sudo sh -c "echo 'distributor_autotest' |
> ./build/app/test/dpdk-test"; do :; done`
>
> The root cause is where we are flushing on exit, and do not wait for
> all worker packets to be returned before exiting.
> Add a delay on flush so that all worker packets are returned before
> completing the flush.
>
> Bugzilla ID: 316
> Fixes: 775003ad2f96 ("distributor: add new burst-capable library")
> Cc: stable@dpdk.org
>
> Tested-by: Michael Santana <msantana@redhat.com>
> Signed-off-by: David Hunt <david.hunt@intel.com>
> Signed-off-by: Liang Ma <liang.j.ma@intel.com>
Applied, thanks
prev parent reply other threads:[~2019-07-29 21:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 8:54 [dpdk-dev] [PATCH v1] " David Hunt
2019-07-25 9:03 ` [dpdk-dev] [PATCH v2] " David Hunt
2019-07-29 21:22 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2119448.PvesTm3FVn@xps \
--to=thomas@monjalon.net \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=liang.j.ma@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).