From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E953BA0487 for ; Mon, 29 Jul 2019 23:22:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7F31F1BF54; Mon, 29 Jul 2019 23:22:05 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id D2E6C1BF07; Mon, 29 Jul 2019 23:22:03 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5948922314; Mon, 29 Jul 2019 17:22:03 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 29 Jul 2019 17:22:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=4pNk/eqSTdcjcSVOTDLTTPGC07nYGwNUpCzpwF4juqA=; b=NQWe3+tIB4hv Ym34+o5udGpd26GRGlr0a8c85ORFre03VRvNzY2Wnsqv9ZUgEvGYQ1lncTiciZ++ tcVsF9W/Q/Gbp3iAza1B0LBQsuJSv8kKznc+EYdH2sbPmdLFDcWElri3ZlFGFDny MHKUF7CVIea2Cs4y/Xz2AxQi0SPW8Zs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=4pNk/eqSTdcjcSVOTDLTTPGC07nYGwNUpCzpwF4ju qA=; b=kniQ+Ce9VUyAFlAnFwdsDJvIdUCXRucedbeaux5Fizeh3jK1AyBrs2n0I wSl4yvVvqUZ5PLgkrd/RZKVWSnpUeu8GwasxNs4czMih965db7PHfcmuy76JY/Lj SqIe3Xo3538UpNb5xgKEPrSfBHFsXzmZXwgzM929wWNitHwYjzYWVe0DXjUp9FdN nyaVfZ78ybkGcK3/Sj1Ft2a1IWcOyPcRqfJGgCj8fK0DEpr31FnIwStLV6Mw0A4H JzgcjLEMlkSkryuGL44haGVVAiuLiKQczE3zvKOr1FT8VY9MuOsSG+1/Eovy0c49 Ik6sJnhbM9qcffWDbNOpzWS1iuMHw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrledugdduieduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrddvtdefrddukeegnecu rfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtne cuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E6C18380076; Mon, 29 Jul 2019 17:22:01 -0400 (EDT) From: Thomas Monjalon To: David Hunt Cc: dev@dpdk.org, Liang Ma , stable@dpdk.org Date: Mon, 29 Jul 2019 23:22:00 +0200 Message-ID: <2119448.PvesTm3FVn@xps> In-Reply-To: <20190725090301.4821-1-david.hunt@intel.com> References: <20190725085437.4634-1-david.hunt@intel.com> <20190725090301.4821-1-david.hunt@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] lib/distributor: fix livelock issue on flush X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 25/07/2019 11:03, David Hunt: > From: Liang Ma > > The Distributor autotest can lock if ran enough times. Worker and > distributir threads get into a livelock situation waiting on each > other. > Issue first encountered by RedHat in Travis CI > https://bugs.dpdk.org/show_bug.cgi?id=316 > > To repeat: > `while sudo sh -c "echo 'distributor_autotest' | > ./build/app/test/dpdk-test"; do :; done` > > The root cause is where we are flushing on exit, and do not wait for > all worker packets to be returned before exiting. > Add a delay on flush so that all worker packets are returned before > completing the flush. > > Bugzilla ID: 316 > Fixes: 775003ad2f96 ("distributor: add new burst-capable library") > Cc: stable@dpdk.org > > Tested-by: Michael Santana > Signed-off-by: David Hunt > Signed-off-by: Liang Ma Applied, thanks